From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 9gOSO3Rhg2TOYAEASxT56A (envelope-from ) for ; Fri, 09 Jun 2023 19:29:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id iArYOnRhg2R6gwEA9RJhRA (envelope-from ) for ; Fri, 09 Jun 2023 19:29:24 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6E5F37F4C for ; Fri, 9 Jun 2023 19:29:24 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7fv9-0005Mg-Q7; Fri, 09 Jun 2023 13:29:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7fv7-0005Ik-Nw for guix-devel@gnu.org; Fri, 09 Jun 2023 13:29:05 -0400 Received: from mail-qt1-x82d.google.com ([2607:f8b0:4864:20::82d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q7fv5-0005oC-ER for guix-devel@gnu.org; Fri, 09 Jun 2023 13:29:05 -0400 Received: by mail-qt1-x82d.google.com with SMTP id d75a77b69052e-3f9df7eb837so4026461cf.2 for ; Fri, 09 Jun 2023 10:29:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atai-org.20221208.gappssmtp.com; s=20221208; t=1686331742; x=1688923742; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qyiKtKWt89vr3JVUM5OGvs5yRdGVWnpoHd27ZVjvEms=; b=A8pH/fXGfYsyrmjrTGjPyqENv6ybcRmpbgIKJBmIhUFRfzDhLh9LHMwo8oC1My9smM 26P/QmnVwg7B/VKWVWTJM9QCkzh8wqA1YDJ7pjSen1KdzVx4jiSqvfM78SV6zkCAtD6C rxbl382B4oZJrwM1YjXyExC3ymCzInxMu1wuMOxb9GaKcoB8N/FinovyWgiXWGF8BmlX hl0JPLut9SgN72g3uUFxekylftHZAeprphnu60huz949k3Slt0SuQjNpykmX1JutE9er ftZ7FgCROCWGgtQ4X5/3FsCKavHHlM2gPy/95WG0lSaQz0qEvxyiSOTGYKYobKqN9b4v 83Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686331742; x=1688923742; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qyiKtKWt89vr3JVUM5OGvs5yRdGVWnpoHd27ZVjvEms=; b=PvBMnMw5Xo4x+EH3Jj2kAP816tx+fCWYxCeZOqV9aIV96L5bHhk8jWvrV469GVnDsY xAOeMo3lTwB0IvyJOlE0pmWmGxMVSjAzfhoFTiJJEWI0qhjCVBgD36JA6pQpmWS00wHu SryBy4FGVdn4ztOZol6wyOQNh//ngu4nIcXgmQsFJZfUIfyzj4Yrdg3Uf4jjwnTgCo1H imW+e+CAL3mB+brEj9M0GHXAHCz7W5Augilg77+OX8F5EDbtMGJmwRbTncSOa61CQngA pZyPeVM9aDhsWSQrgK3e8sIHBZqLq3o28NEI29chvmLqRHxL+9axBQvvXOofqzS8NgyZ N/Bw== X-Gm-Message-State: AC+VfDzITns/6lqomqEnRplzjjhAqPbXqY4E5uMqWUrQhziISqG8scar 6F9hIYW8CepJGkiz32lATq0r/4A0/BVF55AymShgFFOp X-Google-Smtp-Source: ACHHUZ5Jvx3I2rC1srkLU8IfKa7oDhQBVCQ7SUxGD+9Pc6V177FaDzQqxs0RTm24k+bwD86XPXcITktGH9IJyDBGrNo= X-Received: by 2002:ac8:7d0e:0:b0:3f3:8819:67eb with SMTP id g14-20020ac87d0e000000b003f3881967ebmr3040241qtb.6.1686331741931; Fri, 09 Jun 2023 10:29:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Andy Tai Date: Fri, 9 Jun 2023 10:28:25 -0700 Message-ID: Subject: Re: ping on a build fix for a build failure (main branch) To: Andreas Enge Cc: 63526-done@debbugs.gnu.org, 63952-done@debbugs.gnu.org, guix-devel@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::82d; envelope-from=lichengtai@gmail.com; helo=mail-qt1-x82d.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1686331764; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=qyiKtKWt89vr3JVUM5OGvs5yRdGVWnpoHd27ZVjvEms=; b=EQgvq6ZqhIwprvu4RhZpHmvHPjwlZa2QXM794bMRXWGyiCfdd2/Xl6wnOGLQUuccDIgxto B0SsNKM7y5PfC/Y/6I0/fLnwH1cM5P3t9xg5H7AG5S3Lw8dWN78QD0Dr5A0S+tIUjZRAWy aAW8CQ/ZUmsXTWjfq5EVAG9bwlo0mCsEdbkrByV5ze4mS/L/WNR/3TjRoUx5RcFh5rQ0Ky k1OxE08YlXy9GLqkYYYGXqNsd3A4kYKIf0b6t9GvgBy30WQ5HXVnfXrG4G3t/mm6yynkb6 tU0ViwTj8Noq68sfgwA+KItN/XaSPwQ+15BKYvuMwPGKo3OI25TThLE2iraNvg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=atai-org.20221208.gappssmtp.com header.s=20221208 header.b="A8pH/fXG"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1686331764; a=rsa-sha256; cv=none; b=QU+VEWlGjOiiCe0oxHD+1JYuJLgJIdkTsXBXhf32+IxQ4AeWjkgNYP60VetKONcN42zklO cI+K/2q4+l3AyrpVRw4RQUmBti4WS4ROHyW3gW//f4juWQw+MzF4on9OjQHBqQ60s3DPtC 5SLP8eh+PJ42rcR5oI60eYgjUjpZm9ed7iqN+DIxSjWs4sSTqUwVsVjN+LQs53AXuON61o Zeh0BKvqpJra/LmdsOE8/ukgvlm7mJadsZ17y66j0fpGAWzgJ43o9XZUEsnsIB5p9cNr5i uFPfElUTpXX7udyY6MgVFdiwNPMlRjEtVA3cnR/T5NQI/Ui2wB8/05SnfD4Yrw== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -5.76 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=atai-org.20221208.gappssmtp.com header.s=20221208 header.b="A8pH/fXG"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6E5F37F4C X-Spam-Score: -5.76 X-TUID: cZyddsy0C3l8 I did contact upstream, no response On Fri, Jun 9, 2023 at 4:07=E2=80=AFAM Andreas Enge wrote= : > > Hello Andy, > > Am Tue, May 30, 2023 at 10:54:20AM -0700 schrieb Andy Tai: > > Hi, following previous comments (thanks) I have submitted a patch to > > correctly fix a build failure due to compiler warnings, instead of > > avoiding not building tests, on this Guix bug issue: > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D63526 > > Please review the patch (which shall be a simple and low risk fix). Th= anks! > > I have reworked a bit the punctuation of the commit message, shortened > the patch file name and pushed. By this I am closing the two correspondin= g > bug reports (it would have been enough to send a second version of the > patch to the first bug). > > Did you contact upstream? Looking at the test, it looked wrong before and > after your patch... > if (len < token->data.character.len) { > hubbub_token t =3D { 0 }; > t.type =3D HUBBUB_TOKEN_CHARACTER; > t.data.character.ptr +=3D len; > t.data.character.len -=3D len; > ... > Adding to a previously undefined, now 0 pointer .ptr raised a warning > for a reason, I think; and it looks like the t.data maybe should be > token->data. But it is quite possible that this branch is not even > reached by the test. > > Andreas > --=20 Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andyta= i1010 Year 2023 =E6=B0=91=E5=9C=8B112=E5=B9=B4 =E8=87=AA=E5=8B=95=E7=9A=84=E7=B2=BE=E7=A5=9E=E5=8A=9B=E6=98=AF=E4=BF=A1=E4= =BB=B0=E8=88=87=E8=A6=BA=E6=82=9F =E8=87=AA=E5=8B=95=E7=9A=84=E8=A1=8C=E7=82=BA=E5=8A=9B=E6=98=AF=E5=8B=9E=E5= =8B=95=E8=88=87=E6=8A=80=E8=83=BD