From: "Thompson, David" <dthompson2@worcester.edu>
To: guix-devel <guix-devel@gnu.org>
Subject: [PATCH] environment: container: Do not remount network files as read-only.
Date: Thu, 17 Mar 2016 14:32:56 -0400 [thread overview]
Message-ID: <CAJ=RwfbbLB91j7xXpR00jRDW0_CgQ4rsTNXKe08ZotOc1+TSNg@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 238 bytes --]
I noticed that 'guix environment --container --network' didn't work on
an Ubuntu machine I was on, and the culprit was remounting things like
/etc/resolv.conf read-only after the initial bind mount.
What do y'all think?
Thanks,
- Dave
[-- Attachment #2: 0001-environment-container-Do-not-remount-network-files-a.patch --]
[-- Type: text/x-patch, Size: 1629 bytes --]
From 9820a937ef5ab6793f2495a1ce50ff14abb6ec7c Mon Sep 17 00:00:00 2001
From: David Thompson <dthompson@vistahigherlearning.com>
Date: Thu, 17 Mar 2016 14:01:19 -0400
Subject: [PATCH] environment: container: Do not remount network files as
read-only.
* gnu/scripts/environment.scm (launch-environment/container): Make
network mappings writable.
---
guix/scripts/environment.scm | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/guix/scripts/environment.scm b/guix/scripts/environment.scm
index b122b4c..896804b 100644
--- a/guix/scripts/environment.scm
+++ b/guix/scripts/environment.scm
@@ -391,7 +391,13 @@ host file systems to mount inside the container."
(file-system-mapping
(source file)
(target file)
- (writable? #f))))
+ ;; An unpriviliged user might not
+ ;; be able to remount
+ ;; /etc/resolv.conf as read-only,
+ ;; so we say that it is writable
+ ;; here, even though in practice
+ ;; it is not.
+ (writable? #t))))
%network-configuration-files)
'())
;; Mappings for the union closure of all inputs.
--
2.6.3
next reply other threads:[~2016-03-17 18:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 18:32 Thompson, David [this message]
2016-03-18 20:51 ` [PATCH] environment: container: Do not remount network files as read-only Ludovic Courtès
2016-03-26 14:06 ` Thompson, David
2016-03-26 16:29 ` Drew C
2016-03-26 16:49 ` Thompson, David
2016-03-26 16:59 ` Drew C
2016-03-26 18:43 ` Ludovic Courtès
2016-03-26 18:54 ` Drew C
2016-03-26 19:23 ` Thompson, David
2016-03-27 17:43 ` Ludovic Courtès
2016-03-28 0:32 ` Thompson, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ=RwfbbLB91j7xXpR00jRDW0_CgQ4rsTNXKe08ZotOc1+TSNg@mail.gmail.com' \
--to=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.