From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Thompson, David" <dthompson2@worcester.edu>
Subject: Re: [PATCH 4/7] gnu: Add llvm-for-extempore.
Date: Wed, 14 Sep 2016 10:24:57 -0400
Message-ID: <CAJ=RwfbTR1oNRpPRDH50e8vHZC3TkCrRS7Q4fsb=d3YhmicZag@mail.gmail.com>
References: <20160914093812.28422-1-rekado@elephly.net>
	<20160914093812.28422-5-rekado@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35497)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1bkB8T-00049q-WD
	for guix-devel@gnu.org; Wed, 14 Sep 2016 10:26:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1bkB8Q-0003bI-83
	for guix-devel@gnu.org; Wed, 14 Sep 2016 10:26:00 -0400
Received: from mail-yb0-f193.google.com ([209.85.213.193]:33269)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1bkB8Q-0003b3-3d
	for guix-devel@gnu.org; Wed, 14 Sep 2016 10:25:58 -0400
Received: by mail-yb0-f193.google.com with SMTP id x93so610248ybh.0
	for <guix-devel@gnu.org>; Wed, 14 Sep 2016 07:25:58 -0700 (PDT)
In-Reply-To: <20160914093812.28422-5-rekado@elephly.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel <guix-devel@gnu.org>

On Wed, Sep 14, 2016 at 5:38 AM, Ricardo Wurmus <rekado@elephly.net> wrote:
> * gnu/packages/llvm.scm (llvm-for-extempore): New variable.
> ---
>  gnu/packages/llvm.scm | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm
> index a9eba79..b55a200 100644
> --- a/gnu/packages/llvm.scm
> +++ b/gnu/packages/llvm.scm
> @@ -3,6 +3,7 @@
>  ;;; Copyright =C2=A9 2015 Mark H Weaver <mhw@netris.org>
>  ;;; Copyright =C2=A9 2015 Ludovic Court=C3=A8s <ludo@gnu.org>
>  ;;; Copyright =C2=A9 2016 Dennis Mungai <dmngaie@gmail.com>
> +;;; Copyright =C2=A9 2016 Ricardo Wurmus <rekado@elephly.net>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -267,3 +268,10 @@ code analysis tools.")
>  (define-public clang-3.5
>    (clang-from-llvm llvm-3.5 clang-runtime-3.5
>                     "0846h8vn3zlc00jkmvrmy88gc6ql6014c02l4jv78fpvfigmgssg=
"))
> +
> +(define-public llvm-for-extempore
> +  (package (inherit llvm-3.7)
> +    (source
> +     (origin
> +       (inherit (package-source llvm-3.7))
> +       (patches (list (search-patch "llvm-for-extempore.patch")))))))

This could use a comment explaining the rationale.  Also, you forgot
to include the patch file in this commit.

- Dave