From: "Thompson, David" <dthompson2@worcester.edu>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 4/7] gnu: Add llvm-for-extempore.
Date: Wed, 14 Sep 2016 10:24:57 -0400 [thread overview]
Message-ID: <CAJ=RwfbTR1oNRpPRDH50e8vHZC3TkCrRS7Q4fsb=d3YhmicZag@mail.gmail.com> (raw)
In-Reply-To: <20160914093812.28422-5-rekado@elephly.net>
On Wed, Sep 14, 2016 at 5:38 AM, Ricardo Wurmus <rekado@elephly.net> wrote:
> * gnu/packages/llvm.scm (llvm-for-extempore): New variable.
> ---
> gnu/packages/llvm.scm | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm
> index a9eba79..b55a200 100644
> --- a/gnu/packages/llvm.scm
> +++ b/gnu/packages/llvm.scm
> @@ -3,6 +3,7 @@
> ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
> ;;; Copyright © 2015 Ludovic Courtès <ludo@gnu.org>
> ;;; Copyright © 2016 Dennis Mungai <dmngaie@gmail.com>
> +;;; Copyright © 2016 Ricardo Wurmus <rekado@elephly.net>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -267,3 +268,10 @@ code analysis tools.")
> (define-public clang-3.5
> (clang-from-llvm llvm-3.5 clang-runtime-3.5
> "0846h8vn3zlc00jkmvrmy88gc6ql6014c02l4jv78fpvfigmgssg"))
> +
> +(define-public llvm-for-extempore
> + (package (inherit llvm-3.7)
> + (source
> + (origin
> + (inherit (package-source llvm-3.7))
> + (patches (list (search-patch "llvm-for-extempore.patch")))))))
This could use a comment explaining the rationale. Also, you forgot
to include the patch file in this commit.
- Dave
next prev parent reply other threads:[~2016-09-14 14:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 9:38 [PATCH 0/7] Add Extempore Ricardo Wurmus
2016-09-14 9:38 ` [PATCH 1/7] gnu: Add nanovg-for-extempore Ricardo Wurmus
2016-09-14 14:23 ` Thompson, David
2016-09-14 9:38 ` [PATCH 2/7] gnu: Add assimp Ricardo Wurmus
2016-09-14 14:15 ` Thompson, David
2016-09-14 9:38 ` [PATCH 3/7] gnu: Add stb-image-for-extempore Ricardo Wurmus
2016-09-14 14:16 ` Thompson, David
2016-09-14 9:38 ` [PATCH 4/7] gnu: Add llvm-for-extempore Ricardo Wurmus
2016-09-14 14:24 ` Thompson, David [this message]
2016-09-16 13:47 ` Ricardo Wurmus
2016-09-14 14:32 ` Danny Milosavljevic
2016-09-14 9:38 ` [PATCH 5/7] gnu: Add kiss-fft-for-extempore Ricardo Wurmus
2016-09-14 14:17 ` Thompson, David
2016-09-14 9:38 ` [PATCH 6/7] gnu: Add portmidi-for-extempore Ricardo Wurmus
2016-09-14 14:25 ` Thompson, David
2016-09-14 19:25 ` Ricardo Wurmus
2016-09-14 9:38 ` [PATCH 7/7] gnu: Add Extempore Ricardo Wurmus
2016-09-16 15:33 ` [PATCH 0/7] " Ricardo Wurmus
2016-09-18 7:38 ` Andreas Enge
2016-09-21 19:44 ` Ricardo Wurmus
2016-09-21 20:08 ` Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ=RwfbTR1oNRpPRDH50e8vHZC3TkCrRS7Q4fsb=d3YhmicZag@mail.gmail.com' \
--to=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.