From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:45587)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hjCyG-0006sW-S3
 for guix-patches@gnu.org; Thu, 04 Jul 2019 21:25:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hjCyF-0004Kd-Qs
 for guix-patches@gnu.org; Thu, 04 Jul 2019 21:25:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:43325)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hjCyF-0004KW-Nt
 for guix-patches@gnu.org; Thu, 04 Jul 2019 21:25:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hjCyD-0000Wd-O8
 for guix-patches@gnu.org; Thu, 04 Jul 2019 21:25:03 -0400
Subject: [bug#36404] [PATCH v4 1/4] ssh: Add 'identity' keyword to
 'open-ssh-session'.
Resent-Message-ID: <handler.36404.B36404.15622898451946@debbugs.gnu.org>
MIME-Version: 1.0
References: <87o92ianbj.fsf@sdf.lonestar.org> <87o92glap5.fsf@dustycloud.org>
 <878sthoqzi.fsf@gnu.org> <87imsl9tsx.fsf_-_@sdf.lonestar.org>
 <87ef399tpu.fsf_-_@sdf.lonestar.org> <87a7dx9tog.fsf_-_@sdf.lonestar.org>
 <875zol9tn2.fsf_-_@sdf.lonestar.org> <871rz99tl9.fsf_-_@sdf.lonestar.org>
 <875zoldqah.fsf@kyleam.com> <87muhwtmfp.fsf@sdf.lonestar.org>
 <871rz874l2.fsf@kyleam.com> <877e90tj7l.fsf_-_@sdf.lonestar.org>
 <8736jotj5v.fsf_-_@sdf.lonestar.org>
In-Reply-To: <8736jotj5v.fsf_-_@sdf.lonestar.org>
From: "Thompson, David" <dthompson2@worcester.edu>
Date: Thu, 4 Jul 2019 21:23:44 -0400
Message-ID: <CAJ=RwfbT9mXROhZpdFn9aKS4xuFEsCHwAjCfX2OQju=OhKcqhQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: "Jakob L. Kreuze" <zerodaysfordays@sdf.lonestar.org>
Cc: 36404@debbugs.gnu.org

On Tue, Jul 2, 2019 at 1:56 PM Jakob L. Kreuze
<zerodaysfordays@sdf.lonestar.org> wrote:
>
> * guix/ssh.scm (open-ssh-session): Add 'identity' keyword argument.
> ---
>  guix/ssh.scm | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/guix/ssh.scm b/guix/ssh.scm
> index 9b9baf54e..9bf10b9a0 100644
> --- a/guix/ssh.scm
> +++ b/guix/ssh.scm
> @@ -57,12 +57,14 @@
>  (define %compression
>    "zlib@openssh.com,zlib")
>
> -(define* (open-ssh-session host #:key user port
> +(define* (open-ssh-session host #:key user port identity
>                             (compression %compression))
> -  "Open an SSH session for HOST and return it.  When USER and PORT are #f, use
> -default values or whatever '~/.ssh/config' specifies; otherwise use them.
> -Throw an error on failure."
> +  "Open an SSH session for HOST and return it.  IDENTITY specifies the path of

Replace "path" with "file name".  Lots of people use them
interchangeably, but GNU makes a clear distinction between the two
terms.

> +a private key to use for authenticating with the host.  When USER, PORT, or
> +IDENTITY are #f, use default values or whatever '~/.ssh/config' specifies;
> +otherwise use them.  Throw an error on failure."
>    (let ((session (make-session #:user user
> +                               #:identity identity
>                                 #:host host
>                                 #:port port
>                                 #:timeout 10       ;seconds
> --
> 2.22.0