From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thompson, David" Subject: Re: [PATCH] ruby-rake-compiler Date: Sat, 4 Jul 2015 09:55:57 -0400 Message-ID: References: <20150704130829.GA14470@thebird.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBNvH-0003Fq-1k for guix-devel@gnu.org; Sat, 04 Jul 2015 09:56:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZBNvD-0004ZJ-MN for guix-devel@gnu.org; Sat, 04 Jul 2015 09:56:02 -0400 Received: from mail-la0-f44.google.com ([209.85.215.44]:33075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBNvD-0004Yi-Fg for guix-devel@gnu.org; Sat, 04 Jul 2015 09:55:59 -0400 Received: by laar3 with SMTP id r3so111199836laa.0 for ; Sat, 04 Jul 2015 06:55:57 -0700 (PDT) In-Reply-To: <20150704130829.GA14470@thebird.nl> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Pjotr Prins Cc: guix-devel Hey Pjotr, On Sat, Jul 4, 2015 at 9:08 AM, Pjotr Prins wrote: > Attached a Ruby module in preparation of Nokogiri support. I've applied this patch with a number of changes: * Removed the use of 'snippet'. That is for making changes that aren't specific to building for Guix, like removing a piece of non-free source. The cucumber task file is now deleted in a phase that runs before the 'build' phase. * Used the 'modify-phases' syntax instead of 'alist-replace' and friends. * Removed the rspec native input. It can be added back in when we can actually run the test suite. * Cleaned up synopsis/description to use more neutral language. * Fixed license. It's actually the Expat license, which is verrrrry similar to the X11 license. > (I am pretty close as described in > https://github.com/pjotrp/guix-notes/blob/master/RUBYGEMS-Nokogiri.org). > > Cucumber support comes later (it depends on Nokogiri itself). Sounds like we'll have to do a similar dance that I did with rspec: Disable test suites for all dependencies of cucumber. :( > David: there are quite a few modules now that build gems through 'rake > gem'. Would it be an idea to try that by default when there is no > gemspec file? Yes, I think that would be a good change. Want to write a patch that does that and updates all of the relevant package recipes? Thanks! It will be nice to have Nokogiri! - Dave