From: "Thompson, David" <dthompson2@worcester.edu>
To: Pjotr Prins <pjotr.public12@thebird.nl>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] ruby-rake-compiler
Date: Sat, 4 Jul 2015 09:55:57 -0400 [thread overview]
Message-ID: <CAJ=RwfbQ+_LiMyzU2S-NcQPegGMR-1HLL8024Ry+qgSFqXtWaQ@mail.gmail.com> (raw)
In-Reply-To: <20150704130829.GA14470@thebird.nl>
Hey Pjotr,
On Sat, Jul 4, 2015 at 9:08 AM, Pjotr Prins <pjotr.public12@thebird.nl> wrote:
> Attached a Ruby module in preparation of Nokogiri support.
I've applied this patch with a number of changes:
* Removed the use of 'snippet'. That is for making changes that
aren't specific to building for Guix, like removing a piece of
non-free source. The cucumber task file is now deleted in a phase
that runs before the 'build' phase.
* Used the 'modify-phases' syntax instead of 'alist-replace' and friends.
* Removed the rspec native input. It can be added back in when we can
actually run the test suite.
* Cleaned up synopsis/description to use more neutral language.
* Fixed license. It's actually the Expat license, which is verrrrry
similar to the X11 license.
> (I am pretty close as described in
> https://github.com/pjotrp/guix-notes/blob/master/RUBYGEMS-Nokogiri.org).
>
> Cucumber support comes later (it depends on Nokogiri itself).
Sounds like we'll have to do a similar dance that I did with rspec:
Disable test suites for all dependencies of cucumber. :(
> David: there are quite a few modules now that build gems through 'rake
> gem'. Would it be an idea to try that by default when there is no
> gemspec file?
Yes, I think that would be a good change. Want to write a patch that
does that and updates all of the relevant package recipes?
Thanks! It will be nice to have Nokogiri!
- Dave
next prev parent reply other threads:[~2015-07-04 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-04 13:08 [PATCH] ruby-rake-compiler Pjotr Prins
2015-07-04 13:55 ` Thompson, David [this message]
2015-07-04 14:28 ` Pjotr Prins
2015-07-04 14:45 ` Thompson, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ=RwfbQ+_LiMyzU2S-NcQPegGMR-1HLL8024Ry+qgSFqXtWaQ@mail.gmail.com' \
--to=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
--cc=pjotr.public12@thebird.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.