From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42662)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ejWjF-0004uk-7e
	for guix-patches@gnu.org; Wed, 07 Feb 2018 15:54:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ejWjC-0005um-4z
	for guix-patches@gnu.org; Wed, 07 Feb 2018 15:54:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:53825)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ejWjB-0005ug-UY
	for guix-patches@gnu.org; Wed, 07 Feb 2018 15:54:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ejWjB-0003UE-N8
	for guix-patches@gnu.org; Wed, 07 Feb 2018 15:54:01 -0500
Subject: [bug#30380] gnu: Add dolphin-emulator.
Resent-Message-ID: <handler.30380.B30380.151803679113343@debbugs.gnu.org>
MIME-Version: 1.0
In-Reply-To: <20180207214353.36366a2c@alma-ubu>
References: <CAJ=RwfaFVeQ+3i_h8SQDXa1wurWgbzpCoxUj5Lx1gqwPyNfuLg@mail.gmail.com>
	<20180207214353.36366a2c@alma-ubu>
From: "Thompson, David" <dthompson2@worcester.edu>
Date: Wed, 7 Feb 2018 15:53:03 -0500
Message-ID: <CAJ=RwfbOySqzLGMqiSVa7PKw1+5E2967Q-e_g8TV4fdwyQB=bQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= <bjoern.hoefling@bjoernhoefling.de>
Cc: 30380@debbugs.gnu.org

Hello,

On Wed, Feb 7, 2018 at 3:43 PM, Bj=C3=B6rn H=C3=B6fling
<bjoern.hoefling@bjoernhoefling.de> wrote:
> On Wed, 7 Feb 2018 11:58:02 -0500
> "Thompson, David" <dthompson2@worcester.edu> wrote:
>
>> Here a couple of patches that add the Dolphin emulator.  I used a Git
>> snapshot because the project goes *years* between releasing official
>> source tarballs while at the same time directing users to use binaries
>> built from the latest commit in their Git repo, so I think packaging
>> the Git source aligns best with what a Dolphin user would expect.
>>
>> - Dave
>
> Hi Dave,
>
> I haven't done a full review, here are some things I noticed:
>
> * License is GPLv2+, not only v2.
> * dolphin/Data/Sys/GC/font_*.bin: Licensed under ASL2.0.
> * The homepage states this package is only available for x86_64.
>   If that is true, add a line like this to your package:
>   (supported-systems '("x86_64-linux"))
> * dolphin/Installer/dxredist/ contains (Windows) binaries. Remove with
>   a snippet.
> * Remove dolphin/Externals in a snippet. Or at least those that you
>   have added as dependencies.
> * There are binaries in the distribution:
>   dolphin/Data/Sys/GC/dsp_coef.bin and dsp_rom.bin
>   The commit message says something like "based off of observed
> effects on the virtual machine", but still this is binaray. Or is there
>   some way of building this from commented assembly? Here is the full
>   commit message:
>   https://github.com/dolphin-emu/dolphin/commit/e3531d17d700339828d7bab19=
2c66fba5fcbac86
>
> * Finally, doesn't this encourage people to use non-free software, i.e.
>   the original manufacturers game discs? Or is there any free software
>   implementation running on this emulator?
>
> Bj=C3=B6rn

Nevermind. I am dropping this patch set.

Sorry,

- Dave