From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thompson, David" Subject: Re: [PATCH] build: file-systems: Allow for bind mounting regular files. Date: Tue, 18 Aug 2015 12:43:22 -0400 Message-ID: References: <87a8uarf6g.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> <87bnepriup.fsf@gmail.com> <87614coapz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRjyw-0004dj-QM for guix-devel@gnu.org; Tue, 18 Aug 2015 12:43:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZRjyt-0000PN-LA for guix-devel@gnu.org; Tue, 18 Aug 2015 12:43:26 -0400 Received: from mail-yk0-f181.google.com ([209.85.160.181]:35709) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRjyt-0000PB-HV for guix-devel@gnu.org; Tue, 18 Aug 2015 12:43:23 -0400 Received: by ykbi184 with SMTP id i184so99700107ykb.2 for ; Tue, 18 Aug 2015 09:43:23 -0700 (PDT) In-Reply-To: <87614coapz.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: guix-devel , Alex Kost On Tue, Aug 18, 2015 at 11:52 AM, Ludovic Court=C3=A8s wrote= : > "Thompson, David" skribis: > >> +(define (regular-file? file-name) >> + "Return #t if FILE-NAME is a regular file." >> + (eq? (stat:type (stat file-name)) 'regular)) > > I see you moved this procedure to (gnu build file-systems), which is > reasonable. I did this to avoid a full rebuild. A patch for core-updates could move it= . > I wonder if it should use =E2=80=98lstat=E2=80=99 instead of =E2=80=98sta= t=E2=80=99? To follow symlinks or not? I guess the answer is "no". I can change it to lstat. - Dave