From: "Thompson, David" <dthompson2@worcester.edu>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 1/2] gnu: Make 'mount' interface in static Guile consistent with Guix API.
Date: Fri, 19 Jun 2015 08:02:54 -0400 [thread overview]
Message-ID: <CAJ=RwfbLNd-=CpQBFE2HrGRogCTTDoV82BnuLH_jvptTbwNUKQ@mail.gmail.com> (raw)
In-Reply-To: <87zj3vzzzo.fsf@gnu.org>
On Fri, Jun 19, 2015 at 7:42 AM, Ludovic Courtès <ludo@gnu.org> wrote:
> David Thompson <dthompson2@worcester.edu> skribis:
>
>> From 6efe8e786674d40e01df48c7df9a952107831ad9 Mon Sep 17 00:00:00 2001
>> From: David Thompson <davet@gnu.org>
>> Date: Thu, 18 Jun 2015 20:21:41 -0400
>> Subject: [PATCH 1/2] gnu: Make 'mount' interface in static Guile consistent
>> with Guix API.
>>
>> Rather than expecting a pointer, the version of 'mount' in
>> guile-static-stripped now takes a string for the 'options' argument, just like
>> the 'mount' procedure in (guix build syscalls).
>>
>> * gnu/packages/patches/guile-linux-syscalls.patch (mount): Expect a string or
>> #f for 'options' argument.
>> * gnu/build/file-systems.scm (mount-file-system): Use new 'mount' interface.
>
> LGTM!
>
> Please make sure there are no remaining calls to ‘mount’ that use
> pointers instead of strings, if you haven’t already.
I can't find any remaining calls to do this. Pushed. Thanks!
prev parent reply other threads:[~2015-06-19 12:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 0:43 [PATCH 1/2] gnu: Make 'mount' interface in static Guile consistent with Guix API David Thompson
2015-06-19 11:42 ` Ludovic Courtès
2015-06-19 12:02 ` Thompson, David [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ=RwfbLNd-=CpQBFE2HrGRogCTTDoV82BnuLH_jvptTbwNUKQ@mail.gmail.com' \
--to=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.