From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MLWKA7QmQmPqYgAAbAwnHQ (envelope-from ) for ; Sun, 09 Oct 2022 03:41:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id yNJ6A7QmQmN+NAEAauVa8A (envelope-from ) for ; Sun, 09 Oct 2022 03:41:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A05F91B6D3 for ; Sun, 9 Oct 2022 03:41:07 +0200 (CEST) Received: from localhost ([::1]:43934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohLJS-0003Wh-91 for larch@yhetil.org; Sat, 08 Oct 2022 21:41:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53476) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohLJO-0003WS-Qe for bug-guix@gnu.org; Sat, 08 Oct 2022 21:41:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42598) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohLJO-0007ws-JF for bug-guix@gnu.org; Sat, 08 Oct 2022 21:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohLJO-0000rv-8X for bug-guix@gnu.org; Sat, 08 Oct 2022 21:41:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks Resent-From: "Thompson, David" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 09 Oct 2022 01:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25957 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: zimoun Cc: Efraim Flashner , 25957@debbugs.gnu.org Received: via spool by 25957-submit@debbugs.gnu.org id=B25957.16652796293280 (code B ref 25957); Sun, 09 Oct 2022 01:41:02 +0000 Received: (at 25957) by debbugs.gnu.org; 9 Oct 2022 01:40:29 +0000 Received: from localhost ([127.0.0.1]:41676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohLIq-0000qp-Pp for submit@debbugs.gnu.org; Sat, 08 Oct 2022 21:40:29 -0400 Received: from mail-lj1-f177.google.com ([209.85.208.177]:39502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohLIp-0000qS-1i for 25957@debbugs.gnu.org; Sat, 08 Oct 2022 21:40:27 -0400 Received: by mail-lj1-f177.google.com with SMTP id bn8so9719445ljb.6 for <25957@debbugs.gnu.org>; Sat, 08 Oct 2022 18:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XdqSp77R78TkA+DRpioC/0X1bSEkSYqyY5TACDxWD/E=; b=p7LsspWBa4dzY6o5zqH5O0XgV9q4/4r4Mn6a9aZ8RU74CWyb095WRwX+U+ik/jQ4k8 GWnm2z12nEtwcTYiJKlacMGN7xgMUCPSTdTr7kBO1wQgFpT4tCkkxus96E5v096LAgde cm11UzaJW+P5xLJVgGYltQoq4nMulrtCQ/DrQZbyU46lHwOkb6t3wFm+GiAJWK2efJvo 5dNXgzZQd7BtQ0UwRqNd0d10XdFeN7V0A1+pCVPZuQaL/Bt1+I/OjmI1txGRSD1MkTM5 2UHf5CAfSC9RPMYK15fkO1YIz1g/sFMm1hW9ET/j+zNCbdLnxUI35TtTzM+8VdwSvl0D xmgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XdqSp77R78TkA+DRpioC/0X1bSEkSYqyY5TACDxWD/E=; b=F1VZsd27Er1emBtl1KQ75OJd+MbAkNb0Wo9I88K9xtfwnIDXYTS34kKqbzAcMJ0K3c VLdMQPYyxwHF/MbndmVhBY4Y2TMfUxCu+VNvB15ztLJuQN8g2dgy7DZtlz6asZ1B14jS tN/P12ouPmHc//Lhn8DjwEBP7i9y1LckJrP4GAkx1eAdNbOIqzM02oD3uwXe+J1jol4J tPOccopowreJGIUkzLhi1Mrj+BVjYJQtY+/Iu/BP2snv0XpJQ6YSrPluQyHZUcwR4U+n EeyWTUm5JP7436CxSUNvDVF6N7IQBZWi0cLSsBCXgiAUmiSMd/msDoukVKLygZ5rH+X3 YbYg== X-Gm-Message-State: ACrzQf1LWCtMecoRdo99PXEzxSl1Rq/fYZVpGreaCkG+3d3MN1FsbHtY 1uIUnCaR+t9j6NdJVA8ptGoezF1uhi/YzFLAhpXQrw== X-Google-Smtp-Source: AMsMyM5V9RudcIufV9lxuxBDyUCJQKsh2QgxhJORD04CCi4tZ8deR2HQSIKUrYJQN2h7/bCWfhQhrrub+i/isq71UbQ= X-Received: by 2002:a2e:9f12:0:b0:26e:8558:c6a5 with SMTP id u18-20020a2e9f12000000b0026e8558c6a5mr2919159ljk.135.1665279620911; Sat, 08 Oct 2022 18:40:20 -0700 (PDT) MIME-Version: 1.0 References: <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> <871qsqtewp.fsf@gmail.com> <86k05as6t3.fsf@gmail.com> In-Reply-To: <86k05as6t3.fsf@gmail.com> From: "Thompson, David" Date: Sat, 8 Oct 2022 21:40:09 -0400 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665279667; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=XdqSp77R78TkA+DRpioC/0X1bSEkSYqyY5TACDxWD/E=; b=MiiWnBr9SCx6QnvMK8vGGYaWWpQX6LMse/F9RSQe2b0syyVFV4fm9XM/N5Ej4+hpCidAhw yhPpXPpiqDVhRkIcJUy5CMN7HEyrdm5MMFzoIRjAQiGms/9qkA5xbilD4l8f6EbmCqqH1r O/vZwFqtjgYNq73vxJimyNTgWtf19DduqyZwnylYlOzBel5Ex3tJcBcd9ACpXaIolcosHd 3xEwBtkczfse3bsp7dQ3NRpICF8S0GYvcM7ouzqvKFdJvDOQwGib5T9rUP/RuzeYCIh8vc Ji1QdB4jbSc1vkvmFfHPMVVLj7GEnVgRFVa822j2599bSlMDAAuYqhMMaQggqw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665279667; a=rsa-sha256; cv=none; b=B5EftKngFKcZHCbLlxgfi7O6GQue31htaD3Ww/R7tzIeOt0IeArIDByEDiNOEP4VlqnO5x FcRS3cW0giEkX56AiVkC+ZhNcYDFxznK52ocmF5gA7TlrhQFpuefk+P83oLIzqarg5Pacb 8ANITlyVkrZ3HkLBxzZyrGfL8GcG+Rqk6IK0ljFAb5EFaMMGxvvwO8RVeSCvxCxh8fgtT2 CQOK8Gf+SEP75zuhDJ1RhK9nbNvpVjW97IMbgXHk3qcqpoiLi6UjF+H8kMcFgM9gDAcphr 6i+VXuLcqxcEai7rpSX48WLQTMKu4CJ/nk1LO9EVE4sWz95BS6xuG+muwQDQwg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=worcester-edu.20210112.gappssmtp.com header.s=20210112 header.b=p7LsspWB; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.01 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=worcester-edu.20210112.gappssmtp.com header.s=20210112 header.b=p7LsspWB; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A05F91B6D3 X-Spam-Score: 2.01 X-Migadu-Scanner: scn0.migadu.com X-TUID: jpTgIFJLFyws On Sat, Oct 8, 2022 at 11:16 AM zimoun wrote: > > Hi Dave, > > On Thu, 06 Oct 2022 at 09:26, "Thompson, David" wrote: > > > Some news: I have updated the gitolite package to use G-expressions. > > The package builds and the gitolite system test passes so I pushed > > that change to master a little while ago. That patch has made the > > (hopefully) final step in this saga easier. The attached patch > > introduces a 'make-gitolite' procedure that can be used to add > > arbitrary packages to the wrappers for the gitolite and gitolite-shell > > programs. The return value of this procedure can be used in the > > gitolite service configuration to enable the desired optional features > > like Redis or git-annex. The base package inputs are unchanged and > > the gitolite system test still passes. > > Thank you for working on this! Neat. > > Well, your proposal LGTM although I do not see the difference between > =E2=80=99make-gitolite=E2=80=99 and a simple =E2=80=99inherent=E2=80=99 f= or building a package variant. > Yeah, this make-gitolite is probably more handy. The reason for the constructor is so that extra packages can be easily added to the gexp that calls wrap-program. It would be much harder to modify the package in this way without a helper procedure. - Dave