Bumping NodeJS from 18.19.0 to 20.0.0

Bumping NodeJS from 18.19.0 to 20.0.0

[Ashvith Shetty]

[-- Attachment #1.1: Type: text/plain, Size: 1032 bytes --]

Hello folks,
I've been trying to bump NodeJS to a newer version. My initial attempt was
to bump to 22.0.0, but since that would be a huge leap, and would
potentially require bumping other dependencies, I'm trying a smaller jump
to 20.0.0, without the need of having to create package variants. I will
attach the patch below, but that hasn't been successful so far. Here's the
trimmed build log:

```console
$ zcat
/var/log/guix/drvs/cw/ym532jrh5bcmqqfxgwlzr3h7aljhdx-node-20.0.0.drv.gz
...
Failed tests:
out/Release/node --experimental-permission --allow-fs-read=*
--allow-child-process
/tmp/guix-build-node-20.0.0.drv-0/node-v20.0.0/test/parallel/test-permission-fs-wildcard.js
make: *** [Makefile:535: test-ci-js] Error 1

Test suite failed, dumping logs.
error: in phase 'check': uncaught exception:
%exception #<&invoke-error program: "make" arguments: ("test-ci-js" "-j"
"8") exit-status: 2 term-signal: #f stop-signal: #f>
phase `check' failed after 566.9 seconds
command "make" "test-ci-js" "-j" "8" failed with status 2
```

[-- Attachment #1.2: Type: text/html, Size: 1280 bytes --]

[-- Attachment #2: bump-to-node-20.patch --]
[-- Type: application/octet-stream, Size: 2218 bytes --]

diff --git a/gnu/packages/adns.scm b/gnu/packages/adns.scm
index bf07219d17..041c68e311 100644
--- a/gnu/packages/adns.scm
+++ b/gnu/packages/adns.scm
@@ -167,7 +167,7 @@ (define-public c-ares-for-node
    (package
      (inherit c-ares)
      (name "c-ares")
-     (version "1.18.1")
+     (version "1.19.0")
      (source (origin
                (method url-fetch)
                (uri (string-append
@@ -175,7 +175,7 @@ (define-public c-ares-for-node
                      ".tar.gz"))
                (sha256
                 (base32
-                 "1kxviskwsaa7dcgscvssxa8ps88pdq7kq4z93gxvz7sam2l54z8s"))))
+                 "1lqxmnvqar93j9zkz4jmvjk4kvq10jn2q01970lk3m9zw8vvmkmz"))))
      (arguments
       '(#:phases
         (modify-phases %standard-phases
diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index a9d4e5ab13..1e082f40c0 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -669,7 +669,7 @@ (define-public node-llparse-bootstrap
 (define-public llhttp-bootstrap
   (package
     (name "llhttp")
-    (version "6.0.11")
+    (version "8.1.0")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -678,7 +678,7 @@ (define-public llhttp-bootstrap
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "16gaylka6nx9bsff9xga3s8xihxm3k7svrb88lr4dj2s4pzlfga9"))
+                "1cq3q3jybibppjhhiymdfmnqgbvn77j7b4ks7lil0lrc3vnnp87f"))
               (modules '((guix build utils)))
               (snippet
                '(begin
@@ -738,14 +738,14 @@ (define-public llhttp-bootstrap
 (define-public node-lts
   (package
     (inherit node)
-    (version "18.19.0")
+    (version "20.0.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://nodejs.org/dist/v" version
                                   "/node-v" version ".tar.gz"))
               (sha256
                (base32
-                "05qc1dgmrms73073n4l36jrcxf6ygqj959d3cngy5qclrg0isk6x"))
+                "05fz82dvj4kahjy1jhhr2w96drz50g30hdgxw8k59lm5am9krvn1"))
               (modules '((guix build utils)))
               (snippet
                '(begin

Re: Bumping NodeJS from 18.19.0 to 20.0.0

[Thompson, David]

Hi Ashvith,

On Thu, May 16, 2024 at 2:40 PM Ashvith Shetty
<ashvithshetty10@gmail.com> wrote:
>
> Hello folks,
> I've been trying to bump NodeJS to a newer version. My initial attempt was to bump to 22.0.0, but since that would be a huge leap, and would potentially require bumping other dependencies, I'm trying a smaller jump to 20.0.0, without the need of having to create package variants. I will attach the patch below, but that hasn't been successful so far.

I'd like to get NodeJS 22 in Guix, as well, as it is the first release
that is compatible with Guile Hoot. I tried to update to 20 or 21
awhile ago and discovered that a lot of stuff probably needs to change
in the bootstrapping packages. So, I just resorted to a local package
that doesn't try to unbundle anything at all. I don't have any real
advice to offer but I wanted to wish you luck because this is an
important package to update!

- Dave

Re: Bumping NodeJS from 18.19.0 to 20.0.0

[Ashvith Shetty]

[-- Attachment #1: Type: text/plain, Size: 1557 bytes --]

Hey David,
Thank you for sharing your concern.
Interestingly, I've also been trying to play around with Hoot in hopes of
learning about WASM!
Coming back to the topic, I've found out that this issue
<https://github.com/nodejs/node/issues/50659> exists for 20.9.0 and below.
Therefore, I'll be deleting this test within the expression, and hopefully,
there should be no more issues.
We could revert this for the post 20.9.0 version. I'll test this out by
building locally once.

On Thu, May 16, 2024 at 6:43 PM Thompson, David <dthompson2@worcester.edu>
wrote:

> Hi Ashvith,
>
> On Thu, May 16, 2024 at 2:40 PM Ashvith Shetty
> <ashvithshetty10@gmail.com> wrote:
> >
> > Hello folks,
> > I've been trying to bump NodeJS to a newer version. My initial attempt
> was to bump to 22.0.0, but since that would be a huge leap, and would
> potentially require bumping other dependencies, I'm trying a smaller jump
> to 20.0.0, without the need of having to create package variants. I will
> attach the patch below, but that hasn't been successful so far.
>
> I'd like to get NodeJS 22 in Guix, as well, as it is the first release
> that is compatible with Guile Hoot. I tried to update to 20 or 21
> awhile ago and discovered that a lot of stuff probably needs to change
> in the bootstrapping packages. So, I just resorted to a local package
> that doesn't try to unbundle anything at all. I don't have any real
> advice to offer but I wanted to wish you luck because this is an
> important package to update!
>
> - Dave
>

[-- Attachment #2: Type: text/html, Size: 2044 bytes --]