From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thompson, David" Subject: Re: [PATCH] gnu: Add abbaye Date: Fri, 2 May 2014 08:55:58 -0400 Message-ID: References: <878uqmwcom.fsf@labrys.i-did-not-set--mail-host-address--so-tickle-me> <87d2fx3h2a.fsf@gnu.org> <87tx99hgdg.fsf@labrys.i-did-not-set--mail-host-address--so-tickle-me> <877g6531n6.fsf@gnu.org> <87lhukbqym.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgD0Y-0000IN-Os for guix-devel@gnu.org; Fri, 02 May 2014 08:56:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgD0T-0005bO-D6 for guix-devel@gnu.org; Fri, 02 May 2014 08:56:06 -0400 Received: from na3sys009aog101.obsmtp.com ([74.125.149.67]:57668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgD0T-0005b3-5R for guix-devel@gnu.org; Fri, 02 May 2014 08:56:01 -0400 Received: by mail-pd0-f169.google.com with SMTP id z10so3367379pdj.0 for ; Fri, 02 May 2014 05:55:58 -0700 (PDT) In-Reply-To: <87lhukbqym.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: guix-devel On Fri, May 2, 2014 at 3:05 AM, Ludovic Court=C3=A8s wrote: > "Thompson, David" skribis: > >> On Thu, May 1, 2014 at 12:27 PM, Ludovic Court=C3=A8s wro= te: >>> I noticed that =E2=80=98abbaye=E2=80=99 segfaults for me, immediately a= fter opening its >>> first window (splash screen?). >>> >> >> That crash happens with the old version of the sdl-image package >> because it can't use libpng to open images. Did something go wrong >> where the fixed sdl-image package isn't being used? > > Looking at the strace output, it does seem to relate to libpng: > > --8<---------------cut here---------------start------------->8--- > open("/gnu/store/hf5kklv837xbfcv6gc7gpsj36l69j3sj-glibc-2.19/lib/libpng15= .so.15", O_RDONLY|O_CLOEXEC) =3D -1 ENOENT (No such file or directory) > open("/gnu/store/6z7k9ms4sf367c3phl7djhb740ly3dqi-gcc-4.8.2/lib/libpng15.= so.15", O_RDONLY|O_CLOEXEC) =3D -1 ENOENT (No such file or directory) > open("/gnu/store/hf5kklv837xbfcv6gc7gpsj36l69j3sj-glibc-2.19/lib/libpng15= .so.15", O_RDONLY|O_CLOEXEC) =3D -1 ENOENT (No such file or directory) > close(6) =3D 0 > munmap(0x7f09053e2000, 4096) =3D 0 > --- SIGSEGV {si_signo=3DSIGSEGV, si_code=3DSEGV_MAPERR, si_addr=3D0x8} --= - > --8<---------------cut here---------------end--------------->8--- > > And indeed, =E2=80=98abbaye=E2=80=99 is not explicitly linked against lib= png, so it > can=E2=80=99t find it. > > If I do: > > --8<---------------cut here---------------start------------->8--- > LD_LIBRARY_PATH=3D/gnu/store/naxqxdf7f6lfpy4h481h8j8hs2r44v09-libpng-1.5.= 17/lib /gnu/store/9gfzrsj71ph5pk2hxn7mmpsfflz0jpc7-abbaye-1.13/bin/abbaye > --8<---------------cut here---------------end--------------->8--- > > Then it works like a charm. > > I suppose we need to add -lpng on the link command line? > Thanks for investigating. Abbaye doesn't directly use libpng, SDL_image does, so I think that your copy of Abbaye is not using the latest sdl-image package that propagates libpng (and others). Did you build abbaye yourself or use a substitute from hydra? I noticed that there have been some build failures of SDL libraries to another dependency failing to build. http://hydra.gnu.org/job/gnu/master/sdl-image-1.2.12.x86_64-linux > BTW, the splash screen says =E2=80=9Cfreeware=E2=80=9D; would be great if= we could > change that to =E2=80=9Cfree software=E2=80=9D. > I noticed that and wanted to change it, too. However, it's not as simple as a quick substitute, since it's actually part of an image. Perhaps we could simply use imagemagick to write over the text with the background color. WDYT? > (Seeing this game makes me feel younger. ;-)) > > Thanks, > Ludo=E2=80=99. It's a simple little game with a very old-school feel, but it's fun, very difficult, and the enhanced pixel art graphics are nice. :) - Dave