all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Thompson, David" <dthompson2@worcester.edu>
To: Ben Woodcroft <donttrustben@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 2/2] gnu: Add ruby-puma.
Date: Wed, 8 Jun 2016 09:13:57 -0400	[thread overview]
Message-ID: <CAJ=RwfaZoSZwHNtMyzCbT6Shqj6nLMhyvJu0OciAvn6tVvQKkg@mail.gmail.com> (raw)
In-Reply-To: <1465390550-4974-3-git-send-email-donttrustben@gmail.com>

On Wed, Jun 8, 2016 at 8:55 AM, Ben Woodcroft <donttrustben@gmail.com> wrote:
> gnu/packages/ruby.scm (ruby-puma): New variable.
> gnu/packages/patches/ruby-puma-ignore-broken-test.patch: New file.
> gnu/local.mk (dist_patch_DATA): Add it.
> ---
>  gnu/local.mk                                       |  1 +
>  .../patches/ruby-puma-ignore-broken-test.patch     | 13 +++++++
>  gnu/packages/ruby.scm                              | 41 ++++++++++++++++++++++
>  3 files changed, 55 insertions(+)
>  create mode 100644 gnu/packages/patches/ruby-puma-ignore-broken-test.patch
>
> diff --git a/gnu/local.mk b/gnu/local.mk
> index ff476be..5ff5075 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -733,6 +733,7 @@ dist_patch_DATA =                                           \
>    %D%/packages/patches/rpm-CVE-2014-8118.patch                 \
>    %D%/packages/patches/rsem-makefile.patch                     \
>    %D%/packages/patches/ruby-concurrent-ignore-broken-test.patch        \
> +  %D%/packages/patches/ruby-puma-ignore-broken-test.patch       \
>    %D%/packages/patches/ruby-symlinkfix.patch                    \
>    %D%/packages/patches/ruby-tzinfo-data-ignore-broken-test.patch\
>    %D%/packages/patches/rush-CVE-2013-6889.patch                        \
> diff --git a/gnu/packages/patches/ruby-puma-ignore-broken-test.patch b/gnu/packages/patches/ruby-puma-ignore-broken-test.patch
> new file mode 100644
> index 0000000..fb653dc
> --- /dev/null
> +++ b/gnu/packages/patches/ruby-puma-ignore-broken-test.patch
> @@ -0,0 +1,13 @@
> +diff --git a/test/test_integration.rb b/test/test_integration.rb
> +index d9b189c..6e21180 100644
> +--- a/test/test_integration.rb
> ++++ b/test/test_integration.rb
> +@@ -115,7 +115,7 @@ class TestIntegration < Test::Unit::TestCase
> +     assert_kind_of Thread, t.join(1), "server didn't stop"
> +   end
> +
> +-  def test_phased_restart_via_pumactl
> ++  def no_test_phased_restart_via_pumactl
> +     if Puma.jruby? || Puma.windows?
> +       assert true
> +       return
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index d2b49ba..add5a32 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -3939,6 +3939,47 @@ part of the Prawn PDF generator.")
>      ;; for details."
>      (license (list license:gpl2 license:gpl3 license:ruby))))
>
> +(define-public ruby-puma
> +  (package
> +    (name "ruby-puma")
> +    (version "3.4.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       ;; Fetch from GitHub because distributed gem does not contain tests.
> +       (uri (string-append "https://github.com/puma/puma/archive/v"
> +                           version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "10svyj2jk949y1dmkxyzipk1ddzl4iz9limrcws1zhpganpvq3j8"))
> +       ;; Ignore broken test reported upstream.
> +       ;; https://github.com/puma/puma/issues/995
> +       (patches (search-patches "ruby-puma-ignore-broken-test.patch"))))
> +    (build-system ruby-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'build 'fix-gemspec
> +           (lambda _
> +             (substitute* "puma.gemspec"
> +               (("git ls-files") "find * |sort"))
> +             #t)))))

Food for thought: With the prevalence of "git ls-files" in gemspecs
(thanks to Bundler), maybe we should consider adding a phase to
ruby-build-system that performs this substitution.

> +    (native-inputs
> +     `(("ruby-hoe" ,ruby-hoe)
> +       ("ruby-rake-compiler" ,ruby-rake-compiler)
> +       ("ruby-hoe-git" ,ruby-hoe-git)
> +       ("ruby-rack" ,ruby-rack)))

Why are these native inputs?  rake-compiler makes sense because it's
build-time only, but rack is most definitely a runtime dependency that
should be in propagated-inputs.  What environment have you been using
to test these packages?

> +    (synopsis "Simple, concurrent HTTP server for Ruby/Rack")
> +    (description
> +     "Puma is a simple, fast, threaded, and highly concurrent HTTP 1.1 server
> +for Ruby/Rack applications.  Puma is intended for use in both development and
> +production environments.  In order to get the best throughput, it is highly
> +recommended that you use a Ruby implementation with real threads like Rubinius
> +or JRuby.")
> +    (home-page "http://puma.io")
> +    (license license:expat)))
> +
>  (define-public ruby-hoe-git
>    (package
>      (name "ruby-hoe-git")
> --
> 2.7.4
>
>

  reply	other threads:[~2016-06-08 13:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08 12:55 (unknown), Ben Woodcroft
2016-06-08 12:55 ` [PATCH 1/2] gnu: Add ruby-hoe-git Ben Woodcroft
2016-06-08 13:09   ` Thompson, David
2016-06-08 12:55 ` [PATCH 2/2] gnu: Add ruby-puma Ben Woodcroft
2016-06-08 13:13   ` Thompson, David [this message]
2016-06-10  9:37     ` Ben Woodcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ=RwfaZoSZwHNtMyzCbT6Shqj6nLMhyvJu0OciAvn6tVvQKkg@mail.gmail.com' \
    --to=dthompson2@worcester.edu \
    --cc=donttrustben@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.