From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thompson, David" Subject: Re: [PATCH] services: nginx: Actually check if configuration is valid. Date: Thu, 8 Sep 2016 22:29:05 -0400 Message-ID: References: <1473386715-10297-1-git-send-email-me@tobias.gr> <29fffdf8-d8fa-d579-d15f-6a4cdc6d22f7@tobias.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biBYy-0000jn-Nq for guix-devel@gnu.org; Thu, 08 Sep 2016 22:29:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1biBYw-0001KN-NQ for guix-devel@gnu.org; Thu, 08 Sep 2016 22:29:07 -0400 Received: from mail-ua0-x233.google.com ([2607:f8b0:400c:c08::233]:35763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biBYw-0001KH-Is for guix-devel@gnu.org; Thu, 08 Sep 2016 22:29:06 -0400 Received: by mail-ua0-x233.google.com with SMTP id 95so32669887uaz.2 for ; Thu, 08 Sep 2016 19:29:06 -0700 (PDT) In-Reply-To: <29fffdf8-d8fa-d579-d15f-6a4cdc6d22f7@tobias.gr> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Tobias Geerinckx-Rice Cc: guix-devel On Thu, Sep 8, 2016 at 10:21 PM, Tobias Geerinckx-Rice wrote= : > Dave, > > On 09/09/16 04:09, Thompson, David wrote: >> Maybe this could be done at build-time instead? > > The nginx service points to a stateful configuration file, like > /etc/nginx.conf, that isn't built or handled by Guix. No, it doesn't. I wrote the nginx service. The config file used is part of the g-expression and is absolutely not stateful. > I'd like that to change, but that will have to wait for now. > >> Would be nice to know that when you boot the system the nginx config >> will be valid. > > It's currently printed near the end of =E2=80=98guix system reconfigure= =E2=80=99, if > that's what you mean. I mean that it should throw an error before the system is made active. The derivation that builds the service file should fail. Not suggesting it needs to be done right now, but I think it would be cool. - Dave