From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thompson, David" Subject: Re: [PATCH] Creating a docker image with Guix Date: Thu, 5 Jan 2017 15:09:48 -0500 Message-ID: References: <87eg0l85qm.fsf@gnu.org> <87d1g2h4gq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPEMB-0003io-2K for guix-devel@gnu.org; Thu, 05 Jan 2017 15:09:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cPEMA-0003YN-AR for guix-devel@gnu.org; Thu, 05 Jan 2017 15:09:51 -0500 Received: from mail-vk0-x229.google.com ([2607:f8b0:400c:c05::229]:36069) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cPEMA-0003Y6-4I for guix-devel@gnu.org; Thu, 05 Jan 2017 15:09:50 -0500 Received: by mail-vk0-x229.google.com with SMTP id p9so305158066vkd.3 for ; Thu, 05 Jan 2017 12:09:49 -0800 (PST) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel Hi Ricardo, This is awesome! Just a couple things: 1) The amd64 architecture is hardcoded in the image. Should this instead be set to the current architecture? 2) s/configuratio/configuration/ in the docstring for 'config' in guix/docker.scm Ludovic, Ricardo, anyone else: It might be nice if in the future 'guix environment' had a flag to output the resulting profile instead of having to spawn the sub-shell and refer to $GUIX_ENVIRONMENT. Food for thought. :) LGTM (Let's Get This Merged)! - Dave