all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Thompson, David" <dthompson2@worcester.edu>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Creating a docker image with Guix
Date: Thu, 5 Jan 2017 15:09:48 -0500	[thread overview]
Message-ID: <CAJ=RwfaAcJr5Fvf41HQ=+SuiOe4corC+WSMj_f9AkVr5+9S7jg@mail.gmail.com> (raw)
In-Reply-To: <idjh95dscw7.fsf@bimsb-sys02.mdc-berlin.net>

Hi Ricardo,

This is awesome! Just a couple things:

1) The amd64 architecture is hardcoded in the image.  Should this
instead be set to the current architecture?
2) s/configuratio/configuration/ in the docstring for 'config' in
guix/docker.scm

Ludovic, Ricardo, anyone else: It might be nice if in the future 'guix
environment' had a flag to output the resulting profile instead of
having to spawn the sub-shell and refer to $GUIX_ENVIRONMENT.  Food
for thought. :)

LGTM (Let's Get This Merged)!

- Dave

  reply	other threads:[~2017-01-05 20:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02 12:54 Creating a docker image with Guix Ricardo Wurmus
2017-01-02 13:05 ` David Craven
2017-01-02 14:06 ` Hartmut Goebel
2017-01-02 15:04 ` Pjotr Prins
2017-01-02 15:22   ` Ricardo Wurmus
2017-01-02 15:37 ` John Darrington
2017-01-02 22:19 ` Ludovic Courtès
2017-01-03 10:45   ` Ricardo Wurmus
2017-01-03 15:34   ` [PATCH] " Ricardo Wurmus
2017-01-03 16:24     ` Chris Marusich
2017-01-03 16:45       ` Ricardo Wurmus
2017-01-04 22:12         ` Ludovic Courtès
2017-01-04 21:59     ` Ludovic Courtès
2017-01-05 16:13       ` Ricardo Wurmus
2017-01-05 20:09         ` Thompson, David [this message]
2017-01-05 23:19         ` Ludovic Courtès
2017-01-06 23:58           ` [PATCH] guix archive: '-f docker' supports package names as arguments Ludovic Courtès
2017-01-07  7:07             ` Ricardo Wurmus
2017-01-08 11:00               ` Ludovic Courtès
2017-01-03  2:28 ` Creating a docker image with Guix Christopher Allan Webber
2017-01-03  6:31 ` Jan Nieuwenhuizen
2017-01-03 12:38   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ=RwfaAcJr5Fvf41HQ=+SuiOe4corC+WSMj_f9AkVr5+9S7jg@mail.gmail.com' \
    --to=dthompson2@worcester.edu \
    --cc=guix-devel@gnu.org \
    --cc=ricardo.wurmus@mdc-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.