From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Thompson, David" <dthompson2@worcester.edu>
Subject: Re: [PATCH] build: file-systems: Allow for bind mounting regular
	files.
Date: Sun, 2 Aug 2015 08:51:46 -0400
Message-ID: <CAJ=Rwfa5fZOP2eC-NBv01J_NmbK5UFX7m7F=LK6JdjeL4F4eBA@mail.gmail.com>
References: <87a8uarf6g.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
	<87bnepriup.fsf@gmail.com>
	<CAJ=RwfbgKQ=3yetHsEpGFdSaHhAazYozQ3Mv5fR=VYS0uvObGA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56082)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1ZLsk2-00081G-VF
	for guix-devel@gnu.org; Sun, 02 Aug 2015 08:51:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1ZLsjz-000478-Oh
	for guix-devel@gnu.org; Sun, 02 Aug 2015 08:51:50 -0400
Received: from mail-pa0-f54.google.com ([209.85.220.54]:33366)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1ZLsjz-00046n-Jp
	for guix-devel@gnu.org; Sun, 02 Aug 2015 08:51:47 -0400
Received: by padck2 with SMTP id ck2so69068482pad.0
	for <guix-devel@gnu.org>; Sun, 02 Aug 2015 05:51:46 -0700 (PDT)
In-Reply-To: <CAJ=RwfbgKQ=3yetHsEpGFdSaHhAazYozQ3Mv5fR=VYS0uvObGA@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>

On Sun, Aug 2, 2015 at 8:43 AM, Thompson, David
<dthompson2@worcester.edu> wrote:
> On Sun, Aug 2, 2015 at 8:10 AM, Alex Kost <alezost@gmail.com> wrote:
>> David Thompson (2015-08-01 22:17 +0300) wrote:
>>
>>> diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm
>>> index c58d23c..f0d6f70 100644
>>> --- a/gnu/build/file-systems.scm
>>> +++ b/gnu/build/file-systems.scm
>>> @@ -305,6 +305,10 @@ the following:
>>>                 fsck code device)
>>>         (start-repl)))))
>>>
>>> +(define (regular-file? file-name)
>>> +  "Return #t if FILE-NAME is a regular file."
>>> +  (eq? (stat:type (stat file-name)) 'regular))
>>
>> There are similar procedures in (guix build utils): 'directory-exists?',
>> 'executable-file?' and 'symbolic-link?'.  So I think it is better to put
>> 'regular-file?' there.  WDYT?
>
> Sure, that makes sense.  Done.

Ah, of course, I forgot about something:  This patch triggers a
rebuild of *everything* now!  I guess it should be applied to
core-updates.  Or, the first patch I submitted can be applied to
master, and then a patch that moves 'regular-file?' to (guix build
utils) can be applied to core-updates later.

Thoughts?

- Dave