From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WDzqIbOnFGMjGAEAbAwnHQ (envelope-from ) for ; Sun, 04 Sep 2022 15:27:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 8OYHIbOnFGNOoAAAG6o9tA (envelope-from ) for ; Sun, 04 Sep 2022 15:27:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5885F24E8B for ; Sun, 4 Sep 2022 15:27:15 +0200 (CEST) Received: from localhost ([::1]:44930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oUpec-00030G-5x for larch@yhetil.org; Sun, 04 Sep 2022 09:27:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oUpeR-0002ym-JZ for bug-guix@gnu.org; Sun, 04 Sep 2022 09:27:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54993) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oUpeR-0005Bv-B2 for bug-guix@gnu.org; Sun, 04 Sep 2022 09:27:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oUpeR-0000dR-78 for bug-guix@gnu.org; Sun, 04 Sep 2022 09:27:03 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks Resent-From: "Thompson, David" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 04 Sep 2022 13:27:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25957 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Efraim Flashner , "Thompson, David" , zimoun , 25957@debbugs.gnu.org Received: via spool by 25957-submit@debbugs.gnu.org id=B25957.16622980072409 (code B ref 25957); Sun, 04 Sep 2022 13:27:03 +0000 Received: (at 25957) by debbugs.gnu.org; 4 Sep 2022 13:26:47 +0000 Received: from localhost ([127.0.0.1]:43690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUpeB-0000cl-4T for submit@debbugs.gnu.org; Sun, 04 Sep 2022 09:26:47 -0400 Received: from mail-lf1-f52.google.com ([209.85.167.52]:41904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUpe9-0000cX-Hl for 25957@debbugs.gnu.org; Sun, 04 Sep 2022 09:26:46 -0400 Received: by mail-lf1-f52.google.com with SMTP id m7so9730496lfq.8 for <25957@debbugs.gnu.org>; Sun, 04 Sep 2022 06:26:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=Js66OQAbzo50O0oqOz1KSTAYCigCZQkokfhnuzykUWA=; b=kDFSgAivfkNE+n4/pnwaEv9JTNdff3G0UHI3vE3dxOQCtuamqtpL4Xv+zI/5BktdSp cG1Kl2KU72gCFR0Qpy4abBZ9vva+q2DOb2jY2fFPjOqWnlLPDDIOXbfX3VAQUgLicAzD BW8I+NiHlcC7NU7WheHT2SHIV5XO/XxCwO9ht94cvIUi/FiyJVjJuJ03NCWjLo8Er0u2 YyVPZ8/wm0N2uq1XegGIMuQ4U4oWWQScpJrmLGmFPo/Bou4x+5mKf6oedpyzzjQM7VTP fs+JQ8G0kQ8YsO0olKL0JrLFGp8GadLWyac7WJGjjpcmJp5Ui4N+q0ugjn10CbXMF1AK JVhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=Js66OQAbzo50O0oqOz1KSTAYCigCZQkokfhnuzykUWA=; b=Y8d/kWGbDV4BP8or3dzSP8u3w8V86h3RHDiE0ukt1ewBE8pJdTOhHMaElrUTwTdQqK o/PFug40oh8AM82rQFEKIz4bvz+FlHYdQM5gHCoxZaJL5e5q0H1luHfUE/682g6+CJXu VRPAT20JNByRkvU5SsudKinG+5CR6pJtcvY+Y0x16SBi6KTcdanaR1Dj6CNIoxs2dznG rEldU3KunCFLCfwtKwDLF4m4vEx/sZo0nVgR20mOa1kig+lv6YvDq8qRmLih+1SQHmRq GcTFop7mAJ2X4zh6JG+agKZN7jtOgAqOXpmJmVB+ItDsjxbfsvLvM546GsAMx4UNxMYT lV7g== X-Gm-Message-State: ACgBeo1UZR7O7z1uD5n/GxLYBUbbw6UaTw+VsSrR1tm4Rdwk36XwbMFr zflB2VKeli5lDGlo7pCLnAbG6pAjjYS1EMrj9vXoMg== X-Google-Smtp-Source: AA6agR6jLrqaW7iVFl8tDCghuju5xCL6MM7Od1oK05j8PRTPb82HDlEx3VDzIH98upnMZ8bkY7gEr1cqoOZWP5HMz98= X-Received: by 2002:a05:6512:b24:b0:494:70c4:c2a1 with SMTP id w36-20020a0565120b2400b0049470c4c2a1mr10268053lfu.79.1662297999461; Sun, 04 Sep 2022 06:26:39 -0700 (PDT) MIME-Version: 1.0 References: <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> In-Reply-To: From: "Thompson, David" Date: Sun, 4 Sep 2022 09:26:28 -0400 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662298035; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Js66OQAbzo50O0oqOz1KSTAYCigCZQkokfhnuzykUWA=; b=NZj60rgov3QICuSkkthmRmYAKlhZ1F4PWTU4QJmlna7lESn+ujjj8VSltCo78+rVN+B6sk KW5ydEeWWB8wpFtxwgInCUErYnhrfF6P7nFgcjRBw+H9K02dIIVIkI/xFe5bQNLo67x96u 2GvreStQCshBx8a8VABRPttpgsjxSGKc0E9hzthPS13gMm3yKevhGuuukFTOeFDnzXAaV5 ay0E+OdZ/KCQoK8HMW8dM2jCHg5ukBYG5Z8ZepGxhX6pOIQa5J6LyFV+URhcuoKwIHa9jq Q1IAG1mjuyoldjX8/IMcCTpumgVjYjb8sT99SmC1vBk6wYxlcSAz/i6x4N5gvg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1662298035; a=rsa-sha256; cv=none; b=fZO4h88d3kop2EX9otfZeZ1xNDJpHuUJVLnRSurZEvryfWIxCWgF4W4MUuIaLXmMnQyJbf 2vc6bAi0T8Z4Vlnor57sSqiZVhoFki+EvhGdMpYQhTd0DOip/Hfgpqq4xn2hVTFs83yYYw CDf0XuWcWO8xCNMMXiKte9mcP8iGmcj8LgtOLqB3OY08ecqoMkq8J1HR6pePCWB8Wzypz5 GVNIMmDwVOUEinilWJ/r1Jfs+KRi5HEDlex3ViWma2cBTe31J61yy3APZmEmRi3cfG3pq0 k0eyFZyq4G/gAnfOrwGDpebg30KCONvywZp+eyrAR2WqBAjfruswfefMPJ0jLQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=worcester-edu.20210112.gappssmtp.com header.s=20210112 header.b=kDFSgAiv; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.72 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=worcester-edu.20210112.gappssmtp.com header.s=20210112 header.b=kDFSgAiv; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5885F24E8B X-Spam-Score: 2.72 X-Migadu-Scanner: scn1.migadu.com X-TUID: XIlgq7ibVGwW Hi Efraim, On Sun, Sep 4, 2022 at 3:26 AM Efraim Flashner wrote: > > Overall it looks good to me. I was going to ask about inetutils and > openssh since they're not wrapping the binaries but I see their paths > are substituted in the 'patch-source phase. > > LGTM! Thanks! I made one minor tweak to sort the inputs list alphabetically and pushed as commit 1aa46a7e29c5bd892219fe20fefb883d2103e29e. I also pushed a follow-up commit e4ccfcb22ad96e71ca4dfad95af5aa6229ed9869 that swaps out 'git' for 'git-minimal', saving about 75MiB in the package closure. I think, technically speaking, this bug has been resolved. There are no longer /usr/bin, /usr/sbin, etc. references in our gitolite package, so extensions should work as long as the user adds the relevant packages to their user or system profile. I will keep this bug open for the moment, though, since I haven't gotten to the final patch I said I would submit which will make those optional dependencies easy to add via the gitolite service. Stay tuned! - Dave