From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thompson, David" Subject: Re: Add guile-minikanren Date: Thu, 23 Apr 2015 09:46:19 -0400 Message-ID: References: <87wq14dwd9.fsf@earlgrey.lan> <20150423131751.GA12941@debian.math.u-bordeaux1.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlHSW-0001ly-5c for guix-devel@gnu.org; Thu, 23 Apr 2015 09:46:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlHSQ-0001jQ-G1 for guix-devel@gnu.org; Thu, 23 Apr 2015 09:46:28 -0400 Received: from na3sys009aog114.obsmtp.com ([74.125.149.211]:42332 helo=mail-pa0-f53.google.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlHSQ-0001jI-9R for guix-devel@gnu.org; Thu, 23 Apr 2015 09:46:22 -0400 Received: by pabsx10 with SMTP id sx10so18613292pab.3 for ; Thu, 23 Apr 2015 06:46:20 -0700 (PDT) In-Reply-To: <20150423131751.GA12941@debian.math.u-bordeaux1.fr> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel On Thu, Apr 23, 2015 at 9:17 AM, Andreas Enge wrote: > On Wed, Apr 22, 2015 at 10:15:27AM -0500, Christopher Allan Webber wrote: > >> I named it guile-minikanren which isn't really accurate. I'm not sure >> how else I could name it though? I'd be open to suggestions! > > There is a chapter in the documentation about this: > https://www.gnu.org/software/guix/manual/guix.html#Package-Naming > The main idea is to not think too much, but to simply use the upstream > project name. Here this seems to be "minikanren" without "guile-". > We have special rules for perl and python; maybe we also need a special > rule for guile? The prefix "guile-" is important here because the build system installs the Scheme modules into a directory that is specifically for Guile, not other R6RS compliant Scheme implementations. > >> + (source (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/ijp/minikanren.git") >> + (commit "10d507785eab30b0f8b47bf8bb37d880731fc031"))) > > Is there no tarball? If possiblem we would prefer this. No tarball. I would recommend that the first 7 characters of the commit SHA be used as the package version, and this string here could just be replaced with 'version'. >> + (native-inputs `(("guile" ,guile-2.0))) > > "native-inputs" are used during the build of the package, which is not > the case here. Is guile needed at all as an input? It will be needed. The build system should compile the Scheme files, but it doesn't. As a final note, I would like to add that the 'license' field can be simply 'expat', instead of using the 'non-copyleft' procedure. Thanks for working on this, Chris! - Dave