From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Thompson, David" <dthompson2@worcester.edu>
Subject: Re: [PATCH 2/5] gnu: Add avr-gcc.
Date: Thu, 14 Apr 2016 09:55:27 -0400
Message-ID: <CAJ=RwfZm35wmHbU-bCsGs358WgFhus3z_RGnjdfoUimCSqmXWg@mail.gmail.com>
References: <1460639824-9976-1-git-send-email-dthompson2@worcester.edu>
	<1460639824-9976-3-git-send-email-dthompson2@worcester.edu>
	<570FA0F7.4060909@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57071)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1aqhk1-0003IL-AD
	for guix-devel@gnu.org; Thu, 14 Apr 2016 09:55:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1aqhk0-0005oy-EY
	for guix-devel@gnu.org; Thu, 14 Apr 2016 09:55:29 -0400
Received: from mail-yw0-x231.google.com ([2607:f8b0:4002:c05::231]:34894)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dthompson2@worcester.edu>) id 1aqhk0-0005ou-66
	for guix-devel@gnu.org; Thu, 14 Apr 2016 09:55:28 -0400
Received: by mail-yw0-x231.google.com with SMTP id i84so104134215ywc.2
	for <guix-devel@gnu.org>; Thu, 14 Apr 2016 06:55:28 -0700 (PDT)
In-Reply-To: <570FA0F7.4060909@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>

On Thu, Apr 14, 2016 at 9:53 AM, Manolis Ragkousis <manolis837@gmail.com> wrote:
> Hey David,
>
> On 04/14/16 16:17, David Thompson wrote:
>> +       (substitute-keyword-arguments (package-arguments xgcc)
>> +         ((#:phases phases)
>> +          `(modify-phases ,phases
>> +             ;; Without a working multilib build, the resulting GCC lacks
>> +             ;; support for nearly every AVR chip.
>> +             (add-after 'unpack 'fix-genmultilib
>> +               (lambda _
>> +                 (substitute* "gcc/genmultilib"
>> +                   (("#!/bin/sh") (string-append "#!" (which "sh"))))
>> +                 #t))))
>
> I think we should add fix-genmultilib to one of the existing standard
> phases because this problem appears to Ricardo's arm-none-eabi
> cross-toolchain as well. All the cross-toolchains will benefit from this.

I think that would be a good next step, after this patch set is merged.

- Dave