From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thompson, David" Subject: Re: [PATCH] Add and use sqlite-legacy-for-python Date: Fri, 12 Feb 2016 19:23:34 -0500 Message-ID: References: <20160208164641.GA28440@thebird.nl> <87ziv9poua.fsf@gnu.org> <87h9hd8o2k.fsf@dustycloud.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUNzr-0006jI-RG for guix-devel@gnu.org; Fri, 12 Feb 2016 19:23:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUNzq-00089T-Ra for guix-devel@gnu.org; Fri, 12 Feb 2016 19:23:35 -0500 Received: from mail-yw0-x22e.google.com ([2607:f8b0:4002:c05::22e]:34206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUNzq-00089E-MY for guix-devel@gnu.org; Fri, 12 Feb 2016 19:23:34 -0500 Received: by mail-yw0-x22e.google.com with SMTP id h129so77846468ywb.1 for ; Fri, 12 Feb 2016 16:23:34 -0800 (PST) In-Reply-To: <87h9hd8o2k.fsf@dustycloud.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Christopher Allan Webber Cc: guix-devel On Fri, Feb 12, 2016 at 7:13 PM, Christopher Allan Webber wrote: > Ludovic Court=C3=A8s writes: > >> Pjotr Prins skribis: >> >>> Patch b24765139c8940541b23f84592d3580d53f71d71 >>> >>> (define-public sqlite >>> (package >>> (name "sqlite") >>> - (version "3.8.11.1") >>> + (version "3.10.0") >>> (source (origin >>> >>> is the cause of python(2|3)-sqlalchemy breaking. I confirmed that by >>> regressing to the original sqlite package. Since the python binding is >>> part of the interpreter, I suspect there may be more python modules >>> vulnerable. I updated python-sqlalchemy to latest and that makes no >>> difference. Its tests fail on sqlite 3.10.0 and pass on 3.8.11.1. >>> >>> What do we do? Revert on this sqlite patch for the new guix release? >>> Or add a second sqlite package and have that as a python dependency? >> >> I would do the latter, assuming that soon a new python-sqlalchemy >> release would solve the problem. WDYT? >> >> This is probably OK since python-sqlalchemy is a leaf, and so we=E2=80= =99re >> unlikely to end up mixing two different SQLite versions. >> >> Ludo=E2=80=99. > > Will sqlalchemy really remain a leaf node? I hope not, since I'm > working on packaging MediaGoblin now :) Yeah, sqlalchemy being a leaf node is accidental. It's a library that will be depended on by MediaGoblin and maybe other software. > Regardless, I agree that the second approach seems to be the right one. > I've built a modified package, sqlite-legacy-for-python, and put it to > use. I built it and confirmed it builds fine and that the tests pass, > and with it, the tests pass in python-sqlalchemy too. I'm concerned about this. What exactly is being used here, a client library? If so, it means that we may have an issue when a python application uses a library that wants to dynamically link against both the normal sqlite library and this older version. Maybe this is still fine, but proceed with caution. - Dave