From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thompson, David" Subject: Re: [PATCH 02/11] gnu: Add oslotest. Date: Wed, 22 Jul 2015 22:06:44 -0400 Message-ID: References: <1437003151-23838-1-git-send-email-tipecaml@gmail.com> <1437003151-23838-3-git-send-email-tipecaml@gmail.com> <55B01582.5050609@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40394) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZI5uL-0007ZL-26 for guix-devel@gnu.org; Wed, 22 Jul 2015 22:06:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZI5uH-0003Ag-HG for guix-devel@gnu.org; Wed, 22 Jul 2015 22:06:49 -0400 Received: from mail-pd0-f177.google.com ([209.85.192.177]:33011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZI5uH-0003AP-CL for guix-devel@gnu.org; Wed, 22 Jul 2015 22:06:45 -0400 Received: by pdbnt7 with SMTP id nt7so77031793pdb.0 for ; Wed, 22 Jul 2015 19:06:44 -0700 (PDT) In-Reply-To: <55B01582.5050609@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Cyril Roelandt Cc: guix-devel On Wed, Jul 22, 2015 at 6:13 PM, Cyril Roelandt wrote: > On 07/20/2015 06:14 PM, Thompson, David wrote: >> On Wed, Jul 15, 2015 at 7:32 PM, Cyril Roelandt wrote: >>> * gnu/packages/openstack.scm: New file. >>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it here. >>> * gnu/packages/python.scm (python-appdirs, python2-appdirs): New variables. >> >> Could you break this patch so that there is one package per patch? > > Hum, I'm not sure whether that really makes sense. The main "feature" I > want to add is the package for oslotest, so it seemed natural to add its > dependencies in the same patch, especially since there is only one. The commit log doesn't show this, though. According to your log, 2 new variables were added, but it turns out there were more upon closer inspection. We view each additional package as a logical change that should be in its own commit. And just to prevent any further confusion, the 'python2' variant of a package can be included in the patch for the python3 version. > Plus, this would make this patch series *huge*. Do we really want that? I'd rather not hide that fact by stuffing more packages into a patch than there ought to be. >> Also, all of the Python packages in openstack.scm look like they >> really belong in python.scm. Could you move them? >> > > Well, in the end, we could have everything from PyPI in python.scm. > OpenStack is a huge project, so I thought it would make sense to have > its packages in their own file. WDYT? If they are solely for OpenStack then that's fine. Thanks, - Dave