all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [PATCH] gnu: guile-next: Set correct native search paths.
@ 2016-02-13  5:13 Thompson, David
  2016-02-13  7:25 ` Jan Nieuwenhuizen
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Thompson, David @ 2016-02-13  5:13 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 143 bytes --]

I've started building my own projects with Guile 2.1.2 and I noticed
that the search paths needed adjustment in order to find modules.

- Dave

[-- Attachment #2: 0001-gnu-guile-next-Set-correct-native-search-paths.patch --]
[-- Type: text/x-diff, Size: 1380 bytes --]

From 7b26acb50b60a68b1c64ff38a663212e03b0bb7d Mon Sep 17 00:00:00 2001
From: David Thompson <dthompson2@worcester.edu>
Date: Sat, 13 Feb 2016 00:08:22 -0500
Subject: [PATCH] gnu: guile-next: Set correct native search paths.

* gnu/packages/guile.scm (guile-next): Use the "2.2" directory for the
  load paths.
---
 gnu/packages/guile.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
index e6e7228..11d9da1 100644
--- a/gnu/packages/guile.scm
+++ b/gnu/packages/guile.scm
@@ -210,7 +210,15 @@ without requiring the source code to be rewritten.")
               ;; times (almost 3 hours on a 4-core Intel i5).
               (snippet '(for-each delete-file
                                   (find-files "prebuilt" "\\.go$")))))
-    (synopsis "Snapshot of what will become version 2.2 of GNU Guile")))
+    (synopsis "Snapshot of what will become version 2.2 of GNU Guile")
+    (native-search-paths
+     (list (search-path-specification
+            (variable "GUILE_LOAD_PATH")
+            (files '("share/guile/site/2.2")))
+           (search-path-specification
+            (variable "GUILE_LOAD_COMPILED_PATH")
+            (files '("lib/guile/2.0/ccache"
+                     "share/guile/site/2.2")))))))
 
 (define-public guile-for-guile-emacs
   (package (inherit guile-next)
-- 
2.5.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: guile-next: Set correct native search paths.
  2016-02-13  5:13 [PATCH] gnu: guile-next: Set correct native search paths Thompson, David
@ 2016-02-13  7:25 ` Jan Nieuwenhuizen
  2016-02-15  8:47 ` Andy Wingo
  2016-02-24  0:42 ` Thompson, David
  2 siblings, 0 replies; 6+ messages in thread
From: Jan Nieuwenhuizen @ 2016-02-13  7:25 UTC (permalink / raw)
  To: Thompson, David; +Cc: guix-devel

Thompson, David writes:

> I've started building my own projects with Guile 2.1.2 and I noticed
> that the search paths needed adjustment in order to find modules.

Ah...great I've been wondering about this; assuming everyone would
be running latest guile.

Do we want a guile-next-lib, I am using this

(define-public guile-next-lib
  (package (inherit guile-lib)
    (name "guile-lib-next")
    (version "0.2.2")
    (inputs `(("guile" ,guile-next)))
    (arguments
     (append (substitute-keyword-arguments
              `(#:tests? #f ;; 2 tests still fail
                ,@(package-arguments guile-lib)))))))


Greetings,
Jan

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar®  http://AvatarAcademy.nl  

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: guile-next: Set correct native search paths.
  2016-02-13  5:13 [PATCH] gnu: guile-next: Set correct native search paths Thompson, David
  2016-02-13  7:25 ` Jan Nieuwenhuizen
@ 2016-02-15  8:47 ` Andy Wingo
  2016-02-15 13:04   ` Thompson, David
  2016-02-21 23:11   ` Jan Nieuwenhuizen
  2016-02-24  0:42 ` Thompson, David
  2 siblings, 2 replies; 6+ messages in thread
From: Andy Wingo @ 2016-02-15  8:47 UTC (permalink / raw)
  To: Thompson, David; +Cc: guix-devel

On Sat 13 Feb 2016 06:13, "Thompson, David" <dthompson2@worcester.edu> writes:

> diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
> index e6e7228..11d9da1 100644
> --- a/gnu/packages/guile.scm
> +++ b/gnu/packages/guile.scm
> @@ -210,7 +210,15 @@ without requiring the source code to be rewritten.")
>                ;; times (almost 3 hours on a 4-core Intel i5).
>                (snippet '(for-each delete-file
>                                    (find-files "prebuilt" "\\.go$")))))
> -    (synopsis "Snapshot of what will become version 2.2 of GNU Guile")))
> +    (synopsis "Snapshot of what will become version 2.2 of GNU Guile")
> +    (native-search-paths
> +     (list (search-path-specification
> +            (variable "GUILE_LOAD_PATH")
> +            (files '("share/guile/site/2.2")))
> +           (search-path-specification
> +            (variable "GUILE_LOAD_COMPILED_PATH")
> +            (files '("lib/guile/2.0/ccache"
> +                     "share/guile/site/2.2")))))))
>  
>  (define-public guile-for-guile-emacs
>    (package (inherit guile-next)

This doesn't look right to me; why is GUILE_LOAD_COMPILED_PATH pointing
into share?  Probably need to update the pointer into lib to use 2.2,
also.

Andy

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: guile-next: Set correct native search paths.
  2016-02-15  8:47 ` Andy Wingo
@ 2016-02-15 13:04   ` Thompson, David
  2016-02-21 23:11   ` Jan Nieuwenhuizen
  1 sibling, 0 replies; 6+ messages in thread
From: Thompson, David @ 2016-02-15 13:04 UTC (permalink / raw)
  To: Andy Wingo; +Cc: guix-devel

On Mon, Feb 15, 2016 at 3:47 AM, Andy Wingo <wingo@igalia.com> wrote:
> On Sat 13 Feb 2016 06:13, "Thompson, David" <dthompson2@worcester.edu> writes:
>
>> diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
>> index e6e7228..11d9da1 100644
>> --- a/gnu/packages/guile.scm
>> +++ b/gnu/packages/guile.scm
>> @@ -210,7 +210,15 @@ without requiring the source code to be rewritten.")
>>                ;; times (almost 3 hours on a 4-core Intel i5).
>>                (snippet '(for-each delete-file
>>                                    (find-files "prebuilt" "\\.go$")))))
>> -    (synopsis "Snapshot of what will become version 2.2 of GNU Guile")))
>> +    (synopsis "Snapshot of what will become version 2.2 of GNU Guile")
>> +    (native-search-paths
>> +     (list (search-path-specification
>> +            (variable "GUILE_LOAD_PATH")
>> +            (files '("share/guile/site/2.2")))
>> +           (search-path-specification
>> +            (variable "GUILE_LOAD_COMPILED_PATH")
>> +            (files '("lib/guile/2.0/ccache"
>> +                     "share/guile/site/2.2")))))))
>>
>>  (define-public guile-for-guile-emacs
>>    (package (inherit guile-next)
>
> This doesn't look right to me; why is GUILE_LOAD_COMPILED_PATH pointing
> into share?

Because this is what our Guile package already did.  I just changed
"2.0" to "2.2".

> Probably need to update the pointer into lib to use 2.2, also.

Yeah, that was a typo I've since fixed locally.

- Dave

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: guile-next: Set correct native search paths.
  2016-02-15  8:47 ` Andy Wingo
  2016-02-15 13:04   ` Thompson, David
@ 2016-02-21 23:11   ` Jan Nieuwenhuizen
  1 sibling, 0 replies; 6+ messages in thread
From: Jan Nieuwenhuizen @ 2016-02-21 23:11 UTC (permalink / raw)
  To: Andy Wingo; +Cc: guix-devel

Andy Wingo writes:

>> +    (native-search-paths
>> +     (list (search-path-specification
>> +            (variable "GUILE_LOAD_PATH")
>> +            (files '("share/guile/site/2.2")))
>> +           (search-path-specification
>> +            (variable "GUILE_LOAD_COMPILED_PATH")
>> +            (files '("lib/guile/2.0/ccache"
>> +                     "share/guile/site/2.2")))))))
>>  
>>  (define-public guile-for-guile-emacs
>>    (package (inherit guile-next)
>
> This doesn't look right to me; why is GUILE_LOAD_COMPILED_PATH pointing
> into share?  Probably need to update the pointer into lib to use 2.2,
> also.

I'm wondering... Currently when switching environments from guile to
guile-next and back, I found that I need to unset
GUILE_LOAD_COMPILED_PATH; otherwise it gets appended to and that breaks.

Why is the `2.0' and `2.2' part of the GUILE_LOAD_COMPILED_PATH?  If
guile would always append that (or also look in the directory with
MAJOR.MINOR appended), i.e. something like

     lib/guile/ccache       # GUILE_LOAD_COMPILED_PATH
     lib/guile/ccache/2.0   # guile-2.0 appends 2.0
     lib/guile/ccache/2.2   # guile-2.2 appends 2.2       

wouldn't that help a lot with picking up the right .go files when
running different versions of guile?

Greetings, Jan

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar®  http://AvatarAcademy.nl  

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] gnu: guile-next: Set correct native search paths.
  2016-02-13  5:13 [PATCH] gnu: guile-next: Set correct native search paths Thompson, David
  2016-02-13  7:25 ` Jan Nieuwenhuizen
  2016-02-15  8:47 ` Andy Wingo
@ 2016-02-24  0:42 ` Thompson, David
  2 siblings, 0 replies; 6+ messages in thread
From: Thompson, David @ 2016-02-24  0:42 UTC (permalink / raw)
  To: guix-devel

On Sat, Feb 13, 2016 at 12:13 AM, Thompson, David
<dthompson2@worcester.edu> wrote:
> I've started building my own projects with Guile 2.1.2 and I noticed
> that the search paths needed adjustment in order to find modules.

I fixed the one place where I forgot to s/2.0/2.2/ and pushed.

- Dave

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-02-24  0:43 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-13  5:13 [PATCH] gnu: guile-next: Set correct native search paths Thompson, David
2016-02-13  7:25 ` Jan Nieuwenhuizen
2016-02-15  8:47 ` Andy Wingo
2016-02-15 13:04   ` Thompson, David
2016-02-21 23:11   ` Jan Nieuwenhuizen
2016-02-24  0:42 ` Thompson, David

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.