From: "Thompson, David" <dthompson2@worcester.edu>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: [PATCH] Add aragorn.
Date: Tue, 21 Jul 2015 10:01:49 -0400 [thread overview]
Message-ID: <CAJ=RwfZYFFv7W2LmafhmrF2=maBBSML_m6172S8qOEcP1LEfDg@mail.gmail.com> (raw)
In-Reply-To: <idjfv4h395r.fsf@bimsb-sys02.mdc-berlin.net>
On Tue, Jul 21, 2015 at 9:57 AM, Ricardo Wurmus
<ricardo.wurmus@mdc-berlin.de> wrote:
> Something’s wrong with the alignment of the ‘(replace 'install ...)’.
> If there are no objections I can fix the alignment and push without
> requesting another version of the patch.
>
> But I think I better wait for other comments.
Looks fine to me, sans the alignment. One additional nitpick is the
'string-append' calls. The newlines should happen *after* the first
argument, not before.
- Dave
next prev parent reply other threads:[~2015-07-21 14:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 13:14 [PATCH] Add aragorn Ben Woodcroft
2015-07-21 13:40 ` Ricardo Wurmus
2015-07-21 13:55 ` Ben Woodcroft
2015-07-21 13:57 ` Ricardo Wurmus
2015-07-21 14:01 ` Thompson, David [this message]
2015-07-21 14:42 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ=RwfZYFFv7W2LmafhmrF2=maBBSML_m6172S8qOEcP1LEfDg@mail.gmail.com' \
--to=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.