From: "Thompson, David" <dthompson2@worcester.edu>
To: Pjotr Prins <pjotr.public12@thebird.nl>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add ruby-gherkin3
Date: Tue, 15 Sep 2015 10:55:19 -0400 [thread overview]
Message-ID: <CAJ=RwfZUgSK-uLAmKJwCweaSBsQXuU93CgOexT=CtwJW0-RZ6g@mail.gmail.com> (raw)
In-Reply-To: <55f82fc3.O6mBJ915uAoK5FcU%pjotr.public12@thebird.nl>
On Tue, Sep 15, 2015 at 10:48 AM, <pjotr.public12@thebird.nl> wrote:
> * gnu/packages/ruby.scm (ruby-gherkin3): New variable.
Looks good to me. Just minor comments below.
> ---
> gnu/packages/ruby.scm | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index ee0acc8..4756cd4 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -1124,3 +1124,28 @@ it unifies the API for web servers, web frameworks, and software in between
> into a single method call.")
> (home-page "http://rack.github.io/")
> (license license:expat)))
> +
> +(define-public ruby-gherkin3
> + (package
> + (name "ruby-gherkin3")
> + (version "3.1.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (rubygems-uri "gherkin3" version))
> + (sha256
> + (base32
> + "0xsyxhqa1gwcxzvsdy4didaiq5vam8ma3fbwbw2w60via4k6r1z9"))))
> + (build-system ruby-build-system)
> + (native-inputs
> + `(("bundler" ,bundler)
> + ("ruby-rspec" ,ruby-rspec)))
Let's remove rspec since we aren't running tests
> + (arguments
> + '(#:tests? #f)) ; needs simplecov, among others
> + (synopsis "Gherkin parser")
Maybe "Gherkin parser for Ruby"
> + (description "Gherkin 3 is a parser and compiler for the Gherkin
> +language. It is intended to replace Gherkin 2 and be used by all
> +Cucumber implementations to parse .feature files.")
> + (home-page
> + "https://github.com/cucumber/gherkin3")
Move to same line as 'home-page'.
> + (license expat)))
Needs prefix: license:expat
> --
> 2.4.3
>
>
- Dave
next prev parent reply other threads:[~2015-09-15 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 14:48 [PATCH] gnu: Add ruby-gherkin3 pjotr.public12
2015-09-15 14:55 ` Thompson, David [this message]
2015-09-15 18:37 ` Thompson, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ=RwfZUgSK-uLAmKJwCweaSBsQXuU93CgOexT=CtwJW0-RZ6g@mail.gmail.com' \
--to=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
--cc=pjotr.public12@thebird.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.