From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thompson, David" Subject: Re: [PATCH] tests: Skip 'guix environment --container' tests in some cases. Date: Wed, 4 Nov 2015 09:05:17 -0500 Message-ID: References: <87h9l24fyn.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> <87twp29lsj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=94eb2c093a320a98fb0523b7806c Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56391) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ztygk-0008FA-Jb for guix-devel@gnu.org; Wed, 04 Nov 2015 09:05:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ztygg-000757-GK for guix-devel@gnu.org; Wed, 04 Nov 2015 09:05:22 -0500 Received: from mail-yk0-x229.google.com ([2607:f8b0:4002:c07::229]:32981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ztygg-00074x-CT for guix-devel@gnu.org; Wed, 04 Nov 2015 09:05:18 -0500 Received: by ykft191 with SMTP id t191so72966610ykf.0 for ; Wed, 04 Nov 2015 06:05:17 -0800 (PST) In-Reply-To: <87twp29lsj.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: guix-devel --94eb2c093a320a98fb0523b7806c Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, Nov 4, 2015 at 4:05 AM, Ludovic Court=C3=A8s wrote: > David Thompson skribis: > >> Took a stab at fixing the guix-environment-container.sh tests when the >> necessary features aren't available. GuixSD systems don't have >> /proc/sys/kernel/unprivileged_userns_clone so I couldn't verify that >> code path works as intended. All I can say is that the tests still pass >> on my machine as they did before. >> >> WDYT? Did I make it in time for the release? > > Sounds good in principle, but you forgot to attach the patch. :-) Ugh. Then I also forgot to reply-all and sent the patch to you only. Double ugh. Sorry about this. - Dave --94eb2c093a320a98fb0523b7806c Content-Type: text/x-diff; charset=US-ASCII; name="0001-tests-Skip-guix-environment-container-tests-in-some-.patch" Content-Disposition: attachment; filename="0001-tests-Skip-guix-environment-container-tests-in-some-.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_igkvmj8x0 RnJvbSBhMmI2ZTUwM2M1M2VkNmY0ZTIwNDc0ZTc4ZjE3ZmFjMjA4ZjQ2MjdlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBUaG9tcHNvbiA8ZHRob21wc29uMkB3b3JjZXN0ZXIu ZWR1PgpEYXRlOiBUdWUsIDMgTm92IDIwMTUgMjI6MDU6MjYgLTA1MDAKU3ViamVjdDogW1BBVENI XSB0ZXN0czogU2tpcCAnZ3VpeCBlbnZpcm9ubWVudCAtLWNvbnRhaW5lcicgdGVzdHMgaW4gc29t ZQogY2FzZXMuCgpUaGUgdGVzdHMgaW4gdGVzdHMvZ3VpeC1lbnZpcm9ubWVudC1jb250YWluZXIu c2ggY2Fubm90IGJlIHBlcmZvcm1lZAp1bmxlc3MgdGhlIHN5c3RlbSBzdXBwb3J0cyB1c2VyIG5h bWVzcGFjZXMuCgoqIHRlc3RzL2d1aXgtZW52aXJvbm1lbnQtY29udGFpbmVyLnNoOiBTa2lwIGlm IGZlYXR1cmUgdGVzdHMgZmFpbC4KLS0tCiB0ZXN0cy9ndWl4LWVudmlyb25tZW50LWNvbnRhaW5l ci5zaCB8IDE5ICsrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAxOSBpbnNlcnRp b25zKCspCgpkaWZmIC0tZ2l0IGEvdGVzdHMvZ3VpeC1lbnZpcm9ubWVudC1jb250YWluZXIuc2gg Yi90ZXN0cy9ndWl4LWVudmlyb25tZW50LWNvbnRhaW5lci5zaAppbmRleCAxNDFmZDE2Li45ZTc1 YWM1IDEwMDY0NAotLS0gYS90ZXN0cy9ndWl4LWVudmlyb25tZW50LWNvbnRhaW5lci5zaAorKysg Yi90ZXN0cy9ndWl4LWVudmlyb25tZW50LWNvbnRhaW5lci5zaApAQCAtMjIsNiArMjIsMjUgQEAK IAogc2V0IC1lCiAKKyMgUGVyZm9ybSBzb21lIGZlYXR1cmUgdGVzdHMgdG8gZGV0ZXJtaW5lIGlm IHRoZSB0ZXN0cyBhcmUgYXBwbGljYWJsZS4KK2lmIHRlc3QgLWYgL3Byb2Mvc2VsZi9ucy91c2Vy IC1hIFwKKyAgICAgICAgLWYgL3Byb2Mvc2VsZi9zZXRncm91cHMKK3RoZW4KKyAgICBpZiB0ZXN0 IC1mIC9wcm9jL3N5cy9rZXJuZWwvdW5wcml2aWxlZ2VkX3VzZXJuc19jbG9uZQorICAgIHRoZW4K KyAgICAgICAgaWYgdGVzdCAkKGNhdCAvcHJvYy9zeXMva2VybmVsL3VucHJpdmlsZWdlZF91c2Vy bnNfY2xvbmUpID0gIjEiCisgICAgICAgIHRoZW4KKyAgICAgICAgICAgIHRydWUKKyAgICAgICAg ZWxzZQorICAgICAgICAgICAgZXhpdCA3NworICAgICAgICBmaQorICAgIGVsc2UKKyAgICAgICAg dHJ1ZQorICAgIGZpCitlbHNlCisgICAgZXhpdCA3NworZmkKKwogZ3VpeCBlbnZpcm9ubWVudCAt LXZlcnNpb24KIAogdG1wZGlyPSJ0LWd1aXgtZW52aXJvbm1lbnQtJCQiCi0tIAoyLjUuMAoK --94eb2c093a320a98fb0523b7806c--