From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thompson, David" Subject: Re: [PATCH 1/4] gnu: Add ruby-tzinfo-data. Date: Sun, 5 Jun 2016 09:54:11 -0400 Message-ID: References: <1465131653-28176-1-git-send-email-donttrustben@gmail.com> <1465131653-28176-2-git-send-email-donttrustben@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9YVJ-0001t2-MN for guix-devel@gnu.org; Sun, 05 Jun 2016 09:54:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9YVI-0004pj-D5 for guix-devel@gnu.org; Sun, 05 Jun 2016 09:54:13 -0400 Received: from mail-vk0-x235.google.com ([2607:f8b0:400c:c05::235]:33223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9YVI-0004pe-56 for guix-devel@gnu.org; Sun, 05 Jun 2016 09:54:12 -0400 Received: by mail-vk0-x235.google.com with SMTP id d64so45968556vkb.0 for ; Sun, 05 Jun 2016 06:54:11 -0700 (PDT) In-Reply-To: <1465131653-28176-2-git-send-email-donttrustben@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ben Woodcroft Cc: guix-devel On Sun, Jun 5, 2016 at 9:00 AM, Ben Woodcroft wrote: > * gnu/packages/ruby.scm (ruby-tzinfo-data): New variable. > --- > gnu/packages/ruby.scm | 41 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm > index c6b6eed..fa550cb 100644 > --- a/gnu/packages/ruby.scm > +++ b/gnu/packages/ruby.scm > @@ -2101,6 +2101,47 @@ aware transformations between times in different time zones.") > (home-page "http://tzinfo.github.io") > (license license:expat))) > > +(define-public ruby-tzinfo-data > + (package > + (name "ruby-tzinfo-data") > + (version "1.2016.4") > + (source > + (origin > + (method url-fetch) > + ;; Download from GitHub because the rubygems version does not contain > + ;; Rakefile or tests. > + (uri (string-append > + "https://github.com/tzinfo/tzinfo-data/archive/v" > + version > + ".tar.gz")) > + (file-name (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "0jnm8i379hn48cq5n39j7wzm08i0mw73kqzx3cqbxpiwlb1hnz80")))) > + (build-system ruby-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + ;; Remove the known test failure. > + ;; https://github.com/tzinfo/tzinfo-data/issues/10 > + ;; https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1587128 > + (add-before 'check 'remove-broken-test > + (lambda _ > + (substitute* "test/tc_definitions.rb" > + (("if utc && local") > + (string-append > + "if utc && local && !line.match(/Sun Oct 25 01:59:59 2037 UT" > + " = Sun Oct 25 02:59:59 2037 WEST isdst=1 gmtoff=3600/)")) > + #t)))))) Since this isn't a dynamic Guix-specific modification, could you transform this into a patch file to apply to the origin record? > + (propagated-inputs > + `(("ruby-tzinfo" ,ruby-tzinfo))) > + (synopsis "Data from the IANA Time Zone database") > + (description > + "This library provides @code{TZInfo::Data}, which contains data from the > +IANA Time Zone database packaged as Ruby modules for use with @code{TZInfo}.") > + (home-page "http://tzinfo.github.io") > + (license license:expat))) > + > (define-public ruby-rb-inotify > (package > (name "ruby-rb-inotify") > -- > 2.7.4 LGTM otherwise! - Dave