From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thompson, David" Subject: Re: Using 'system*' instead of 'system' in 'guix environment' Date: Fri, 9 Oct 2015 12:21:59 -0400 Message-ID: References: <87io6iqhbt.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> <87ziztyext.fsf@gnu.org> <87vbahpfrn.fsf@gnu.org> <87io6hpaie.fsf@gnu.org> <87d1wos01x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zkg2h-000581-NT for guix-devel@gnu.org; Fri, 09 Oct 2015 18:21:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zkg2e-0005dx-Sp for guix-devel@gnu.org; Fri, 09 Oct 2015 18:21:35 -0400 Received: from mail-yk0-f181.google.com ([209.85.160.181]:35844) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZkaQi-0006qR-70 for guix-devel@gnu.org; Fri, 09 Oct 2015 12:22:00 -0400 Received: by ykba192 with SMTP id a192so79109490ykb.3 for ; Fri, 09 Oct 2015 09:21:59 -0700 (PDT) In-Reply-To: <87d1wos01x.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: guix-devel On Fri, Oct 9, 2015 at 8:23 AM, Ludovic Court=C3=A8s wrote: > "Thompson, David" skribis: > >> From 4be0c2bfd2e2e9a03d860cfb2ff92aa66cbfaa70 Mon Sep 17 00:00:00 2001 >> From: David Thompson >> Date: Thu, 8 Oct 2015 21:23:09 -0400 >> Subject: [PATCH] scripts: environment: Use system* instead of system. >> >> This allows for direct program invokation without needing a shell to act >> as a command interpreter. >> >> * guix/scripts/environment.scm (%default-shell): New variable. >> (show-help): Adjust description. Remove '--exec' reference. >> (%default-options): Use '%default-shell'. >> (%options): Adjust '--exec' to run command via the default shell. >> (parse-args): New procedure. >> (guix-environment): Use 'parse-args'. Use 'system*' instead of >> 'system'. >> * guix/utils.scm (split): New procedure. >> * tests/guix-environment.sh: Adjust tests to use '--' instead of >> '--exec'. >> * tests/utils.scm: Add tests for 'split'. >> * doc/guix.texi ("Invoking guix environment"): Use new syntax. Remove >> '--exec' documentation. > > Looks good to me. Could you just add =E2=80=98split=E2=80=99 in a separa= te commit? > >> (option '(#\E "exec") #t #f > > Add a =E2=80=9Cdeprecated=E2=80=9D comment. > >> # Make sure the exit value is preserved. >> -if guix environment --ad-hoc guile-bootstrap --pure -E 'guile -c "(exit= 42)"' >> +if guix environment --ad-hoc guile-bootstrap --pure -- guile -c '(exit = 42)' > > Could you keep the example with -E, in addition to the new one, with a > comment noting that this is the deprecated syntax? We=E2=80=99ll remove = it when > we finally remove -E. > > OK with these changes, thank you! Thanks, fixed and pushed 2 commits. - Dave