From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Thompson, David" Subject: Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers. Date: Mon, 25 Jan 2016 09:04:28 -0500 Message-ID: References: <1453666771-16869-1-git-send-email-mthl@gnu.org> <1453666771-16869-5-git-send-email-mthl@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNhkw-0003Aa-N3 for guix-devel@gnu.org; Mon, 25 Jan 2016 09:04:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNhks-0006CM-Vf for guix-devel@gnu.org; Mon, 25 Jan 2016 09:04:34 -0500 Received: from mail-yk0-x243.google.com ([2607:f8b0:4002:c07::243]:34805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNhkr-0006C2-ON for guix-devel@gnu.org; Mon, 25 Jan 2016 09:04:30 -0500 Received: by mail-yk0-x243.google.com with SMTP id v14so12078733ykd.1 for ; Mon, 25 Jan 2016 06:04:29 -0800 (PST) In-Reply-To: <1453666771-16869-5-git-send-email-mthl@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mathieu Lirzin Cc: guix-devel On Sun, Jan 24, 2016 at 3:19 PM, Mathieu Lirzin wrote: > > Fixes . > > * guix/build/utils.scm (package-name->name+version): Use '@' for > separating package names and version numbers instead of '-'. This > provides the ability to use numbers in package names. > * guix/packages.scm (package-full-name): Add an optional SEPARATOR > argument defaulting to "@". > * doc/guix.texi (Invoking guix package, Invoking guix import): Adapt to > the new syntax. > * guix/ui.scm (package-specification->name+version+output): Likewise. > * guix/scripts/import/hackage.scm (show-help): Likewise. > * gnu/packages.scm (check-package-freshness, specification->package) > (specification->package+output): Likewise. > * emacs/guix-base.scm (guix-package-name-specification): Likewise. > * emacs/guix-main.scm (full-name->name+version) > (name+version->full-name): Likewise. > * tests/guix-build.sh: Likewise. > * tests/guix-lint.sh: Likewise. > * tests/guix-package.sh: Likewise. > * tests/packages.scm: Likewise. > * tests/ui.scm: Likewise. > * tests/utils.scm: Likewise. > * tests/graph.scm ("bag-emerged DAG"): Use 'package-full-name' optional > SEPARATOR argument. > * gnu/packages/commencement.scm (gcc-boot0): Likewise. > * NEWS: Mention new syntax. > --- > NEWS | 13 +++++++++++++ > doc/guix.texi | 12 ++++++------ > emacs/guix-base.el | 2 +- > emacs/guix-main.scm | 4 ++-- > gnu/packages.scm | 10 +++++----- > gnu/packages/commencement.scm | 2 +- > guix/build/utils.scm | 25 +++++++------------------ > guix/packages.scm | 9 ++++++--- > guix/scripts/import/hackage.scm | 2 +- > guix/ui.scm | 4 ++-- > tests/graph.scm | 2 +- > tests/guix-build.sh | 4 ++-- > tests/guix-lint.sh | 2 +- > tests/guix-package.sh | 4 ++-- > tests/ui.scm | 6 +++--- > tests/utils.scm | 4 ++-- > 16 files changed, 55 insertions(+), 50 deletions(-) Does the fact that so many files needed to be edited indicate the need for a single specification string constructor? If this had already been the case, then this patch would have only needed to change 1 or 2 procedures. That's not to say that this isn't great work! I just think that we could ease the maintenance burden with some refactoring. - Dave