From: "Thompson, David" <dthompson2@worcester.edu>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] system: container: Update to new service API.
Date: Thu, 29 Oct 2015 00:19:00 -0400 [thread overview]
Message-ID: <CAJ=RwfYfrSiqhXaPhi5iQEj7KavDZBPS6UT_1rK9QHKmBwjrZg@mail.gmail.com> (raw)
In-Reply-To: <87k2q8v42g.fsf@gnu.org>
On Tue, Oct 27, 2015 at 9:22 AM, Ludovic Courtès <ludo@gnu.org> wrote:
> Sorry, I meant to preserve #:container? behavior but I forgot this bit.
>
> I believe the attached patch provides an Even Greater Way to address the
> problem, namely by making the modprobe/firmware thing an optional
> service.
>
> Could you try and report back? I tried it in a VM and there’s no
> regression.
It works great, thanks! If you make a commit from this, I will reduce
this patch to simply fixing gnu/system/linux-container.scm.
> Besides, we’ll have to make sure ‘guix system extension-graph’ honors
> --container.
Hmm, yes, good point. I haven't looked at that code at all since it is so new.
- Dave
next prev parent reply other threads:[~2015-10-29 4:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 0:19 [PATCH] system: container: Update to new service API David Thompson
2015-10-27 0:21 ` Thompson, David
2015-10-27 13:22 ` Ludovic Courtès
2015-10-29 4:19 ` Thompson, David [this message]
2015-10-29 22:00 ` Ludovic Courtès
2015-10-30 0:58 ` Thompson, David
2015-10-30 16:41 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ=RwfYfrSiqhXaPhi5iQEj7KavDZBPS6UT_1rK9QHKmBwjrZg@mail.gmail.com' \
--to=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.