From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catonano Subject: Re: gnu: add you-get Date: Sat, 8 Apr 2017 10:57:34 +0200 Message-ID: References: <87wpav4jc6.fsf@163.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11422abce304ef054ca3ee3e Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cwmBd-0000HQ-Jm for guix-devel@gnu.org; Sat, 08 Apr 2017 04:57:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cwmBc-0007yf-8b for guix-devel@gnu.org; Sat, 08 Apr 2017 04:57:37 -0400 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]:37743) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cwmBb-0007yb-Vc for guix-devel@gnu.org; Sat, 08 Apr 2017 04:57:36 -0400 Received: by mail-wm0-x230.google.com with SMTP id u2so6767389wmu.0 for ; Sat, 08 Apr 2017 01:57:35 -0700 (PDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Feng Shu Cc: guix-devel --001a11422abce304ef054ca3ee3e Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I forgot one last note ! Guix has a brand new issue tracker ! In the future would you send your patches to guix-patches@gnu.org ? Thanks again ! 2017-04-08 10:55 GMT+02:00 Catonano : > Hi Feng Shu, > > Thanks or contributing to Guix ! > > This patch for you-download is almost good, just a few notes: > > +(define-public you-get > + (package > + (name "you-get") > + (version "0.4.652") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "https://github.com/soimort/ > you-get/releases/download/v" > + version "/you-get-" version ".tar.gz")) > + (sha256 > + (base32 > + "0brkz98lycx8mmxjwmn7jlhqfdbvl0hy070n7skwr1k75kh99q30"))= )) > > + (build-system python-build-system) > + (arguments '(#:tests? #f)) > > In the source code I can find no tests. But a comment about tests absence= , > here, would be preferable. > > Would you mind to add it ? > > Also, on the home page of this project I see that Ffmpeg or libva are > dependencies but the are no inputs or propagated inputs in this package > definition > > I didn't try to run this package but I suppose it won't run properly. > Am I wrong ? > > + (synopsis "Download videos, audios or images from the websites") > + (description > + "you-get is a tiny command-line utility, which can download media > +contents (videos, audios, images) from the Web, in case there is no othe= r > +handy way to do it.") > + (home-page "https://you-get.org/") > + (license license:expat))) > > I downloaded the tarball from git and the source files in the folder > "cli_wrapper" are empty. > > Both Gedit and nano can read no lines > > Some files have a size of 0 > Others are extremely small > > I don't know what this could be. > > Can you confirm that instead they are correctly written ? > > Or are they empty or you too ? > > Also, you should add a line about copyright attribution to yourself. > At the beginning of the file there are many lines like this > > ;;; Copyright =C2=A9 2017 humanitiesNerd > > You should add one or yourself. > As you can see, niknames are ok ;-) > > Would you send a new patch with these suggestions integrated ? > > Thanks and welcome ! > > > --001a11422abce304ef054ca3ee3e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I forgot one last note !

Guix = has a brand new issue tracker ! In the future would you send your patches t= o

guix-patches@gnu.or= g ?

Thanks again !


2017-04-08 10:55 GMT+02:00 Catonano <cato= nano@gmail.com>:
Hi Feng Shu,

Thanks or contributing to Guix !

This patch for you-d= ownload is almost good, just a few notes:

+(define-public you-get
+=C2=A0 (package
+=C2=A0=C2=A0=C2=A0 (name "you-get")
+=C2=A0=C2=A0=C2=A0 (version "0.4.652")
+=C2=A0=C2=A0=C2=A0 (source (origin
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 (method url-fetch)
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 (uri (string-append
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "https://githu= b.com/soimort/you-get/releases/download/v"
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 version "/you-get-"= version ".tar.gz"))
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 (sha256
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 (base32
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 "0brkz98lycx8mmxjwmn7jlhqfdbvl0hy070n7= skwr1k75kh99q30"))))
+=C2=A0=C2=A0=C2=A0 (build-system python-build-system)
+=C2=A0=C2=A0=C2=A0 (arguments '(#:tests? #f))

In the source code I can find no t= ests. But a comment about tests absence, here, would be preferable.

=
Would you mind to add it ?

Also, on the home page of this project I see that = Ffmpeg or libva are dependencies but the are no inputs or propagated inputs= in this package definition

I didn&= #39;t try to run this package but I suppose it won't run properly.
=
Am I wrong ?

+=C2=A0=C2=A0=C2=A0 (synopsis "Download videos, audios or i= mages from the websites")
+=C2=A0=C2=A0=C2=A0 (description
+=C2=A0=C2=A0=C2=A0=C2=A0 "you-get is a tiny command-line utility,= which can download media
+contents (videos, audios, images) from the Web, in case there is no ot= her
+handy way to do it.")
+=C2=A0=C2=A0=C2=A0 (home-page "https://you-get.org/")
+=C2=A0=C2=A0=C2=A0 (license license:expat)))

I downloaded the tarball from git and the source files in the folde= r "cli_wrapper" are empty.

Both Gedit and nano can read no lines

<= /div>
Some files have a size of 0
Others are extremely small

I don't know what this could be.

Can you confirm that instead they are correctly writt= en ?

Or are they empty or you too ?=

A= lso, you should add a line about copyright attribution to yourself.
At the beginning of the file there are many lines like this

;;; Copyright =C2=A9 2017 humanitiesNerd <catonano@gmail.com>=

You should add one or yourself.
As you can see, niknames are ok ;-)

Would y= ou send a new patch with these suggestions integrated ?

Thanks and welcome !



--001a11422abce304ef054ca3ee3e--