From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catonano Subject: Re: [PATCH] gnu: Add emacs-clojure-mode Date: Thu, 19 May 2016 12:20:34 +0200 Message-ID: References: <878tz61l7s.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a1140b8ec191fd305332f5353 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3L4L-0003gn-1h for guix-devel@gnu.org; Thu, 19 May 2016 06:20:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3L4F-0004A0-0l for guix-devel@gnu.org; Thu, 19 May 2016 06:20:39 -0400 Received: from mail-io0-x242.google.com ([2607:f8b0:4001:c06::242]:35697) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3L4E-00049o-Mc for guix-devel@gnu.org; Thu, 19 May 2016 06:20:34 -0400 Received: by mail-io0-x242.google.com with SMTP id i75so14255286ioa.2 for ; Thu, 19 May 2016 03:20:34 -0700 (PDT) In-Reply-To: <878tz61l7s.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Kost Cc: guix-devel@gnu.org --001a1140b8ec191fd305332f5353 Content-Type: multipart/alternative; boundary=001a1140b8ec191fcb05332f5351 --001a1140b8ec191fcb05332f5351 Content-Type: text/plain; charset=UTF-8 2016-05-19 10:54 GMT+02:00 Alex Kost : > > Subject: gnu: Add emacs-clojure-mode > ^ > This is a nitpick of course, but we put a period here... > > > * gnu/packages/emacs.scm (emacs-clojure-mode): New variable > ^ > ... and here. > Do you mean like this ? Subject: gnu: Add emacs-clojure-mode. * gnu/packages/emacs.scm (emacs-clojure-mode): New variable. > > +(define-public emacs-clojure-mode > > + (package > > + (name "emacs-clojure-mode") > > + (version "5.3.0") > > + (source > > + (origin > > + (method git-fetch) > > + (uri (git-reference > > + (url "https://github.com/clojure-emacs/clojure-mode.git") > > + (commit "8ef7127da214cb7fd4b47fc943462f2a8bfb8f85"))) > > Is there a reason to use 'git-fetch'? I think a usual 'url-fetch' is > fine as there is: > . > No, there's no specific reason. Fixed it. > + (file-name (string-append name "-" version "-checkout")) > > + (sha256 > > + (base32 > > + "1x7nl5wzcah9hnlj5jfd3y5604w60zcqcw1nn6vw335c2vzzissj")))) > > + (build-system emacs-build-system) > > + (home-page "http://github.com/clojure-emacs/clojure-mode") > > + (synopsis "Major mode for Clojure code") > > + (description > > + "Provides font-lock, indentation, navigation and basic refactoring > for the > > We use full sentences for descriptions, like this: "This emacs package > provides ..." > Fixed > > > +Clojure programming language (http://clojure.org). > > Since we use texinfo to format descriptions, it is better to write: > > @uref{http://clojure.org, Clojure programming language} > Fixed > > > + > > +Using clojure-mode with paredit or smartparens is highly recommended. > > I think this description is too verbose. I would remove all the text > below. > Ok, I cut it. So, I edited the patch and attached it again. Would you see if it fits ? Thanks --001a1140b8ec191fcb05332f5351 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


2016-05-19 10:54 GMT+02:00 Alex Kost <alezost@gmail.com>= :
> Subject: gnu: Add emacs-clojure-mo= de
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^
This is a nitpick of course, but we put a period here...

> * gnu/packages/emacs.scm (emacs-clojure-mode): New variable
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^
... and here.

Do you mean like this ?
Subject: gnu: Add emacs-clojure-mode.

* gnu/packages/emacs.scm= (emacs-clojure-mode): New variable.
=C2=A0
> +(define-public emacs-clojure-mode
> +=C2=A0 (package
> +=C2=A0 =C2=A0 (name "emacs-clojure-mode")
> +=C2=A0 =C2=A0 (version "5.3.0")
> +=C2=A0 =C2=A0 (source
> +=C2=A0 =C2=A0 =C2=A0(origin
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(method git-fetch)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(uri (git-reference
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(url "https://github.com/clojure-emacs/clojure-mode.git")<= br> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(commit "8ef7127= da214cb7fd4b47fc943462f2a8bfb8f85")))

Is there a reason to use 'git-fetch'?=C2=A0 I think a usual 'ur= l-fetch' is
fine as there is:
<https://github.com/clojure-ema= cs/clojure-mode/archive/5.3.0.tar.gz>.

No, there's no specific reason. Fixed it.

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(file-name (string-append name "-&quo= t; version "-checkout"))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(sha256
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 (base32
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "1x7nl5wzcah9hnlj5jfd3y5604w6= 0zcqcw1nn6vw335c2vzzissj"))))
> +=C2=A0 =C2=A0 (build-system emacs-build-system)
> +=C2=A0 =C2=A0 (home-page "http://github.com/c= lojure-emacs/clojure-mode")
> +=C2=A0 =C2=A0 (synopsis "Major mode for Clojure code")
> +=C2=A0 =C2=A0 (description
> +=C2=A0 =C2=A0 =C2=A0"Provides font-lock, indentation, navigation= and basic refactoring for the

We use full sentences for descriptions, like this: "This emacs package=
provides ..."

Fixed
=C2=A0
<= /div>

> +Clojure programming language (http://clojure.org).

Since we use texinfo to format descriptions, it is better to write:

=C2=A0 @uref{http://clojure.org, Clojure programming language}

Fixed
=C2=A0