From: Catonano <catonano@gmail.com>
To: Feng Shu <tumashu@163.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: gnu: add you-get
Date: Sat, 8 Apr 2017 10:55:09 +0200 [thread overview]
Message-ID: <CAJ98PDz1SuHRYoYJG+uQrxMadQ-6Wt8ARAGNRMADHj7CQjn8ww@mail.gmail.com> (raw)
In-Reply-To: <87wpav4jc6.fsf@163.com>
[-- Attachment #1: Type: text/plain, Size: 2044 bytes --]
Hi Feng Shu,
Thanks or contributing to Guix !
This patch for you-download is almost good, just a few notes:
+(define-public you-get
+ (package
+ (name "you-get")
+ (version "0.4.652")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://github.com/soimort/you-get/releases/download/v"
+ version "/you-get-" version ".tar.gz"))
+ (sha256
+ (base32
+ "0brkz98lycx8mmxjwmn7jlhqfdbvl0hy070n7skwr1k75kh99q30"))))
+ (build-system python-build-system)
+ (arguments '(#:tests? #f))
In the source code I can find no tests. But a comment about tests absence,
here, would be preferable.
Would you mind to add it ?
Also, on the home page of this project I see that Ffmpeg or libva are
dependencies but the are no inputs or propagated inputs in this package
definition
I didn't try to run this package but I suppose it won't run properly.
Am I wrong ?
+ (synopsis "Download videos, audios or images from the websites")
+ (description
+ "you-get is a tiny command-line utility, which can download media
+contents (videos, audios, images) from the Web, in case there is no other
+handy way to do it.")
+ (home-page "https://you-get.org/")
+ (license license:expat)))
I downloaded the tarball from git and the source files in the folder
"cli_wrapper" are empty.
Both Gedit and nano can read no lines
Some files have a size of 0
Others are extremely small
I don't know what this could be.
Can you confirm that instead they are correctly written ?
Or are they empty or you too ?
Also, you should add a line about copyright attribution to yourself.
At the beginning of the file there are many lines like this
;;; Copyright © 2017 humanitiesNerd <catonano@gmail.com>
You should add one or yourself.
As you can see, niknames are ok ;-)
Would you send a new patch with these suggestions integrated ?
Thanks and welcome !
[-- Attachment #2: Type: text/html, Size: 3417 bytes --]
next prev parent reply other threads:[~2017-04-08 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 4:24 gnu: add you-get Feng Shu
2017-04-08 8:55 ` Catonano [this message]
2017-04-08 8:57 ` Catonano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ98PDz1SuHRYoYJG+uQrxMadQ-6Wt8ARAGNRMADHj7CQjn8ww@mail.gmail.com \
--to=catonano@gmail.com \
--cc=guix-devel@gnu.org \
--cc=tumashu@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.