[bug#29764] [PATCH] gnu: lollypop: Use meson-build-system.

[Catonano <catonano@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2365 bytes --]

Hi Thomas !

2017-12-26 13:13 GMT+01:00 Thomas Danckaert <post@thomasdanckaert.be>:

> From: Catonano <catonano@gmail.com>
> Subject: Re: [bug#29764] [PATCH] gnu: lollypop: Use meson-build-system.
> Date: Fri, 22 Dec 2017 20:02:38 +0100
>
>
> This is what happened in the terminal (is this phisiological or
>> pathological ?)
>>
>> ~$ lollypop
>> cannot import name 'BadAuthenticationError'
>>     - Scrobbler disabled
>>     - Auto cover download disabled
>>     - Artist information disabled
>> $ sudo pip3 install pylast
>> /gnu/store/ci1r0vymm49jlxhwv394aqk4shjmd6gh-python-pygobject-3.24.1/
>> lib/python3.5/site-packages/gi/module.py:178: Warning:
>> g_array_append_vals: assertion 'array' failed
>>   g_type = info.get_g_type()
>> /gnu/store/ci1r0vymm49jlxhwv394aqk4shjmd6gh-python-pygobject-3.24.1/
>> lib/python3.5/site-packages/gi/module.py:178: Warning:
>> g_hash_table_lookup: assertion 'hash_table != NULL' failed
>>   g_type = info.get_g_type()
>> /gnu/store/ci1r0vymm49jlxhwv394aqk4shjmd6gh-python-pygobject-3.24.1/
>> lib/python3.5/site-packages/gi/module.py:178: Warning:
>> g_hash_table_insert_internal: assertion 'hash_table != NULL' failed
>>   g_type = info.get_g_type()
>>
>> As you can see there's a
>>
>> $ sudo pip3 install pylast
>>
>> line in the output
>>
>> I don't really understand how that's possible, but I checked this 2
>> times
>>
>
> Hi,
>
> thanks for testing again.  I think the line about pylast is meant as an
> advice to install pylast, because there was an error interacting with that
> library.  This is fixed in version 0.9.306, so I included an update to this
> version in the patch.
>
> I think the other warnings are “harmless”.


Ok, I built it again and there are no issues now, only those harmless
warnings


>
>
> Where can I download some mp3s legally ?
>> I would test it with some real music
>>
>
> I can confirm it works here.  If you want to try it yourself: I don't have
> an example of an mp3 sample ready, but you could always extract the audio
> from an online video (youtube, vimeo, ...) using youtube-dl? (Or, if you
> still have cd's and such: extract one of your cd's to ogg or mp3)
>

ehm, if you say it works for you, I'll believe you. I'm not ready to fiddle
with mp3 extrraction now

So, as far as I am concerned, LGTM !

[-- Attachment #2: Type: text/html, Size: 3363 bytes --]