From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catonano Subject: Re: [PATCH] Emacs Smartparens Date: Wed, 18 May 2016 00:44:19 +0200 Message-ID: References: <8760ueqdeb.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a1140b8ec4995820533117b8e Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2qPM-0005C3-QO for guix-devel@gnu.org; Tue, 17 May 2016 21:36:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2niv-000873-9d for guix-devel@gnu.org; Tue, 17 May 2016 18:44:22 -0400 Received: from mail-io0-x241.google.com ([2607:f8b0:4001:c06::241]:33627) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2niv-00086v-26 for guix-devel@gnu.org; Tue, 17 May 2016 18:44:21 -0400 Received: by mail-io0-x241.google.com with SMTP id x35so6296454ioi.0 for ; Tue, 17 May 2016 15:44:19 -0700 (PDT) In-Reply-To: <8760ueqdeb.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Kost Cc: guix-devel@gnu.org --001a1140b8ec4995820533117b8e Content-Type: multipart/alternative; boundary=001a1140b8ec49957a0533117b8c --001a1140b8ec49957a0533117b8c Content-Type: text/plain; charset=UTF-8 2016-05-16 16:35 GMT+02:00 Alex Kost > Catonano (2016-05-16 16:32 +0300) wrote: > > > Ok this is my second attempt > > > > This time it's Smartparens > > Thanks! > ;-) > I have the same comments as for the zenburn patch (especially about the > way you attach it; I can't really do anything when it is attached like > this), so let's deal with that patch at first and then you can update > this patch accordingly, if you don't mind. > > Sorry for the inconvenience :-) > it's ok ;-) Now, a few notes about Smartparens. Smartparens uses Cask. Cask is a language specific project management tool. Exactly the kind of thing that Guix aims at (right ?) As far as I understand, Cask provides, among other things, some unit tests running facility There's a target in a makefile piloting Cask to run the test. So I understand. And there's a folder filled with .el files containing tests to be run. So, the makefile, the Cask file, Make, Cask and the tests folder are dependencies ONLY in development. So maybe there should be 2 outputs for this project, one vanilla output and one for development. It gets worse There's a specific set of dependencies for every Smartparens submode (some languages have their own submode) so there should be an output for each of those And finally there's also a .travis.yml file, an images folder with some gif files in it, an org-mode file and some files ending with .feature All this seems an excess to me. A developer will be able to set up an environment with Make, Cask and other ad hoc dependencies and the files will be present in the package anyway, even if not used. It's a few kilobytes anyway. I hope this is ok --001a1140b8ec49957a0533117b8c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
2016-05-16 16:35 GMT+02:00 Alex Kost <alezost@gmail.com>
Catonano (2016-05-16 16:32 +0300)= wrote:

> Ok this is my second attempt
>
> This time it's Smartparens

Thanks!

;-)
=C2=A0=
I have the same comments as for the zenburn patch (especially about the
way you attach it; I can't really do anything when it is attached like<= br> this), so let's deal with that patch at first and then you can update this patch accordingly, if you don't mind.

Sorry for the inconvenience :-)

it'= s ok ;-)

Now, a few notes about Smartparens.

Smartparens uses Cask. Cask is a language specific project management= tool.

Exactly the kind of thing that Guix aims at (right= ?)

As far as I understand, Cask provides, among other th= ings, some unit tests running facility

There's a targ= et in a makefile piloting Cask to run the test. So I understand. And there&= #39;s a folder filled with .el files containing tests to be run.

So, the makefile, the Cask file, Make, Cask and the tests folder ar= e dependencies ONLY in development.

So maybe there should= be 2 outputs for this project, one vanilla output and one for development.=

It gets worse

There's a specific s= et of dependencies for every Smartparens submode (some languages have their= own submode) so there should be an output for each of those
=
And finally there's also a .travis.yml file, an images f= older with some gif files in it, an org-mode file and some files ending wit= h .feature

All this seems an excess to me. A developer will be= able to set up an environment with Make, Cask and other ad hoc dependencie= s and the files will be present in the package anyway, even if not used.
It's a few kilobytes anyway.
<= br>
I hope this is ok

--001a1140b8ec49957a0533117b8c-- --001a1140b8ec4995820533117b8e Content-Type: text/x-patch; charset=US-ASCII; name="0001-gnu-Add-Smartparens.patch" Content-Disposition: attachment; filename="0001-gnu-Add-Smartparens.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ioby9mmx0 RnJvbSAxNDE2OTNhMjJlMjcxYWZjOGRjMzcyYzE5ZmM1N2E0YzJjODNiYTY5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBodW1hbml0aWVzTmVyZCA8Y2F0b25hbm9AZ21haWwuY29tPgpE YXRlOiBUdWUsIDE3IE1heSAyMDE2IDIzOjA3OjA2ICswMjAwClN1YmplY3Q6IGdudTogQWRkIHNt YXJ0cGFyZW5zCgoqICBnbnUvcGFja2FnZXMvZW1hY3Muc2NtIChlbWFjcy1zbWFydHBhcmVucyk6 IE5ldyB2YXJpYWJsZQotLS0KIGdudS9wYWNrYWdlcy9lbWFjcy5zY20gfCAzMCArKysrKysrKysr KysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAzMCBpbnNlcnRpb25zKCspCgpk aWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL2VtYWNzLnNjbSBiL2dudS9wYWNrYWdlcy9lbWFjcy5z Y20KaW5kZXggMzJlZDcyMi4uZDVmM2RhMiAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL2VtYWNz LnNjbQorKysgYi9nbnUvcGFja2FnZXMvZW1hY3Muc2NtCkBAIC0xNjEyLDMgKzE2MTIsMzMgQEAg SXQgaXMgYnVpbHQgb24gdG9wIG9mIHRoZSBjdXN0b20gdGhlbWUgc3VwcG9ydCBpbiBFbWFjcyAy NCBvciBsYXRlci4iKQogICAgIChsaWNlbnNlIGxpY2Vuc2U6Z3BsMyspKSkKIAogCisoZGVmaW5l LXB1YmxpYyBlbWFjcy1zbWFydHBhcmVucworKHBhY2thZ2UKKyAgKG5hbWUgImVtYWNzLXNtYXJ0 cGFyZW5zIikKKyAgKHZlcnNpb24gIjEuNy4xIikKKyAgKHNvdXJjZQorICAgIChvcmlnaW4KKyAg ICAgIChtZXRob2QgdXJsLWZldGNoKQorICAgICAgKHVyaSAoc3RyaW5nLWFwcGVuZAorICAgICAg ICAgICAgICJodHRwczovL2dpdGh1Yi5jb20vRnVjbzEvc21hcnRwYXJlbnMvYXJjaGl2ZS8iCisg ICAgICAgICAgICAgdmVyc2lvbgorICAgICAgICAgICAgICIudGFyLmd6IikpCisgICAgICAoZmls ZS1uYW1lIChzdHJpbmctYXBwZW5kIG5hbWUgIi0iIHZlcnNpb24gIi50YXIuZ3oiKSkKKyAgICAg IChzaGEyNTYKKyAgICAgICAgKGJhc2UzMgorICAgICAgICAgICIxYjQ3cHBrenNqOGo4YTJwMGJt dnEwNXJobTJkMmxzbTN3bGMwc2c1NDJyNHpyNm5qaThzIikpKSkKKyAgKGJ1aWxkLXN5c3RlbSBl bWFjcy1idWlsZC1zeXN0ZW0pCisgIChwcm9wYWdhdGVkLWlucHV0cyBgKCgiZW1hY3MtZGFzaCIg LGVtYWNzLWRhc2gpKSkKKyAgKGhvbWUtcGFnZSAiaHR0cHM6Ly9naXRodWIuY29tL0Z1Y28xL3Nt YXJ0cGFyZW5zIikKKyAgKHN5bm9wc2lzCisgICAiUGFyZWRpdC1saWtlIGluc2VydGlvbiwgd3Jh cHBpbmcgYW5kIG5hdmlnYXRpb24gd2l0aCB1c2VyIGRlZmluZWQgcGFpcnMiKQorICAoZGVzY3Jp cHRpb24KKyAgICJTbWFydHBhcmVucyBpcyBhIG1pbm9yIG1vZGUgZm9yIEVtYWNzIHRoYXQgZGVh bHMgd2l0aCBwYXJlbnMgcGFpcnMKK2FuZCB0cmllcyB0byBiZSBzbWFydCBhYm91dCBpdC4gIEl0 IHN0YXJ0ZWQgYXMgYSB1bmlmaWNhdGlvbiBlZmZvcnQKK3RvIGNvbWJpbmUgZnVuY3Rpb25hbGl0 eSBvZiBzZXZlcmFsIGV4aXN0aW5nIHBhY2thZ2VzIGluIGEgc2luZ2xlLAorY29tcGF0aWJsZSBh bmQgZXh0ZW5zaWJsZSB3YXkgdG8gZGVhbCB3aXRoIHBhcmVudGhlc2VzLCBkZWxpbWl0ZXJzLAor dGFncyBhbmQgdGhlIGxpa2UuICBTb21lIG9mIHRoZXNlIHBhY2thZ2VzIGluY2x1ZGUgYXV0b3Bh aXIsCit0ZXh0bWF0ZSwgd3JhcC1yZWdpb24sIGVsZWN0cmljLXBhaXItbW9kZSwgcGFyZWRpdCBh bmQgb3RoZXJzLiAgV2l0aAordGhlIGJhc2ljIGZlYXR1cmVzIGZvdW5kIGluIG90aGVyIHBhY2th Z2VzIGl0IGFsc28gYnJpbmdzIG1hbnkKK2ltcHJvdmVtZW50cyBhcyB3ZWxsIGFzIGNvbXBsZXRl bHkgbmV3IGZlYXR1cmVzIikKKyAgKGxpY2Vuc2UgbGljZW5zZTpncGwzKykpKQotLSAKMi41LjUK Cg== --001a1140b8ec4995820533117b8e--