From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43457) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eVXWU-00008d-MJ for guix-patches@gnu.org; Sun, 31 Dec 2017 01:55:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eVXWQ-0007cN-P7 for guix-patches@gnu.org; Sun, 31 Dec 2017 01:55:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:49641) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eVXWQ-0007c7-Kw for guix-patches@gnu.org; Sun, 31 Dec 2017 01:55:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eVXWQ-0000b6-6B for guix-patches@gnu.org; Sun, 31 Dec 2017 01:55:02 -0500 Subject: [bug#29878] [PATCH] gnu: Add emacs-evil-smartparens. Resent-Message-ID: MIME-Version: 1.0 In-Reply-To: <20171228113950.26120-1-arunisaac@systemreboot.net> References: <20171228113950.26120-1-arunisaac@systemreboot.net> From: Catonano Date: Sun, 31 Dec 2017 07:54:27 +0100 Message-ID: Content-Type: multipart/alternative; boundary="f403045e94fc39a9ad05619d5614" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 29878@debbugs.gnu.org --f403045e94fc39a9ad05619d5614 Content-Type: text/plain; charset="UTF-8" Hi Arun ! I linted and built your patch, it's ok I didn't run it because I can't use Vi(m) so maybe it's better if someone else tests this 2017-12-28 12:39 GMT+01:00 Arun Isaac : > * gnu/packages/emacs.scm (emacs-evil-smartparens): New variable. > --- > gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm > index 3d5b67a70..3c920ff91 100644 > --- a/gnu/packages/emacs.scm > +++ b/gnu/packages/emacs.scm > @@ -6551,3 +6551,27 @@ Feautures: > "@code{evil-matchit} is a minor mode for jumping between matching > tags in > evil mode using @kbd{%}. It is a port of @code{matchit} for Vim.") > (license license:gpl3+))) > + > +(define-public emacs-evil-smartparens > + (package > + (name "emacs-evil-smartparens") > + (version "0.4.0") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "https://github.com/expez/evil-smartparens/archive/" > + version ".tar.gz")) > + (file-name (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "1bwzdd3054d407d5j4m3njsbvmc9r8zzp33m32pj3b3irxrl68q0")))) > + (build-system emacs-build-system) > + (propagated-inputs > + `(("emacs-evil" ,emacs-evil) > + ("emacs-smartparens" ,emacs-smartparens))) > + (home-page "https://github.com/expez/evil-smartparens") > + (synopsis "Emacs Evil integration for Smartparens") > + (description "@code{emacs-evil-smartparens} is an Emacs minor mode > which > +makes Evil play nice with Smartparens.") > I would say @code{emacs-evil-smartparens} is an Emacs minor mode which makes Evil, the Emacs mode to simulate the Vi key combinations, play nice with Smartparens. I wouldn't assume that people reading the description know what Evil is Or, maybe a link to the Evil home page would be better, instead of a quite long sentence between commas ? I don't know, I'm not sure. Has anyone anything to say about this ? Thanks ! --f403045e94fc39a9ad05619d5614 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Arun !

I linted and built your p= atch, it's ok

I didn't run it because I can't use = Vi(m) so maybe it's better if someone else tests this

2017-12-28 12:39= GMT+01:00 Arun Isaac <arunisaac@systemreboot.net>:=
* gnu/packages/emacs.scm (emacs-evil-sma= rtparens): New variable.
---
=C2=A0gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
=C2=A01 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 3d5b67a70..3c920ff91 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -6551,3 +6551,27 @@ Feautures:
=C2=A0 =C2=A0 =C2=A0 "@code{evil-matchit} is a minor mode for jumping = between matching tags in
=C2=A0evil mode using @kbd{%}.=C2=A0 It is a port of @code{matchit} for Vim= .")
=C2=A0 =C2=A0 =C2=A0(license license:gpl3+)))
+
+(define-public emacs-evil-smartparens
+=C2=A0 (package
+=C2=A0 =C2=A0 (name "emacs-evil-smartparens")
+=C2=A0 =C2=A0 (version "0.4.0")
+=C2=A0 =C2=A0 (source
+=C2=A0 =C2=A0 =C2=A0(origin
+=C2=A0 =C2=A0 =C2=A0 =C2=A0(method url-fetch)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0(uri (string-append
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"https://github.com/expez/evil-smartparens/archive/"
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0version ".tar.gz"= ;))
+=C2=A0 =C2=A0 =C2=A0 =C2=A0(file-name (string-append name "-" ve= rsion ".tar.gz"))
+=C2=A0 =C2=A0 =C2=A0 =C2=A0(sha256
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 (base32
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"1bwzdd3054d407d5j4m3njsbvmc9r= 8zzp33m32pj3b3irxrl68q0"))))
+=C2=A0 =C2=A0 (build-system emacs-build-system)
+=C2=A0 =C2=A0 (propagated-inputs
+=C2=A0 =C2=A0 =C2=A0`(("emacs-evil" ,emacs-evil)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0("emacs-smartparens" ,emacs-smartpare= ns)))
+=C2=A0 =C2=A0 (home-page "https://github.com/expez/evil-smartparens")
+=C2=A0 =C2=A0 (synopsis "Emacs Evil integration for Smartparens"= )
+=C2=A0 =C2=A0 (description "@code{emacs-evil-smartparens} is an Emacs= minor mode which
+makes Evil play nice with Smartparens.")

I would say

@code{emacs-evil-smartparens} is an Emacs minor = mode which
makes Evil, the Emacs mode to simulate the Vi key combinations, play nice w= ith Smartparens.

I wouldn't assume that people= reading the description know what Evil is
Or, maybe a link t= o the Evil home page would be better, instead of a quite long sentence betw= een commas ?
I don't know, I'm not sure. Has anyone a= nything to say about this ?
=C2=A0
Thanks !
--f403045e94fc39a9ad05619d5614--