all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Catonano <catonano@gmail.com>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 29878@debbugs.gnu.org
Subject: [bug#29878] [PATCH] gnu: Add emacs-evil-smartparens.
Date: Sun, 31 Dec 2017 07:54:27 +0100	[thread overview]
Message-ID: <CAJ98PDy+HpyJBgrJnMY09C7Hf5HWGFqKAhESqDn7ho4avHZqng@mail.gmail.com> (raw)
In-Reply-To: <20171228113950.26120-1-arunisaac@systemreboot.net>

[-- Attachment #1: Type: text/plain, Size: 2083 bytes --]

Hi Arun !

I linted and built your patch, it's ok

I didn't run it because I can't use Vi(m) so maybe it's better if someone
else tests this

2017-12-28 12:39 GMT+01:00 Arun Isaac <arunisaac@systemreboot.net>:

> * gnu/packages/emacs.scm (emacs-evil-smartparens): New variable.
> ---
>  gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 3d5b67a70..3c920ff91 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -6551,3 +6551,27 @@ Feautures:
>       "@code{evil-matchit} is a minor mode for jumping between matching
> tags in
>  evil mode using @kbd{%}.  It is a port of @code{matchit} for Vim.")
>      (license license:gpl3+)))
> +
> +(define-public emacs-evil-smartparens
> +  (package
> +    (name "emacs-evil-smartparens")
> +    (version "0.4.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/expez/evil-smartparens/archive/"
> +             version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1bwzdd3054d407d5j4m3njsbvmc9r8zzp33m32pj3b3irxrl68q0"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-evil" ,emacs-evil)
> +       ("emacs-smartparens" ,emacs-smartparens)))
> +    (home-page "https://github.com/expez/evil-smartparens")
> +    (synopsis "Emacs Evil integration for Smartparens")
> +    (description "@code{emacs-evil-smartparens} is an Emacs minor mode
> which
> +makes Evil play nice with Smartparens.")
>

I would say

@code{emacs-evil-smartparens} is an Emacs minor mode which
makes Evil, the Emacs mode to simulate the Vi key combinations, play nice
with Smartparens.

I wouldn't assume that people reading the description know what Evil is
Or, maybe a link to the Evil home page would be better, instead of a quite
long sentence between commas ?
I don't know, I'm not sure. Has anyone anything to say about this ?

Thanks !

[-- Attachment #2: Type: text/html, Size: 3103 bytes --]

  reply	other threads:[~2017-12-31  6:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-28 11:39 [bug#29878] [PATCH] gnu: Add emacs-evil-smartparens Arun Isaac
2017-12-31  6:54 ` Catonano [this message]
2018-01-02 12:40   ` Arun Isaac
     [not found]   ` <10e3dcdc.AEEASwxsv3wAAAAAAAAAAAOu6r8AAAACwQwAAAAAAAW9WABaS33A@mailjet.com>
2018-01-02 14:08     ` Catonano
2018-01-02 18:07       ` bug#29878: " Arun Isaac
2018-01-02 12:28 ` [bug#29878] " Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ98PDy+HpyJBgrJnMY09C7Hf5HWGFqKAhESqDn7ho4avHZqng@mail.gmail.com \
    --to=catonano@gmail.com \
    --cc=29878@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.