all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Catonano <catonano@gmail.com>
To: Ricardo Wurmus <rekado@elephly.net>, Leo Famulari <leo@famulari.name>
Cc: help-guix <help-guix@gnu.org>
Subject: Re: no patch applies
Date: Fri, 5 Aug 2016 15:07:19 +0200	[thread overview]
Message-ID: <CAJ98PDwt0D=afYucpfv6d-r6RG3Htz69StNkVAVDZPScqu6ozw@mail.gmail.com> (raw)
In-Reply-To: <87twezh6i4.fsf@elephly.net>

[-- Attachment #1: Type: text/plain, Size: 1402 bytes --]

2016-08-05 12:09 GMT+02:00 Ricardo Wurmus <rekado@elephly.net>:

>
> Vincent Legoll <vincent.legoll@gmail.com> writes:
>
> > Hello
> >
> >>> I attempted to apply the patch onto a fresh Guix master and the patch
> does
> >>> not apply, I don't know why
> >
> > When I fail to apply a patch that's often because of a wrong -p
> parameter.
> > Try with "--dry-run -p0" or "--dry-run -p1" to find the good one. You
> can also
> > look at file paths in the patch and deduce the right path strip level.
>
> I haven’t used “patch” in quite a while because usually “git am
> the-patch-file” just works.  If the patch was created with “git
> format-patch” against master you shouldn’t have any problems using “git
> am” on it.
>
> ~~ Ricardo
>
>
>
Thank you all people for your help. I appreciate that.

Yes, Ricardo, you nailed it

I had attempted with

  git apply --check path/to/the.patch

because I read that it is a good idea to verify the applicability of a
patch before actually applying it

Then I tried with a simple

  git am path/to/the.patch

and it worked like a breeze

I looked at the log and there's the commit of the patch on top of f467c35261

I had wrongly assumed that "git apply --check.." and "git am..." would have
envisioned the same process

So what's the use case for "git apply --check.." ? Bah...

Thanks again

[-- Attachment #2: Type: text/html, Size: 2192 bytes --]

  reply	other threads:[~2016-08-05 13:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-05  3:28 no patch applies Catonano
2016-08-05  3:45 ` Leo Famulari
2016-08-05  7:59   ` Vincent Legoll
2016-08-05 10:09     ` Ricardo Wurmus
2016-08-05 13:07       ` Catonano [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-08-06 17:12 David Craven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ98PDwt0D=afYucpfv6d-r6RG3Htz69StNkVAVDZPScqu6ozw@mail.gmail.com' \
    --to=catonano@gmail.com \
    --cc=help-guix@gnu.org \
    --cc=leo@famulari.name \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.