From: Catonano <catonano@gmail.com>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 26401@debbugs.gnu.org
Subject: bug#26401: [PATCH] python-tryton (with no modules)
Date: Tue, 16 May 2017 20:36:22 +0200 [thread overview]
Message-ID: <CAJ98PDwXQ-crQ2F3pABn7BH89iZpb-98aLfq-6avGnBzMF7xBA@mail.gmail.com> (raw)
In-Reply-To: <c3fa946d.AEMAKXA0lrIAAAAAAAAAAAOu6r8AAAACwQwAAAAAAAW9WABZGzM6@mailjet.com>
[-- Attachment #1: Type: text/plain, Size: 2878 bytes --]
2017-05-16 19:12 GMT+02:00 Arun Isaac <arunisaac@systemreboot.net>:
>
> Sure!
>
> tryton, and tryton related packages (especially the server side modules,
> GNU Health, etc.) are numerous and complicated enough to deserve their
> own separate file. You can put them in gnu/packages/tryton.scm.
>
Note taken. I will.
For all practical purposes, I think it's best to assume that there is no
> python3 genshi package. Instead, we should simply package
> python2-genshi, and let the authors fix their python3 package. In any
> case, tryton needs only python2-genshi. So, there is no urgent need for
> the python3 genshi package. I guess, this also means that there will be
> no python3 relatorio package.
>
I'm afraid you're right.
Sigh. I devolved way too much effort in packaging Genshi :-/
> >> > + (arguments
> >> > + `(#:phases
> >> > + (modify-phases %standard-phases
> >> > + (add-before 'check 'preparations
> >> > + (lambda* _
>
> Since you're not using any of `lambda*' features, you can just use
> `lambda' here.
>
note taken
Actually, this is not a big deal. We'll leave it as it is. If necessary,
> I'll fix it before pushing.
>
Thanks
>
> > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> > index 57a67de41..f1ef53e1a 100644
> > --- a/gnu/packages/python.scm
> > +++ b/gnu/packages/python.scm
> > @@ -14622,3 +14622,25 @@ substitute for redis.")
> >
> > (define-public python2-fakeredis
> > (package-with-python2 python-fakeredis))
> > +
> > +(define-public python-sql
> > + (package
> > + (name "python-sql")
> > + (version "0.8")
> > + (source
> > + (origin
> > + (method url-fetch)
>
> ...
>
> > + (uri (pypi-uri
> > + "python-sql"
> > + version))
>
> Could you put these on the same line?
>
[...]
> > + (propagated-inputs
> > + `(("lxml" ,python2-lxml)
> > + ("genshi" ,python2-genshi)))
>
> Use full names here, including the python version in the package name. I
> mean the full name of "lxml" is "python2-lxml", not "python-lxml". Make
> similar changes wherever applicable.
>
Ouch !
I owe you an apology, here
I mistakenly sent you the same patch file as before
I'm sorry :-/
>
> Also, in several places, there was a typo saying "pyton" instead of
> "python". Please fix those.
>
Gosh.
My keyboard si defective. I've been pleading with my technician for months
now.
I try to pay attention but more errors slip than I'd like
Sorry :-/
>
> > * gnu/packages/python.scm (python-trytond, python2-trytond): New
> variables.
>
> Change this commit message replacing python-trytond with trytond as
> discussed earlier. Make a similar change for the commit message
> involving python-tryton (the client).
>
Give me me some time to mourn my Genshi package.
I will send a new series (really, this time) soonish
Thanks
[-- Attachment #2: Type: text/html, Size: 5171 bytes --]
next prev parent reply other threads:[~2017-05-16 18:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 12:17 bug#26401: [PATCH] python-tryton (with no modules) Catonano
2017-05-08 14:33 ` Arun Isaac
2017-05-15 6:39 ` Catonano
2017-05-15 13:19 ` Arun Isaac
2017-05-15 19:17 ` Catonano
2017-05-16 17:12 ` Arun Isaac
[not found] ` <c3fa946d.AEMAKXA0lrIAAAAAAAAAAAOu6r8AAAACwQwAAAAAAAW9WABZGzM6@mailjet.com>
2017-05-16 18:36 ` Catonano [this message]
2017-05-16 18:41 ` Catonano
2017-05-17 5:54 ` Arun Isaac
[not found] ` <4d3632b9.AEEAKq6kKpkAAAAAAAAAAAOu6r8AAAACwQwAAAAAAAW9WABZG-Wd@mailjet.com>
2017-05-17 7:45 ` Catonano
2017-05-18 17:49 ` Arun Isaac
[not found] ` <7e6e3d0c.ADsAALmm2EQAAAAAAAAAAAOu6r8AAAACwQwAAAAAAAW9WABZHd6n@mailjet.com>
2017-05-18 18:03 ` Catonano
2017-05-20 7:39 ` Catonano
2017-05-22 21:13 ` Arun Isaac
2017-05-27 14:21 ` Arun Isaac
[not found] ` <57fa2a94.AEMAKvi84IwAAAAAAAAAAAOu6r8AAAACwQwAAAAAAAW9WABZKYuO@mailjet.com>
2017-05-27 14:38 ` Catonano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ98PDwXQ-crQ2F3pABn7BH89iZpb-98aLfq-6avGnBzMF7xBA@mail.gmail.com \
--to=catonano@gmail.com \
--cc=26401@debbugs.gnu.org \
--cc=arunisaac@systemreboot.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.