From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catonano Subject: Re: Please review: documentation for python build system Date: Tue, 15 Nov 2016 11:18:06 +0100 Message-ID: References: <374a61a2-128e-12ca-7994-48961c9ef0ef@crazy-compilers.com> <87shqtdubm.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=e89a8f83a763c5c9cd0541544527 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6aoz-0007qw-Ep for guix-devel@gnu.org; Tue, 15 Nov 2016 05:18:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6aov-0006KH-6J for guix-devel@gnu.org; Tue, 15 Nov 2016 05:18:33 -0500 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:36392) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c6aou-0006HG-VI for guix-devel@gnu.org; Tue, 15 Nov 2016 05:18:29 -0500 Received: by mail-wm0-x22c.google.com with SMTP id g23so156854563wme.1 for ; Tue, 15 Nov 2016 02:18:28 -0800 (PST) In-Reply-To: <87shqtdubm.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Chris Marusich Cc: Guix-devel --e89a8f83a763c5c9cd0541544527 Content-Type: text/plain; charset=UTF-8 2016-11-15 9:24 GMT+01:00 Chris Marusich : > Hi Hartmut! > > Thank you very much for the documentation. It is quite clear, and it > helps clarify the background and intent of the new python build system. > My comments below are primarily grammatical or stylistic. I hope you > find my feedback helpful. > > Hartmut Goebel writes: > > > In Python there are different ways to install packages: distutils, > > setuptools, easy_install and pip. All of these are sharing the file > > setup.py, > > I suggest changing "All of these are sharing the file setup.py" to "All > of these use a file named setup.py". > For what it matters, I prefer the original wording. I think it's clearer I'm ok with the other suggestions of yours --e89a8f83a763c5c9cd0541544527 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


2016-11-15 9:24 GMT+01:00 Chris Marusich <cmmarusich@gmail.com= >:
Hi Hartmut!

Thank you very much for the documentation.=C2=A0 It is quite clear, and it<= br> helps clarify the background and intent of the new python build system.
My comments below are primarily grammatical or stylistic.=C2=A0 I hope you<= br> find my feedback helpful.

Hartmut Goebel <h.goebel= @crazy-compilers.com> writes:

> In Python there are different ways to install packages: distutils,
> setuptools, easy_install and pip.=C2=A0 All of these are sharing the f= ile
> setup.py,

I suggest changing "All of these are sharing the file setup.py&= quot; to "All
of these use a file named setup.py".

For what it matters, I prefer the original wording.
I thi= nk it's clearer

I'm ok with the other = suggestions of yours
--e89a8f83a763c5c9cd0541544527--