From mboxrd@z Thu Jan  1 00:00:00 1970
From: zimoun <zimon.toutoune@gmail.com>
Subject: Package gmsh: best practise with test-suite?
Date: Mon, 11 Feb 2019 19:45:02 +0100
Message-ID: <CAJ3okZ2yUNko9h2rb630Hib=NtCWxu+JWRZ0GZA+=LvewhTBRw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:55583)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zimon.toutoune@gmail.com>) id 1gtGZv-00069h-Vm
	for guix-devel@gnu.org; Mon, 11 Feb 2019 13:45:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zimon.toutoune@gmail.com>) id 1gtGZv-0007zP-3x
	for guix-devel@gnu.org; Mon, 11 Feb 2019 13:45:15 -0500
Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]:35278)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <zimon.toutoune@gmail.com>)
	id 1gtGZu-0007ym-WC
	for guix-devel@gnu.org; Mon, 11 Feb 2019 13:45:15 -0500
Received: by mail-qk1-x734.google.com with SMTP id w204so7100694qka.2
	for <guix-devel@gnu.org>; Mon, 11 Feb 2019 10:45:14 -0800 (PST)
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Guix Devel <guix-devel@gnu.org>

Hi Guix,

I am working on packaging GetDP [1] the companion finite element solver of Gmsh.

[1] http://getdp.info/

GetDP depends on some part of Gmsh. So I have a working
gmsh-minimal-no-x package, turning off FLTK, OpenCascade and
non-necessary features.

Then the full test suite fails. As expected. :-)
Now they are all turned off with "#:tests? #f".
Which is okish... but I am not fully satisfied.

Well, the issue is that the tests are generated with this piece of CMake:

  include(CTest)
  file(GLOB_RECURSE TESTFILES
       tutorial/*.geo demos/*.geo benchmarks/?d/*.geo benchmarks/extrude/*.geo)
  foreach(TESTFILE ${TESTFILES})
    # use relative path for cygwin/mingw (the pure win exe built with the mingw
    # compilers does not understand a full cygwin-style path)
    FILE(RELATIVE_PATH TEST ${CMAKE_CURRENT_BINARY_DIR} ${TESTFILE})
    add_test(${TEST} ./gmsh ${TEST} -3 -nopopup -o ./tmp.msh)
  endforeach()

What is the better?
 a- Patch the CMakeLists.txt to generate only the right tests
 b- Turn off all the tests

What do you think?

Thank you in advance for any comment.


All the best,
simon