From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mJjcMxmBIGIiQgEAgWs5BA (envelope-from ) for ; Thu, 03 Mar 2022 09:49:29 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id qOh/MBmBIGLX/gAAauVa8A (envelope-from ) for ; Thu, 03 Mar 2022 09:49:29 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 653603A39B for ; Thu, 3 Mar 2022 09:49:29 +0100 (CET) Received: from localhost ([::1]:60082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nPh9J-00021y-Ja for larch@yhetil.org; Thu, 03 Mar 2022 03:49:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPh8w-00020p-Lr for guix-patches@gnu.org; Thu, 03 Mar 2022 03:49:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:47534) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nPh8w-0001h9-27 for guix-patches@gnu.org; Thu, 03 Mar 2022 03:49:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nPh8w-0000YW-0g for guix-patches@gnu.org; Thu, 03 Mar 2022 03:49:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54216] [PATCH v2] gnu: shepherd-for-guix: New package for use in Guix. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 03 Mar 2022 08:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54216 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 54216@debbugs.gnu.org, Attila Lendvai , Leo Famulari Received: via spool by 54216-submit@debbugs.gnu.org id=B54216.16462973202107 (code B ref 54216); Thu, 03 Mar 2022 08:49:01 +0000 Received: (at 54216) by debbugs.gnu.org; 3 Mar 2022 08:48:40 +0000 Received: from localhost ([127.0.0.1]:41431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPh8a-0000Xv-5Y for submit@debbugs.gnu.org; Thu, 03 Mar 2022 03:48:40 -0500 Received: from mail-il1-f170.google.com ([209.85.166.170]:37774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPh8Y-0000Xf-AT for 54216@debbugs.gnu.org; Thu, 03 Mar 2022 03:48:39 -0500 Received: by mail-il1-f170.google.com with SMTP id i14so3490486ilv.4 for <54216@debbugs.gnu.org>; Thu, 03 Mar 2022 00:48:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=igeg4Ozmcltzi65vkKHFPIrMdEKojrB8a8pQBOZAS9Q=; b=dTtQ6YX2ZBtsARnAdPIqpSHf69SAaJIKD5+f20ucAvBWvBks2PdIlzN+yvJ6l1XXQF /ZjBmZQsJsUCtCWzfmUDJ6llzx50bfTZlO7iclX51JJA3Lbr2SVzKc8DwqrtuHAzfuTM 69EPW+hRehtkPzJalzAUXfCj+6Mf6XuyHZR4N4bwN1NGnW34WjZZsJDyK23l1gXQK0aY GLwAnB/pFBGy6q6Q479tCN9SXT7qhmwtEaEf3rPxMe3cbdBdxCR6nrgAHiVVAXlqo+Hl fDPNA7VIMw7vofCXMrwAQ/hyffBfgvI0cnJCN2IV0FE8+DFhhc+XG4rfkJxOEhHeveEH i6DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=igeg4Ozmcltzi65vkKHFPIrMdEKojrB8a8pQBOZAS9Q=; b=PzN9puhpuMqMOmSIjxMDs2OLvqKXPp42t7hi5FnCFyK4zMhQ/ObIcHNHMl9dPMfNGB LliYjxak5DdbaHipkhREkYs4n/9chXsHgd9UT1qSi4vuysR4gw+A6n5e/h5hnr/LP4oB E0D7Ero2MZCGK+5dNABOQh1oKHu33ySacF+Gv7F6S0x9LvYKysg/hY+2JXjUAvf704qR hL49YsdBiC4NFET0kEqoVtfExSheCOS1FPwnkTTj9ntkdfVnaWg3lIRw2BX9zjlOu+HY 0xx9qyzJCEmOluQvuxiPbHT14SaiG+YrxFrHesBPWkOK5stq8UqeqkGjh7s4wHhSc43G j0Fg== X-Gm-Message-State: AOAM530JsfuF+FxtfM6XLcOCi8ZTBr8axc4iKV0K8wyw4jaulue/tF5v cTrNiUFTrEbH97I/m2pA/CBq1ckrXBnDU9EAkg0= X-Google-Smtp-Source: ABdhPJxfhYGBMhPhf3MxjAPzq1jDfXzABN9bJ/HxG6zf3BialfStng76p1Afkhv3bbXzgi2qwMVw9MGMal0q/n4AEzA= X-Received: by 2002:a05:6e02:1a0f:b0:2c1:a8db:a266 with SMTP id s15-20020a056e021a0f00b002c1a8dba266mr30837472ild.127.1646297312712; Thu, 03 Mar 2022 00:48:32 -0800 (PST) MIME-Version: 1.0 References: <20220301182848.26694-1-attila@lendvai.name> <20220301184517.13439-1-attila@lendvai.name> <992c3326a10e0bb28491f8226ebbe84aa93ad9ca.camel@telenet.be> <15fbca84-83ed-43cd-9bd4-e187ccadf4ec@www.fastmail.com> <5d684728965ec36c604e9b77f650055269e8588e.camel@telenet.be> In-Reply-To: <5d684728965ec36c604e9b77f650055269e8588e.camel@telenet.be> From: zimoun Date: Thu, 3 Mar 2022 09:48:21 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1646297369; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=igeg4Ozmcltzi65vkKHFPIrMdEKojrB8a8pQBOZAS9Q=; b=XTO9kusL46uEXl/G3aaSsadBY4GjsFtQga/M21BSxZg5WEGzE9s6BBRl1+CJz+AXYhPSkK 27/m2ZP6Llw6pI134u0N95FoScmjDV7AuFLm8t1EeWQ0uCCPy5Gblb5YTVCtPTIZ9+eKL2 sjyhySEqSGvRciEa5IH6SHSdiEx/GGJ4p72a4yNmSg5z9Phspp9ERfeD4DswWehNZe+eBL piH6wEkWi15g2vxRV2uhxd/ehM6rOyZ/COjU33/i8m31Gng5NjJ9lU1UCKKAU2jGBSkDno WVKgtAs+uwm1b/TfG4HITIE7AKgn67w4qEkhdBIXmoTx09ic7fzSo261XOjv7w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1646297369; a=rsa-sha256; cv=none; b=s4fO0SctsEvE/V1+iD6TJTboYk4mziXx5QMYE3QFXtxL4zPRUf+TWDSaAHTWxxnxKAJhXV 4PsSfZBc77qA2DbnASbJvZrEc5m7tsBI3rL0VS/A5b+7pBRwbue5QXsvBizScz2Xv6WRqp sNCFsY/P1DLJokGy3octxu6j3WEqvcH70jpiZNHyIEfs8MZmbrz3yLRUKoUJReLPt3y1aP 8AqPRvD27+FzrEQoA1kIiEFBQuSevlUYPafKsdMDJka3fME3YGATE5/gY9uoU/wukPPzxy PXqwdux/dUf4OKT+RT55kT1R7uD/VUOVUFsX2EVksaHe9/jiq7GZykv2IKa/dw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=dTtQ6YX2; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.83 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=dTtQ6YX2; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 653603A39B X-Spam-Score: 5.83 X-Migadu-Scanner: scn1.migadu.com X-TUID: aRZ8IRcMU0WE Hi Maxime, On Thu, 3 Mar 2022 at 07:25, Maxime Devos wrote: > Leo Famulari schreef op wo 02-03-2022 om 18:50 [-0500]: > > Origin snippets should only be used to remove nonfree things > > from the upstream source code. All other changes should use > > patch files or a build phase. > > Why? If it's a source code change and it fits an origin snippet, > why not an origin snippet? Why would the source in Guix need to match > the source upstream? Because as I tried to explain here [1] ;-) 1: a) the location of patches depending of their nature is **not well-documented**, b) because it is a tension between two intentions, c) and thus we never take the time to clearly document for consistency. FWIW, it would be unfair for the patch to have the discussion here. As Leo, I also think this source modification should go to a phase. > Also, in this case, it was just copied from the 'shepherd' packages > with some slight adjustments. And I also think this recent commit 79be6a985799adc6d663890250f4fb7c12f015b4 introducing the 'snippet' is unfortunate. And it should be fixed, i.e., move the substitution to a phase. Cheers, simon