From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ECGhD6D7kGIQaAEAbAwnHQ (envelope-from ) for ; Fri, 27 May 2022 18:26:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id wH1xD6D7kGKWggEAauVa8A (envelope-from ) for ; Fri, 27 May 2022 18:26:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D41B1A483 for ; Fri, 27 May 2022 18:26:07 +0200 (CEST) Received: from localhost ([::1]:57124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nucms-0007Sb-Iw for larch@yhetil.org; Fri, 27 May 2022 12:26:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47114) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuchy-000779-KK for guix-patches@gnu.org; Fri, 27 May 2022 12:21:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41779) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuchy-0001FI-Bk for guix-patches@gnu.org; Fri, 27 May 2022 12:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nuchy-0007cP-6V for guix-patches@gnu.org; Fri, 27 May 2022 12:21:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 27 May 2022 16:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55673 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 55673@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 55673-submit@debbugs.gnu.org id=B55673.165366841529206 (code B ref 55673); Fri, 27 May 2022 16:21:02 +0000 Received: (at 55673) by debbugs.gnu.org; 27 May 2022 16:20:15 +0000 Received: from localhost ([127.0.0.1]:35676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuchD-0007b0-F6 for submit@debbugs.gnu.org; Fri, 27 May 2022 12:20:15 -0400 Received: from mail-pj1-f43.google.com ([209.85.216.43]:42987) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuchB-0007ag-L5 for 55673@debbugs.gnu.org; Fri, 27 May 2022 12:20:14 -0400 Received: by mail-pj1-f43.google.com with SMTP id cs3-20020a17090af50300b001e0808b5838so4783743pjb.1 for <55673@debbugs.gnu.org>; Fri, 27 May 2022 09:20:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=coB1NCuxcC85MbeMMPcUdyq7lT2/EV3iqJpW0372ZiE=; b=nprg6wrBYRG9V3h8i1fA/6NNgytFkgZgL0eATnj3ObeVTJj7XiX8TMV5ETkUO3INL9 pA2xpgAj1q/2RhnYhbkVxMaNEneP9EmgjzW0960Qv6jximeWZdYvB98Z9qLe+Q6FJaZX FexYatOk9icNWje4jaRVedTVYS+KISUOcBNwMHW13yVD6CtdMcO4yDq/mhefljebiAJO QftBpZRyIuQEo9+8K2+oj9fjihGKUS8jDHyrx1tnozCatW3IMp9x1Uh+JbwEDN7wIPoS tmxepfNLL/nk6PycM4h5ukTp7dip/RDyUiF+iCESE2JZQrbjCj1/hnyr1pIM2rMi/pYl dDDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=coB1NCuxcC85MbeMMPcUdyq7lT2/EV3iqJpW0372ZiE=; b=v7TIuCGeOq5lmi83P3RcwRmsY7hhN2ToiaZATra9jS6Bve6f/P6Fw9ctCy68PrmAPS 1OoyaSVPqPXV+RsiwerZ+NGXo59/SsTj98qtQfjBUyC8YFesk1rcoIhb9pF8tzGPlPvw gTgCrU62FU8GaKVme8v/+44tUc7CJHIRpK7gepVFj7mCjLHo2MAVQ8ttFbjnIFx3twJU 7vaUMIjqsTr4h9775VOTLPwAvS8ZGVpA+eFHv52+roSTacnEuQqlI00wbM6A2OxW8Ye2 IfuXD/UbbZ9oPtuVKvJDtlH5YVNeBB3xpezukxU+fSBph+NYCj6kEd32OSTSekayPKTn l8NQ== X-Gm-Message-State: AOAM533Pt3Q0WOTLzNqw6uw52dOJu59YAW3ZnDZNMLUc5eSLzeeXbFiI PWwVnN9StWGBFj3R0Y1t3qRxKWLl8Dca3QX3ACI= X-Google-Smtp-Source: ABdhPJw/tjQrUU/Bd/if9tZF6w1UvhsYraZgf4fymymubh4bkOsDtyy36BXVI/G5XH1B/ny7poUNyXSjn6YNKVLOiEs= X-Received: by 2002:a17:902:690b:b0:159:65c:9044 with SMTP id j11-20020a170902690b00b00159065c9044mr44715120plk.47.1653668407697; Fri, 27 May 2022 09:20:07 -0700 (PDT) MIME-Version: 1.0 References: <20220527082519.501697-1-zimon.toutoune@gmail.com> <9432b1161007faacc0bd0e58da0bf839e2e8ec39.camel@telenet.be> <24883447c6f3d9b27bcc6e11e117ee974916e091.camel@telenet.be> <9483424cc3c89e5fa83ccc1e22b1f6cc7d04dd95.camel@telenet.be> <02f4e72bba800a2f59064a8bf628357b5a96f1d6.camel@telenet.be> In-Reply-To: From: zimoun Date: Fri, 27 May 2022 18:19:55 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653668768; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=coB1NCuxcC85MbeMMPcUdyq7lT2/EV3iqJpW0372ZiE=; b=UE5vp5lg5ktk8zkL6DadtV6s0G7f8J5Si8OR8kovo34HPqIHoxbmaO5Juq86BrEt3bUkoW N58bQVHjUMWS3C7IaNrh6Z08H0w6I1fINzdQdEbj0ma+EZsbikAo5fTUNTwIdDv+ghA+Zf aQxRSi7EssjTAqrByxp8U4LidPY/30PPo2jXO5JGxwkrEq4fGmtDQLpOpTDIt32CpNYQZc 5ee+OOSAa9JwoX7j3fPe3fJEHwJQlKtKsuLPcxn0NcDagAWDQm6oGNp4z4EHGMCW3249wJ NyIJPcSAjblrlNOz9NbvC12pHk2OyqUSurC9MKF/5FMdGhloI2njnj8/IUUO6g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653668768; a=rsa-sha256; cv=none; b=l1gJHfncWOwQaLkab55aUo0RPoFIajg9D/8A3tFjZspQQqOqMyFr/7ivtwcfkQ6ZFNZs2O IXUiYX4oX/zoK02QEAANrZrpst8golbhriuuCRwE54cUxu2jSbA26yp9O0j3U8NlR0CilG 0KvCxxYyyEFR2J72Ckzk1tzWHs7Q1vSG4y542OhJnrHWKZjDLLZiXY0whyVt7LitpamWBY YQXQ0pi2/x/N4MmiCpM7oaciiGBAkPIw4o7uQvFiLU05fpzm3YC79NvSCbRgH2f1uA2QbC 7tcT+TtfOkZiSpOPyfBe9Ab0qnSYbAmu8CV/Tfm9Qw3Syu1O2buBpNj7s+MhSQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=nprg6wrB; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.65 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=nprg6wrB; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D41B1A483 X-Spam-Score: 5.65 X-Migadu-Scanner: scn0.migadu.com X-TUID: lMhMPkN/dKjk Hi, On Fri, 27 May 2022 at 16:02, Maxime Devos wrote: > Also, I do not understand the resistance -- I have a simple proposal > for generalising your patch to more failure modes, with a demonstration > and test case (see the file "a") on when it is necessary and a > proposed implementation. I have sent a v2 using your proposal (which appears to me overcomplicated). It is not resistance but pragmatic: the only case of interest is the empty file, which happens -- all the others, I am still waiting at least one bug report about them i.e., a user runs "guix time-machine" and suddenly the file last-expiry-cleanup is corrupted and "guix time-machine" unusable. Pragmatic because, for instance, from 2 to " or from 8 to ( it is one bit-flip and thus 'read' would be easily broken. I miss why such lengthy discussion about these theoretical failures of last-expiry-cleanup when it is also true each time 'read' is used, see least-authority or ui.scm etc. But I have never read a word. Anyway. Cheers, simon