From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SOouMFWokGI0CAEAbAwnHQ (envelope-from ) for ; Fri, 27 May 2022 12:30:45 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oHwwMFWokGKL3wAA9RJhRA (envelope-from ) for ; Fri, 27 May 2022 12:30:45 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6058126A1E for ; Fri, 27 May 2022 12:30:45 +0200 (CEST) Received: from localhost ([::1]:42600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuXEx-00038y-WB for larch@yhetil.org; Fri, 27 May 2022 06:30:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuXDK-0001ww-Nx for guix-patches@gnu.org; Fri, 27 May 2022 06:29:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38917) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuXDK-0005zq-EV for guix-patches@gnu.org; Fri, 27 May 2022 06:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nuXDK-0005wh-9j for guix-patches@gnu.org; Fri, 27 May 2022 06:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 27 May 2022 10:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55673 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 55673@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 55673-submit@debbugs.gnu.org id=B55673.165364733422833 (code B ref 55673); Fri, 27 May 2022 10:29:02 +0000 Received: (at 55673) by debbugs.gnu.org; 27 May 2022 10:28:54 +0000 Received: from localhost ([127.0.0.1]:32813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuXDB-0005wD-LP for submit@debbugs.gnu.org; Fri, 27 May 2022 06:28:53 -0400 Received: from mail-pf1-f175.google.com ([209.85.210.175]:36815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuXD8-0005vm-D9 for 55673@debbugs.gnu.org; Fri, 27 May 2022 06:28:50 -0400 Received: by mail-pf1-f175.google.com with SMTP id f21so3991360pfa.3 for <55673@debbugs.gnu.org>; Fri, 27 May 2022 03:28:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Xb9TrqF2yXM/kxS+Br2W66bOVe4fqdzjhpuXXN4isdY=; b=TMQ3Y3XYVo+F+BIUPnQBhQKxo3SHKQPvw24TooGc0WHiu7rcMI74F7A9xqfXE7PF+L AsYUDmFcm9ATRSC0p8FYqXgJuz9BAlD2oMVo8pAmr6PY/FlabPbT8rOQyV8ErhfDwmXy 7cgWG35AAK2+pgLqBMfhMHllakAmyQ35MigX48KY0+aAk6Gc8lxARYjOMp4SSvQN9kFD EkePgFkI5tnQx6HbKfmzfGrzPl2Z85raal6ZhiQvGAAH6rNjGIUvhVtQt4qN5LrMVeTs hpgXrBUy9yoSHUoqyxQ8T5PlPCMIBI+ocSgMgeeKH0+zorwSdnDnD5/nC22MbN+9aWZv lQ4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xb9TrqF2yXM/kxS+Br2W66bOVe4fqdzjhpuXXN4isdY=; b=nDvah1E+YzpVmKRw8PtNVO5gijpcxZmjp3mrgU4XtSpR2dt/q/GlqJY0PXjh13HuE2 Z0+ndigUWbcrPBXDAGTvs88r+EkcrQ9gX/FN2WEix0EgLuCxJlp0jMrYsKkpFtZ6Fub1 P7ZzEP5NVLGFt/Ldy0c43sTrBqYxmj3UqTKW7hk/apb5RHlRW24UyZKMeQSbxPJO/g9W DA3vBQuse5UWtl+wE9C7qsAjkOQq0UUjnIx8MTCu/sHnd9nBJbDUFXQHBHrBHQcJhOM9 HiDHP3i+Ao+71KQDpoz+8l+AOpVstBeJr7IbCPfTOOaLTcY2gXxRBKgO4HVV3Rrst9LA BFxQ== X-Gm-Message-State: AOAM530QptADF/Zw8VaI1yAHLb3aGhTKwDsDFPx0XB/NGmeBN+fXL1+X XL7ye0D9QglGFCci74JM5M3GbPcqdZ0PqhZRCi4= X-Google-Smtp-Source: ABdhPJyProSZ0SXtt5NhBB5zwyrbXCwTXVVRxV/oU10lz65mCVDRoe8tkcntF2SLVkXB+j4ihnPwVod1P9J+ESS7u70= X-Received: by 2002:aa7:9e1e:0:b0:518:3ee0:57a7 with SMTP id y30-20020aa79e1e000000b005183ee057a7mr41997995pfq.42.1653647324501; Fri, 27 May 2022 03:28:44 -0700 (PDT) MIME-Version: 1.0 References: <20220527082519.501697-1-zimon.toutoune@gmail.com> <9432b1161007faacc0bd0e58da0bf839e2e8ec39.camel@telenet.be> In-Reply-To: <9432b1161007faacc0bd0e58da0bf839e2e8ec39.camel@telenet.be> From: zimoun Date: Fri, 27 May 2022 12:28:33 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653647445; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Xb9TrqF2yXM/kxS+Br2W66bOVe4fqdzjhpuXXN4isdY=; b=X8HbLtzXGVWlLkW8vudoqj2XR6tTgdT1JpPOwzf351/W5hf3cGSAQNTLDgMOa2WJecLzOn kLmOusrgoZQUa7unmPYH2mfApAHbvqiAoZg+m6RJl7sLGwYH1O9LYTOSWeza0eYxJfSkdW T4TjpOxm70KCUOrlChrL9U21CAas5VBBlomS0nmqJAwXrGocW9X6rGpwwQl3W0qJR+ZWFl moCS560t5pVDNMiBuoizVMPqhEuE2JosPf3Qu+6fcGWnOIjYALPHPZ0cmmi1XzvXn+YGYq aYBSPuGdKzbqjda/WTqwwBnha7cHlp655fvHFdbKSV/aH3L9nvA6Ebwm/zespA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653647445; a=rsa-sha256; cv=none; b=qC9Z4oqXnwVu8QleJUOYXnwayHbokElHFGbNwBO50drsRvtIBALVbA9tcioFl081j/a3sW lwfd6x8+0m+NrTCcimBJJW1qQ+9Qq9WnMlgGu7eX2dlk9M3ApI7t7ZkHiobDiVdfiT/Gn0 H9TuQgHwymcWFh/OjB6gqjYiBHOE2ru+415MrQLPxddS5rxMveqMccWjYw9vKMRQvKMqnz xo74QzyGr7LExRTSEjGtExQ1P0StbY1AM9qJ3DZcWIXt29NtHIV8aI/2nJReygoQuomyIz Q2mWEmda3/bR9WSurm2/MDsTQnwD6eoIzyol5ZG/Ia8onB4pOqeMiD9ohYTEmA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=TMQ3Y3XY; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.16 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=TMQ3Y3XY; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6058126A1E X-Spam-Score: 5.16 X-Migadu-Scanner: scn0.migadu.com X-TUID: yZ+UqkJdSi/7 Hi Maxime, On Fri, 27 May 2022 at 11:54, Maxime Devos wrote: > zimoun schreef op vr 27-05-2022 om 10:25 [+0200]: > > (catch 'system-error > > (lambda () > > - (call-with-input-file expiry-file read)) > > + (match (call-with-input-file expiry-file read) > > + ((? integer? date) date) > > + (_ 0))) > > It might be possible to end up wit hsomething more bogus on some file > system, it's possible to end up with something even more boguse (e.g., > "unterminated-string), which 'read' doesn't understand. I suggest > using 'get-string-all' + 'number->string'. I do not see how. The integer is written by Guile using 'write'. >From my understanding, 'read' understands 'write', and vice-versa. > Also, I'd switch the catch and the (match ...) because 'read' and > integer? shouldn't raise any 'system-error'. All the cases are covered, IMHO. Cheers, simon