From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mDROCP7QkGLFlAAAbAwnHQ (envelope-from ) for ; Fri, 27 May 2022 15:24:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id kL5ZB/7QkGIdMwEAG6o9tA (envelope-from ) for ; Fri, 27 May 2022 15:24:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9420B17D41 for ; Fri, 27 May 2022 15:24:13 +0200 (CEST) Received: from localhost ([::1]:57828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuZwp-0003EN-JL for larch@yhetil.org; Fri, 27 May 2022 09:24:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuZwg-0003E4-U6 for guix-patches@gnu.org; Fri, 27 May 2022 09:24:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39257) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuZwg-0002t7-Jr for guix-patches@gnu.org; Fri, 27 May 2022 09:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nuZwg-0002Np-GZ for guix-patches@gnu.org; Fri, 27 May 2022 09:24:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 27 May 2022 13:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55673 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 55673@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 55673-submit@debbugs.gnu.org id=B55673.16536578309143 (code B ref 55673); Fri, 27 May 2022 13:24:02 +0000 Received: (at 55673) by debbugs.gnu.org; 27 May 2022 13:23:50 +0000 Received: from localhost ([127.0.0.1]:33154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuZwT-0002NP-VY for submit@debbugs.gnu.org; Fri, 27 May 2022 09:23:50 -0400 Received: from mail-pl1-f178.google.com ([209.85.214.178]:38755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuZwS-0002NB-QO for 55673@debbugs.gnu.org; Fri, 27 May 2022 09:23:49 -0400 Received: by mail-pl1-f178.google.com with SMTP id n18so4137315plg.5 for <55673@debbugs.gnu.org>; Fri, 27 May 2022 06:23:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vrHJ9SqbUMfXQLAh8Ir1Ac0VshvCxHRiToe++y31GD8=; b=PoIWBfYI8IuMkYaATorW3kim24aLLqy9f4f0b6wRO6YGrgnRlqE3RM90lHkRoG4S2L pIeuskx19Wfg+0MWlV0cOMH4MkERWhm/py/jfvnN2K3p3MY/OxTZ+MQO6oAZK3H/zRX+ 7tTrmSvCJnKsOOHhmojqIfjcTtRhgRspb6iirOLgxYOwf4uc98gQeQv+z0msU5CWcxHN Tnj5Ez+8/uUblYIGLwyKONQBy/R45fkHGMF+3WhfDy+jU/80SqF4vqmBWA6P+eqyJ0Pj xWKDvy7TGKTYqkM9iYjrwBZhXAXVihgqZDtjiZv5XgLtMcAZeK4IPwM9rumRUFu6YQYo GIEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vrHJ9SqbUMfXQLAh8Ir1Ac0VshvCxHRiToe++y31GD8=; b=v/gYFMuMhO6LJU65VveEGokO7+Iqm0E8VpbZn0NCJDuiMWbtBEIVVapCgfiphnZa3/ m4UWypSAlHjTN4zjYaOKFjL1ewwbDRPI1tEd50d149zeZXZb+wN8IQF9QTMvjqv0pA31 cg+UoO8ZPpMFEBLLKGIWDgHHwF3KsxxC12vFfYOMhy5sPWRZYigmX8093gEZTLVhS6ls f8O392jS8BYPlKzCdleb2cenej43PpN43VP4puH9FEKGXQ1WNuVxE+k04k9hhKork8Qy KyoFo2ZykEcdE1RTiz3mtel02RDfrOfkTfz4FmqCvGe+1nCdsaoAh+NE2IJgcCIgH8+W ThDQ== X-Gm-Message-State: AOAM530WjDCGYimGne2oS4NsgJD9VCXPJspFoR2sKcPeKB8WrppHtPZb +75uarQ+b0um8J0rjvHIEUwOYFREcym8jnLK5nQ= X-Google-Smtp-Source: ABdhPJzJ9/F1bcHKK/4y2lQ638UhiyH1FUCuE17I0yjcm2JuVRXSTT6w78wUCHO/vr9M0Yl7c2MfMTDjlglGaHcoBqc= X-Received: by 2002:a17:902:690b:b0:159:65c:9044 with SMTP id j11-20020a170902690b00b00159065c9044mr43986489plk.47.1653657823097; Fri, 27 May 2022 06:23:43 -0700 (PDT) MIME-Version: 1.0 References: <20220527082519.501697-1-zimon.toutoune@gmail.com> <9432b1161007faacc0bd0e58da0bf839e2e8ec39.camel@telenet.be> <24883447c6f3d9b27bcc6e11e117ee974916e091.camel@telenet.be> <9483424cc3c89e5fa83ccc1e22b1f6cc7d04dd95.camel@telenet.be> <02f4e72bba800a2f59064a8bf628357b5a96f1d6.camel@telenet.be> In-Reply-To: <02f4e72bba800a2f59064a8bf628357b5a96f1d6.camel@telenet.be> From: zimoun Date: Fri, 27 May 2022 15:23:31 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653657853; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=vrHJ9SqbUMfXQLAh8Ir1Ac0VshvCxHRiToe++y31GD8=; b=MNZ4r5F1qUX6wsFGV2A0Zcg0M6z/Zvr4I1PLLuwCk+Z6OgfL7mEa+owCQsIUanMO5cgR1Y F8u/hONY3pg48NhVTwlKfIpXTlRkSgmqj0P5XLXz1Oss1q4ZrdCeW3o5KAiAHc1vYlKfNh wEDY+nioifNdx++jnhKC1+jx0J97co8A+n0rfI57psRNtkayJsnq+qqQ5E1jg2P3xcT8BH 9UbHg352vyOK/kVCUbvI22Q77iVbePoB4J95/uugB/uuXRAd6EqMR3T3LNRCsXNa9b5l5J 9aHew2EHwRp2LISjbtGVfUpeilvSX3AJVfrj7zWDUzvdyK3//cvfKgOSrT1jDg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653657853; a=rsa-sha256; cv=none; b=gRsjNCyqGDZAXWjYT6KvmVM2XNZkqFMr8AcJ7mr2lG/J5dmkwVBMbabF4jAAzevg5kXSJA fz5mAhpwc0YSqmXBvUbTmA/xVk7Y5mpti3lPPSYzni9uufPa2uINL6AXQi3eVwqVITLe5i AxMMF/LrAhSUkU+P0H84Fa9nMwDaM59ZPKat2AYWaOM46AN22T6fwWO3Kkwrtib/SlLkvs Ww83qojGf37BReFSh8F0WggidxFSWNDHwRQe1oNAFI3HLky6ywRk5/OcMjOX3qBkg5e/9k sOxTQlOyi2+urTtrvZCbeoXavuQG7d/kRe3PNwQpFrozxxBDQ6qNherMDgnG/Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=PoIWBfYI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.95 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=PoIWBfYI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9420B17D41 X-Spam-Score: 5.95 X-Migadu-Scanner: scn1.migadu.com X-TUID: M4NYJIzZAmfw Hi Maxime, On Fri, 27 May 2022 at 15:04, Maxime Devos wrote: > scheme@(guile-user)> (call-with-input-file "a" read) > ice-9/boot-9.scm:1669:16: In procedure raise-exception: > In procedure scm_lreadr: a:2:1: end of file in string constant This is an ad-hoc example and not a real test case. --8<---------------cut here---------------start------------->8--- $ echo "foo" > ~/.cache/guix/inferiors/last-expiry-cleanup $ cat ~/.cache/guix/inferiors/last-expiry-cleanup foo $ ./pre-inst-env guix time-machine --commit=9d795fb -- help Usage: guix OPTION | COMMAND ARGS... Run COMMAND with ARGS, if given. --8<---------------cut here---------------end--------------->8--- As previously mentioned, the patch fixes: - empty file - non-integer I am not able to imagine an incomplete file worse than \\x00. > The difference is that ^R is interpreted as a symbol, whereas "foo > cannot be interpreted as anything at all by 'read'. I do not understand what you mean and I think you are overengineering. If you are able to produce a corrupted file which breaks "guix time-machine", then we can examine. Else let move on. :-) Cheers, simon