From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id hNEJFXTPk2FX6AAAgWs5BA (envelope-from ) for ; Tue, 16 Nov 2021 16:34:12 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KHj6D3TPk2F7eQAA1q6Kng (envelope-from ) for ; Tue, 16 Nov 2021 15:34:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E55869DCA for ; Tue, 16 Nov 2021 16:34:11 +0100 (CET) Received: from localhost ([::1]:54480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mn0TK-0006GP-IO for larch@yhetil.org; Tue, 16 Nov 2021 10:34:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38090) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mn0TC-0006GH-PE for guix-patches@gnu.org; Tue, 16 Nov 2021 10:34:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:47382) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mn0TC-0005FM-Gh for guix-patches@gnu.org; Tue, 16 Nov 2021 10:34:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mn0TC-0003Zy-AI for guix-patches@gnu.org; Tue, 16 Nov 2021 10:34:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51888] [PATCH 0/1] import: opam: Warn instead of leave when fetching fails. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 16 Nov 2021 15:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51888 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 51888@debbugs.gnu.org Received: via spool by 51888-submit@debbugs.gnu.org id=B51888.163707682613710 (code B ref 51888); Tue, 16 Nov 2021 15:34:02 +0000 Received: (at 51888) by debbugs.gnu.org; 16 Nov 2021 15:33:46 +0000 Received: from localhost ([127.0.0.1]:58928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mn0Sw-0003Z1-Fe for submit@debbugs.gnu.org; Tue, 16 Nov 2021 10:33:46 -0500 Received: from mail-il1-f174.google.com ([209.85.166.174]:40794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mn0Su-0003Yb-OH for 51888@debbugs.gnu.org; Tue, 16 Nov 2021 10:33:45 -0500 Received: by mail-il1-f174.google.com with SMTP id k1so20807339ilo.7 for <51888@debbugs.gnu.org>; Tue, 16 Nov 2021 07:33:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mBqPgns7wW1b8oZWp0e+VWAtI3q5f1jz+49zQENG5Ag=; b=dhVK0flcyMebTnEs6TdBsl6COPLHgkLj/i7bA692nKnf15ka+S/mtVCn/+w6wa/sz3 bFLIVnGAxbDkv+kxnRBDMxeBuj1tQfTVNyxgdJ0o0MhLb5E/9BeV/2B2Oio8z3zjP8pc bHb0RU8CP/fXgYcqiZsfyn/RwT5H5p0kCK/fI9xWPNAAxL+2BYnh7WpM9sPn83oym1FM poi9yUH04o2JMFkPjDN76xX+df6j00X+PvJ7sWp7ELvqkQG7rK53tPzN/PQAoy+iI6OA BcGuCSMSzN1vtG9+la9vF1xDvVN2egvpKKXNOunyhzyN52lzWTuAP7kf7dqnt1iHwKkt ldow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mBqPgns7wW1b8oZWp0e+VWAtI3q5f1jz+49zQENG5Ag=; b=hQYHIv6QfrgJ54xSRfwOBthVg9hgBQVz2FujEjA4LpXfxrFmA7lCzrINgQYZfqmDd3 CF0sztVhP6RtcmQptM2G2Adt4bFPEPr3gHkQb+ajFfFAfzh3r3C8woMYw0Ru0QmUkYIg c7NxPfftwx9G+GdCFao1D3VSnaugVCPDIrKmU7j0eF0r3pf7XHBVgJnFTPlFjIxcfmO8 1o1eF8wE7rBMzXfiPWZy6sfqdu/bbTa/lYONXuAKoDzQVCnGEVPi9I6GYQTLppj8kl3K JJGHvnC01UVQGMjNvgQxkp8wYrMyDWv0FAXAFtTvP1U71V4d8mbKrYQRsqcpMMss6kQs RDhQ== X-Gm-Message-State: AOAM531KnooYbAyUo0ue59BEtyTdjIpxZ/2+zgmPe2d1dv4q80jCCgm1 +9WTnk9+6uXs4d1GJfJEbMeD/R2bWVFD6v7tEwGtGS8zRkU= X-Google-Smtp-Source: ABdhPJwN/DSgKkK0nRhc8fbDGrdQkcyIZTTVMQUODVHXrrBGx2aDOS3HBNmuIw+trsExDc23NK7vBjPF87Z1XTwiAQY= X-Received: by 2002:a05:6e02:1210:: with SMTP id a16mr5429002ilq.75.1637076819050; Tue, 16 Nov 2021 07:33:39 -0800 (PST) MIME-Version: 1.0 References: <20211116101043.58471-1-zimon.toutoune@gmail.com> <20211116140248.1dcf61e5@tachikoma.lepiller.eu> In-Reply-To: <20211116140248.1dcf61e5@tachikoma.lepiller.eu> From: zimoun Date: Tue, 16 Nov 2021 16:33:28 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637076851; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=mBqPgns7wW1b8oZWp0e+VWAtI3q5f1jz+49zQENG5Ag=; b=RgIjm/c0GBhtu+RqZxIyUXj0vxcKQfwj5cXe0HaCIpslSd4Ho255LCb26sbOh3yDCoeT/9 XPh4nzPDD4wAp02qN5UKPpyrgPAnYK5a6b94cQkpkMbrUF06PzDYjGlSl8ZhTdQHLsiwpi n6o9pD0Rltgxch/y5uT3CrTNbORB/uYZn7UXzFXx86dzbF694UH3igEMuiYLZcCkGaNYL1 FbeHlkwFqY6oQAgf5N8U8O1AI2MyBjtiSxAMmXfl3MAxwGqLIrUTXEXPo0H2tLx92H7k60 5yUMlcC96tRBkFjKB/ZtSvtdzFVHa0k1r/nq4zE7zyqDwdz53k5yw83qNI1vUA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637076851; a=rsa-sha256; cv=none; b=i/uWUZViwXutLQE9Pr6UCOqlIjlXDi6YTtGD4boRv0vwJyqz4thOmtUnUOhdCFviu0o+16 S848wWHtcB0NJPLZfTABN1LyhUjpZRwsnMr5plkenPc2T360vbKfto9nsdbOOvQf5f1FG7 Eqb0FwMR6llMCiRmj/EJR9JSJ8KBoa3KUQtmWoxKvktR8N2WWk7LmIm1iLK1voMg1ByA4K KVvKCHj1VSU4Rawv4HiItp8jk6Z4zszKWP/Nz5XSqd9dvb222R3lKhPQ6+0o9qwlIInNQA Lt+rCEXM1iuxPHsxYZDB1WW9J9DlfJm8AVbk9N4wPapZ9FJkA1aG2bUxifhLmw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=dhVK0flc; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.85 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=dhVK0flc; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E55869DCA X-Spam-Score: -1.85 X-Migadu-Scanner: scn0.migadu.com X-TUID: XWKqleTnIwoZ Hi, On Tue, 16 Nov 2021 at 14:03, Julien Lepiller wrote: > I already had a patch for that, which is a bit more complex, at Sorry, I missed it. > https://issues.guix.gnu.org/51091. WDYT? Your patch LGTM. I am not convinced that all the complexity is worth; compared to the proposed trivial change. ;-) >From my opinion, the way is a common error for the all importers and raise it; all the catch happening in 'guix/scripts/'. That's another story. :-) One minor comment, in 'latest-release' I would write "opam: package '~a' not found~%" otherwise the message "guix lint: warning: package 'example' not found" looks odd (at least to me :-)). Feel free to close this issue and the other once you pushed a fix. Cheers, simon