From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id AAOuF5YYVmVh4QAAG6o9tA:P1 (envelope-from ) for ; Thu, 16 Nov 2023 14:26:46 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id AAOuF5YYVmVh4QAAG6o9tA (envelope-from ) for ; Thu, 16 Nov 2023 14:26:46 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4A48C50F80 for ; Thu, 16 Nov 2023 14:26:46 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Ed4hVnf0; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1700141206; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=iT1oPeGFA7W1gIoMlp6My9hhZFQktk1eIxQtFZfDzbg=; b=Bc53L9VntWt4v7rUVbB/ElF7OesXXXtuTKYonFPrE3rrmeCHuBoHfzVDzVSQ0+zTWb0snO elCgnAfsSTrTa1Rz+97KvQIPmfmSDB12tanK1/aVoKq/2UgQFV4bWgs4NUpYwDxYq2WOrZ qIkToaLxaG9f0dCF1/Xt837Jtz55iuZbmp6RDu9xA0m8lJzhdKf2nRzzwx6bfjRVOHgDnu SKiB9Y6GJzAhs5JlxX/XYgA7w8m7q1IWETRBfp3Q9tiSPcAb/Gyu7qsgNvpKdm51/OiV1e 8YsI64u0LBM9QpmVgS0QKz3Il3S5muF30/pu9nTNlVih4jRK/JR7IgWeyDGlZQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Ed4hVnf0; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1700141206; a=rsa-sha256; cv=none; b=QXjvt56nxkRyu8hJZ1r6vIa0mbw3NLw8XR1EEoSgVsXuvh5hTjdh74JHy4f8IGcbvM3ZHJ fLWvdRQp1ALTEAZ/tZwWA0/4FEFH/VPDGqqmdmtz0+Lp5BqMCg/YnszU4OHnsFjdENddEj fz6/QR1oJTDNl0HYsqZaznfTrnrFWXSY/RTwCCbblqQbp3RfvPNck2qAR8hdGpga1xNXnJ QtEK4QqPxYu3LX0N51q2B3uOgvcmCI1bRW1aNy0jocQamvjSEEPYy3dYE1/ZM+7a+5cvhx O9YlFH+oHswTNp2q2xojhYe5TnBiZDJ028WwkWDPUeFXiCAFZhcCG7gQWiU7+A== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3cO3-0003Y2-OF; Thu, 16 Nov 2023 08:26:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3cNf-0003Qk-SA for guix-patches@gnu.org; Thu, 16 Nov 2023 08:26:10 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3cNf-0008Rv-F3 for guix-patches@gnu.org; Thu, 16 Nov 2023 08:26:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3cNe-0003NG-S0 for guix-patches@gnu.org; Thu, 16 Nov 2023 08:26:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#66650] bug#65720: [bug#66650] [PATCH] git: Shell out to =?UTF-8?Q?=E2=80=98git_?= =?UTF-8?Q?gc=E2=80=99?= when necessary. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 16 Nov 2023 13:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66650 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , Christopher Baines , 65720@debbugs.gnu.org, 66650@debbugs.gnu.org Received: via spool by 66650-submit@debbugs.gnu.org id=B66650.170014111012882 (code B ref 66650); Thu, 16 Nov 2023 13:26:02 +0000 Received: (at 66650) by debbugs.gnu.org; 16 Nov 2023 13:25:10 +0000 Received: from localhost ([127.0.0.1]:54777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3cMo-0003Lb-5Z for submit@debbugs.gnu.org; Thu, 16 Nov 2023 08:25:10 -0500 Received: from mail-vk1-xa32.google.com ([2607:f8b0:4864:20::a32]:41402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3cMm-0003LE-4P; Thu, 16 Nov 2023 08:25:09 -0500 Received: by mail-vk1-xa32.google.com with SMTP id 71dfb90a1353d-4abf066fa12so164595e0c.1; Thu, 16 Nov 2023 05:25:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700141103; x=1700745903; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iT1oPeGFA7W1gIoMlp6My9hhZFQktk1eIxQtFZfDzbg=; b=Ed4hVnf0O55lV44Z9GY3Rhfpwgg/x23hJrRdeBg5mr1sIhK1fz9yM8RgeBDxFUq4D2 wXDNRqlb2BGJ41kaAtyzOWEWb/lVKPf8KCT6VRkxl5ew29kynlle159Y4hxgUYLsYq1A ZiRxaHANTDrZaj2Ncvi7wn2Ogql2He7f3aJ8cDvjA96vhiCKZRBBcCsGDZsdR8kUheHH apZNU8vr5Bl591napvUQ4WcfTDfIYcTXKSzqV4toZdbGayWYL2F8p/3KZvujLQlCyiTk cCpkX/rAjVBOufaxJRfBFL2nlH3eAZZDyJFiIyzVOLEyoemh6CSBHDNLvR0MjPPYp31A K8Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700141103; x=1700745903; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iT1oPeGFA7W1gIoMlp6My9hhZFQktk1eIxQtFZfDzbg=; b=affSzyL/wkSJFlt/npcguRlsap6WAEwtWz95L0cikApyA21gC9/tMNZTsiKzuhIwWo BKmlaz+8CAG+km1ucV6g9X+tjhyumwCYUuUHLeylg7lZfJ0UZQqxxl3qRXcI4bJuhPxr ePNK3VVX3azwqzsFHzBUYg8MKjHmX/rzzBa4pHhsKYWRROlC8Xon5YZEZF4SsMCQvhWP N+99DfE6gL5PZj6w03gQ0ljW9i3pnwuO1CqxxPDKh6aJ4PRMHQHSTlm1r0S2Ru9dV84e 4r4oc2NTlZgQzeyf+msvfjBiNH1FHOF9hkMezesUgo8Ggp90bPJSvs+yV32/GtvbmzNy 4/HQ== X-Gm-Message-State: AOJu0YxcyJxcEoSO9np/VcosNj8L+rn3dKmP3VxwEffwU5BVQjb2Tb5K gXxBlkmPn71ofWU+nCrWdYehxqFyZ81TLla4gyk= X-Google-Smtp-Source: AGHT+IERgt2ppQkKfWIZOIy7XSrP92IpnO9osFJyZ726t8riBobcc325dQ1HELzZa60bxTifVgexAjqSZNDmoWScr8g= X-Received: by 2002:a05:6102:2c02:b0:460:f279:ae0e with SMTP id ie2-20020a0561022c0200b00460f279ae0emr8825695vsb.1.1700141102724; Thu, 16 Nov 2023 05:25:02 -0800 (PST) MIME-Version: 1.0 References: <87jzswsrlt.fsf@gnu.org> <87sf5swc3j.fsf@cbaines.net> <87o7fwae0q.fsf@gnu.org> <87v8a4el3a.fsf@gmail.com> <87h6ll28yh.fsf@gnu.org> In-Reply-To: <87h6ll28yh.fsf@gnu.org> From: Simon Tournier Date: Thu, 16 Nov 2023 14:24:51 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 5.07 X-Spam-Score: 5.07 X-Migadu-Queue-Id: 4A48C50F80 X-Migadu-Scanner: mx13.migadu.com X-TUID: qHngd9WQzThl Hi, On Thu, 16 Nov 2023 at 13:12, Ludovic Court=C3=A8s wrote: > > Well, I expect =E2=80=9Cguix gc=E2=80=9D to take some time and I choose= when. However, > > I want =E2=80=9Cguix pull=E2=80=9D or =E2=80=9Cguix time-machine=E2=80= =9D to be as fast as possible and > > here some extra time is added, and I cannot control exactly when. > > Yes, I see. The thing is =E2=80=98maybe-run-git-gc=E2=80=99 is only call= ed on the slow > path; so for example, it=E2=80=99s not called on a =E2=80=98time-machine= =E2=80=99 cache hit, but > only on a cache miss, which is already expensive anyway. What you mean as "only called on the slow path" is each time 'update-cached-checkout' is called, right? So, somehow when 'maybe-run-git-gc' is called appears to me "unpredictable". But anyway. :-) Let move it elsewhere if I am really annoyed. Cheers, simon