From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kA5qEKI1H2I0pAAAgWs5BA (envelope-from ) for ; Wed, 02 Mar 2022 10:15:14 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 6OYeDaI1H2IlYgAAauVa8A (envelope-from ) for ; Wed, 02 Mar 2022 10:15:14 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D65072D5DA for ; Wed, 2 Mar 2022 10:15:13 +0100 (CET) Received: from localhost ([::1]:38672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nPL4i-0001ek-9d for larch@yhetil.org; Wed, 02 Mar 2022 04:15:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPL4Y-0001eF-GZ for guix-patches@gnu.org; Wed, 02 Mar 2022 04:15:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45180) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nPL4Y-0000Gc-7C for guix-patches@gnu.org; Wed, 02 Mar 2022 04:15:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nPL4X-0006B7-VL for guix-patches@gnu.org; Wed, 02 Mar 2022 04:15:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54216] [PATCH v2] gnu: shepherd-for-guix: New package for use in Guix. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 02 Mar 2022 09:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54216 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Attila Lendvai Cc: 54216@debbugs.gnu.org, Maxime Devos Received: via spool by 54216-submit@debbugs.gnu.org id=B54216.164621246123689 (code B ref 54216); Wed, 02 Mar 2022 09:15:01 +0000 Received: (at 54216) by debbugs.gnu.org; 2 Mar 2022 09:14:21 +0000 Received: from localhost ([127.0.0.1]:39077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPL3s-0006A1-OL for submit@debbugs.gnu.org; Wed, 02 Mar 2022 04:14:20 -0500 Received: from mail-pj1-f47.google.com ([209.85.216.47]:41933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPL3q-00069n-SJ for 54216@debbugs.gnu.org; Wed, 02 Mar 2022 04:14:19 -0500 Received: by mail-pj1-f47.google.com with SMTP id ev16-20020a17090aead000b001bc3835fea8so1284658pjb.0 for <54216@debbugs.gnu.org>; Wed, 02 Mar 2022 01:14:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PhGEVvlMXp44S+R575yzguHTup86VGrxXzwVOs2BSFU=; b=LYrWySBd/9ggwckKTK+SZfQ3qTD/utKdM2houPU5MTOowewIv79terwvgTCtx5Fqsy hqD+6r1DQgpFV1gFYZ2Gt3djanj+ycXmgS8qrc1CSMSCtby2o65PJi/TflKvQeabBdvv EZ3K6od0A2k6tH66BZLJhUORxPGGXphNHjf+XCNBHHwwYXSBMKd1NR04e6nlmqaOBsxq WI9v9KUpax+EsmkcCsgeRRmG+fqHoIt70T83jWSG+8z8Y4jJfi1eyDLp+DRoj3fWJBS9 nFG4SS6O44/GaJ8sXNyiSO+agv4LJp+AOYFXCkHgcXOCALiJAblXH+R7M6xDQjBplEGV 1vEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PhGEVvlMXp44S+R575yzguHTup86VGrxXzwVOs2BSFU=; b=CO7QwGf1OE6OE3iUepUbuf6YrvgASllhHURgk+ChLrrTgmsXf3ZbkJaxR7nzuRVZbW i2yh2+0XrPYliqEh3T+QORwdGFwSm3OaC1VomDyOSVso85RmYKTwb/R0u3pG7jtpWGDD xzMgxzII81HzdzOPxeOXwIXoIvBtlf4H3Y1ypgKNei8iFlh6e8b4GTTbddcoIDnfftIG LtiOwyzorLQA/ZZsgzgimEtp79/KO/qZP2m0S3pl12EigcGi8st6AWOAz/HT9OteiBM6 2v3YSXKBoQASE17N4kGT8Aa2qIlq0uT+3m6Vq9+l4yjptJ6BpMruQ6A3r7KLMn+n0dol 19IQ== X-Gm-Message-State: AOAM533LOg4AxH2OL1L6teJeAiIiZ9lLAk8RZ92RRORpsdw/4ScEWsrB 1sU6LWXiIAWTeV+JCNyuuaCpa5NwkETNYC/cHpU= X-Google-Smtp-Source: ABdhPJyEkLNQQICgmQ2+Hu7XNVTplg7HjQG73uhPvH0LtB8VRzFtr1AShCztETK1GAXnfru4TLm90wEhWkNgr13Xil0= X-Received: by 2002:a17:90a:ec09:b0:1bc:d7c2:b2d5 with SMTP id l9-20020a17090aec0900b001bcd7c2b2d5mr25657004pjy.22.1646212453072; Wed, 02 Mar 2022 01:14:13 -0800 (PST) MIME-Version: 1.0 References: <20220301182848.26694-1-attila@lendvai.name> <20220301184517.13439-1-attila@lendvai.name> <992c3326a10e0bb28491f8226ebbe84aa93ad9ca.camel@telenet.be> In-Reply-To: From: zimoun Date: Wed, 2 Mar 2022 10:14:01 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1646212514; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=PhGEVvlMXp44S+R575yzguHTup86VGrxXzwVOs2BSFU=; b=f4FC7+uTksX6oSVMWnVTN2qWOwUzeSrHfwSVMpBKtCjj2LWKHOq6CNOhewzfRYRWdrbHhk PpGVe5FD5pbEGzEUnAFhXkSXHo2//BhTicX+N8UyDGtO78VgPOnT79KNlumH1W7J4Ob6nP LiafpnNEKP5tsl0D0uqUap8D/OXtawZ+j0/htlzVCh9G7DfmlOs9GF6idTixLIdo1onAOQ KxXkDhZKB1fy3DnXzAqFvk/6DGKaAorJRIZAHpu68g2Z90jXTyLciPmMTJoCB8fBFFMJhl ihRRQhBZAkCjm430qJAxJFQCSNkoUQfGifOpYZ9MZYoeqRTmt6LR3f2N4af8Tg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1646212514; a=rsa-sha256; cv=none; b=ag9YAEBRgO0eSJH+iU8DuPpfzXiBzeOZIW/0o0p9foZ+OcjtZX8Y9qvfsaVPhozz5RGcio u/qETGO52kdG+wd53Csn0D4xBzNosPNRE6lkWqfuvG/AqnM9OB6UxdxKaeuZtlzUmay0xn fSVPMB1iPl0FL/wQPtlLlJajX7qpWPfRg6r6QC4ssl7k2Tupf15CluS4Rx8J9vDwM3JGiJ zdPsaenkXj/aMOA/adACqjFOkXAFyK0/aBZssWSF6MC6qrkO6b1clRqO2LdffX2bQ3iFu3 8QA5gf/coDMDLxyMEsqeWEYkdVoceXvhDxWFSYRe69Q1J4Kjuv71up0EAh4HeA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=LYrWySBd; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.62 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=LYrWySBd; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D65072D5DA X-Spam-Score: 4.62 X-Migadu-Scanner: scn0.migadu.com X-TUID: 4EqFk9ps7/Qm Hi Attila, On Tue, 1 Mar 2022 at 20:42, Attila Lendvai wrote: > unfortunately, it won't help us much here, because one snippet modifies > Makefile.am, while the other Makefile.in. Guix does not have a clear line for patching (or I am not aware of the update); what is going to source+snippet vs arguments+phase. Pros and cons for both; basically the question is what "guix build --source" should return? Option source+snippet means it returns the source of what Guix really builds -- so many packages would not respect this rule of thumb. Option arguments+phase means it returns the real unmodified upstream source (modulo removal of non-free) -- so "guix shell -D foo" would break for many packages. Difficult tension. :-) For most cases, not an unique answer; maybe that's why we do not have a clear documentation. :-) I just mention it i.e., I am not saying you can do something. :-) I am simply pointing that Guix does not have a clear recommendation / documentation where the patches should go; probably depending on their nature. Well, nothing related with your patch. :-) That's said, personally, in this case, instead of having the Makefile* patch in 'source', I would do the patching using a phase. Cheers, simon