From mboxrd@z Thu Jan 1 00:00:00 1970 From: zimoun Subject: Re: Guix search, colors and INSIDE_EMACS Date: Tue, 4 Feb 2020 17:40:54 +0100 Message-ID: References: <87blqeml4w.fsf@ambrevar.xyz> <87tv46qqlf.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000c7aa54059dc2b452" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:34077) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iz1G8-00022q-1G for guix-devel@gnu.org; Tue, 04 Feb 2020 11:41:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iz1G6-000810-KH for guix-devel@gnu.org; Tue, 04 Feb 2020 11:41:07 -0500 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]:41182) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iz1G6-0007w3-Di for guix-devel@gnu.org; Tue, 04 Feb 2020 11:41:06 -0500 Received: by mail-qk1-x734.google.com with SMTP id d7so1824952qkk.8 for ; Tue, 04 Feb 2020 08:41:06 -0800 (PST) In-Reply-To: <87tv46qqlf.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: Guix Devel --000000000000c7aa54059dc2b452 Content-Type: text/plain; charset="UTF-8" Hi Ricardo, On Tue, 4 Feb 2020 at 17:12, Ricardo Wurmus wrote: > > - Rename it to GUIX_INSIDE_EMACS? > > - Document the existence of INSIDE_EMACS. > > The variable is set by Emacs. As an Emacs feature we should not > document it in Guix, nor should we rename it to GUIX_INSIDE_EMACS. This is mitigated by foreign distro using bad packaged terminal, see e.g. [1]. [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38940 And a couple of days, I was annoyed by this so I patched, see attached. Note that 'guix system describe' has also the "issue" and do not use the same function to display, I guess. Otherwise, the OSC issue should be fixed by Emacs 27, I guess. So the rename is probably not useful. Cheers, simon --000000000000c7aa54059dc2b452 Content-Type: text/x-patch; charset="US-ASCII"; name="fix-describe.patch" Content-Disposition: attachment; filename="fix-describe.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k68406yb0 ZGlmZiAtLWdpdCBhL2d1aXgvc2NyaXB0cy9wdWxsLnNjbSBiL2d1aXgvc2NyaXB0cy9wdWxsLnNj bQppbmRleCBjYjFiZTk4OWUxLi40MDhkYjcwNTU1IDEwMDY0NAotLS0gYS9ndWl4L3NjcmlwdHMv cHVsbC5zY20KKysrIGIvZ3VpeC9zY3JpcHRzL3B1bGwuc2NtCkBAIC0yMTAsOSArMjEwLDExIEBA IERvd25sb2FkIGFuZCBkZXBsb3kgdGhlIGxhdGVzdCB2ZXJzaW9uIG9mIEd1aXguXG4iKSkKIAog KGRlZmluZSogKGNoYW5uZWwtY29tbWl0LWh5cGVybGluayBjaGFubmVsCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICM6b3B0aW9uYWwKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgKGNvbW1pdCAoY2hhbm5lbC1jb21taXQgY2hhbm5lbCkpKQorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAoY29tbWl0IChjaGFubmVsLWNvbW1pdCBjaGFubmVs KSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHRyYW5zZm9ybWVyIGh5cGVy bGluaykpCiAgICJSZXR1cm4gYSBoeXBlcmxpbmsgZm9yIENPTU1JVCBpbiBDSEFOTkVMLCB1c2lu ZyBDT01NSVQgYXMgdGhlIGh5cGVybGluaydzCi10ZXh0LiAgVGhlIGh5cGVybGluayBsaW5rcyB0 byBhIHdlYiB2aWV3IG9mIENPTU1JVCwgd2hlbiBhdmFpbGFibGUuIgordGV4dC4gIFRoZSBoeXBl cmxpbmsgbGlua3MgdG8gYSB3ZWIgdmlldyBvZiBDT01NSVQsIHdoZW4gYXZhaWxhYmxlLgorVFJB TlNGT1JNRVIgYWxsb3dzIHRvIGNvbnRyb2wgaG93IHRoZSB1cmkgYW5kIHRleHQgYXJlLiIKICAg KGxldCogKCh1cmwgIChjaGFubmVsLXVybCBjaGFubmVsKSkKICAgICAgICAgICh1cmkgIChzdHJp bmctPnVyaSB1cmwpKQogICAgICAgICAgKGhvc3QgKGFuZCB1cmkgKHVyaS1ob3N0IHVyaSkpKSkK QEAgLTIyMSw3ICsyMjMsNyBAQCB0ZXh0LiAgVGhlIGh5cGVybGluayBsaW5rcyB0byBhIHdlYiB2 aWV3IG9mIENPTU1JVCwgd2hlbiBhdmFpbGFibGUuIgogICAgICAgICAgICgjZgogICAgICAgICAg ICBjb21taXQpCiAgICAgICAgICAgKChfIHRlbXBsYXRlKQotICAgICAgICAgICAoaHlwZXJsaW5r ICh0ZW1wbGF0ZSB1cmwgY29tbWl0KSBjb21taXQpKSkKKyAgICAgICAgICAgKHRyYW5zZm9ybWVy ICh0ZW1wbGF0ZSB1cmwgY29tbWl0KSBjb21taXQpKSkKICAgICAgICAgY29tbWl0KSkpCiAKIChk ZWZpbmUqIChkaXNwbGF5LXByb2ZpbGUtbmV3cyBwcm9maWxlICM6a2V5IGNvbmNpc2U/CkBAIC01 ODMsNyArNTg1LDExIEBAIHdheSBhbmQgZGlzcGxheWluZyBkZXRhaWxzIGFib3V0IHRoZSBjaGFu bmVsJ3Mgc291cmNlIGNvZGUuIgogICAgICAgICAgICAgICAgICAgIChmb3JtYXQgI3QgKEdfICIg ICAgY29tbWl0OiB+YX4lIikKICAgICAgICAgICAgICAgICAgICAgICAgICAgIChpZiAoc3VwcG9y dHMtaHlwZXJsaW5rcz8pCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNoYW5uZWwt Y29tbWl0LWh5cGVybGluayBjaGFubmVsIGNvbW1pdCkKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBjb21taXQpKSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29tbWl0 KSkKKyAgICAgICAgICAgICAgICAgICAod2hlbiAobm90IChzdXBwb3J0cy1oeXBlcmxpbmtzPykp CisgICAgICAgICAgICAgICAgICAgICAoZm9ybWF0ICN0IChHXyAiICAgIFVSTDogfmF+JSIpCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIChjaGFubmVsLWNvbW1pdC1oeXBlcmxpbmsgY2hh bm5lbCBjb21taXQKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAobGFtYmRhICh1cmwgbXNnKSB1cmwpKSkpKSkKICAgICAgICAgICAgICAgICAo XyAjZikpKQogCiAgICAgICAgICAgICA7OyBTaG93IG1vc3QgcmVjZW50bHkgaW5zdGFsbGVkIHBh Y2thZ2VzIGxhc3QuCmRpZmYgLS1naXQgYS9ndWl4L3VpLnNjbSBiL2d1aXgvdWkuc2NtCmluZGV4 IDQ4NTdhODg4MjcuLmVlNTZjMjMzNjIgMTAwNjQ0Ci0tLSBhL2d1aXgvdWkuc2NtCisrKyBiL2d1 aXgvdWkuc2NtCkBAIC0xNjI1LDcgKzE2MjUsNyBAQCBEVVJBVElPTi1SRUxBVElPTiB3aXRoIHRo ZSBjdXJyZW50IHRpbWUuIgogICAgIChsZXQqICgoZmlsZSAgIChnZW5lcmF0aW9uLWZpbGUtbmFt ZSBwcm9maWxlIG51bWJlcikpCiAgICAgICAgICAgIChsaW5rICAgKGlmIChzdXBwb3J0cy1oeXBl cmxpbmtzPykKICAgICAgICAgICAgICAgICAgICAgICAgKGN1dCBmaWxlLWh5cGVybGluayBmaWxl IDw+KQotICAgICAgICAgICAgICAgICAgICAgICBpZGVudGl0eSkpCisgICAgICAgICAgICAgICAg ICAgICAgIChjdXQgZm9ybWF0ICNmIChHXyAifmF+JWZpbGU6IH5hIikgPD4gZmlsZSkpKQogICAg ICAgICAgICAoaGVhZGVyIChmb3JtYXQgI2YgKGxpbmsgKGhpZ2hsaWdodCAoR18gIkdlbmVyYXRp b24gfmFcdH5hIikpKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgbnVtYmVyCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAoZGF0ZS0+c3RyaW5nCg== --000000000000c7aa54059dc2b452--